Skip to content
This repository

Jun 09, 2012

  1. Tieg Zaharia

    ActiveRecord#attributes optimization: minimize objects created

    authored

Mar 28, 2012

  1. Jon Leighton

    Fix #5549.

    authored

Mar 07, 2012

  1. José Valim

    Merge pull request #5316 from Jacobkg/master

    Update ActiveRecord::AttributeMethods#attribute_present? to return false for empty strings
    authored

Jan 31, 2012

  1. Jon Leighton

    Improve deprecation message

    authored
  2. Jon Leighton

    Add workaround and deprecation if the inherited hook is not executed.…

    … Closes #4757.
    authored

Jan 20, 2012

  1. Jon Leighton

    Fix another race condition.

    From 2c667f6.
    
    Thanks @pwnall for the heads-up.
    
    Conflicts:
    
    	activerecord/lib/active_record/core.rb
    authored

Jan 13, 2012

  1. Jon Leighton

    Fix race condition :bomb:

    authored

Jan 11, 2012

  1. Santiago Pastorino

    Merge pull request #4408 from tomstuart/read-and-write-attribute-aliases

    #[] and #[]= are no longer interchangeable with #read_attribute and #write_attribute
    authored

Dec 23, 2011

  1. Jon Leighton

    Fix situation where id method didn't get defined causing postgres to …

    …fail
    authored
  2. Jon Leighton

    Fix #4046.

    authored

Dec 15, 2011

  1. Jon Leighton

    Let AttributeMethods do its own including etc

    authored
  2. Jon Leighton

    Split out most of the AR::Base code into separate modules :cake:

    authored

Dec 14, 2011

  1. Jon Leighton

    Use a separate module for 'external' attribute methods.

    authored

Dec 01, 2011

  1. Jon Leighton

    Remove the need for type_cast_attribute.

    This is good because it reduces duplication.
    authored
  2. Jon Leighton

    Remove unnecessary *args

    authored

Sep 13, 2011

  1. Jon Leighton

    Stop trying to be clever about when to define attribute methods.

    There is no meaningful performance penalty in defining attribute
    methods, since it only happens once.
    
    There is also no reason *not* to define them, since they get thrown in
    an included module, so they will not 'overwrite' anything. In fact, this
    is desirable, since it allows us to call super.
    authored
  2. Jon Leighton

    We don't need to build a set for DangerousAttributeError.

    We can just use method_defined? and private_method_defined?
    authored

Sep 12, 2011

  1. Jon Leighton

    Deprecate using method_missing for attributes that are columns.

    This shouldn't ever happen unless people are doing something
    particularly weird, but adding a deprecation in case there are bugs not
    caught by our tests.
    authored
  2. Jon Leighton

    Let Ruby deal with method visibility.

    Check respond_to_without_attributes? in method_missing. If there is any
    method that responds (even private), let super handle it and raise
    NoMethodError if necessary.
    authored
  3. Jon Leighton

    Always generate attribute methods on the base class.

    This fixes a situation I encountered where a subclass would cache the
    name of a generated attribute method in @_defined_class_methods. Then,
    when the superclass has it's attribute methods undefined, the subclass
    would always have to dispatch through method_missing, because the
    presence of the attribute in @_defined_class_methods would mean that it
    is never generated again, even if undefine_attribute_methods is called
    on the subclass.
    
    There various other confusing edge cases like this. STI classes share
    columns, so let's just keep all the attribute method generation state
    isolated to the base class.
    authored
  4. Jon Leighton

    Fix warnings.

    Make sure we don't redefine an already-defined attribute method.
    authored

Jun 30, 2011

  1. Aaron Patterson

    match method signature of the superclass

    authored

Mar 01, 2011

  1. Alexander Uvarov

    Move ActiveModel::AttributeMethods#attribute_methods_generated? to Ac…

    …tiveRecord, so it's flexible now
    
    [#6428 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    authored josevalim committed

Feb 19, 2011

  1. Aaron Patterson

    instance_methods includes public and protected, so reduce funcalls an…

    …d object allocs
    authored

Feb 18, 2011

  1. Aaron Patterson

    AR::AttributeMethods does not need to be included in an AR::Base class.

    authored
  2. Aaron Patterson

    just use the list of column names to generate attribute methods

    authored

Dec 02, 2010

  1. Michael Koziarski

    Work around a strange piece of Syck behaviour where it checks Model#r…

    …espond_to? before initializing the object.
    
    Things like YAML.load(YAML.dump(@post)) won't work without this.
    authored tenderlove committed

Oct 19, 2010

  1. Aaron Patterson

    "instance_methods" includes public and protected

    authored

Sep 09, 2010

  1. Jeremy Kemper

    Cheaper attribute reads and respond_to?. Add underscore-prefixed meth…

    …od aliased to the attribute name so it can be overridden but still called internally.
    authored

Jun 15, 2010

  1. Rizwan Reza

    Adds title and basic description where needed.

    authored

May 08, 2010

  1. Yehuda Katz

    eliminate alias_method_chain from ActiveRecord

    authored

Nov 14, 2009

  1. Jeremy Kemper

    No need to check for generated method, just redispatch

    authored

Aug 05, 2009

  1. Joshua Peek

    Extract generic attribute method generation to AMo

    authored

Aug 04, 2009

  1. Joshua Peek

    whitespace

    authored
  2. Paul Gillard

    Modified ActiveRecord::AttributeMethods to allow classes to specify a…

    …ttribute method prefixes and/or suffixes. Previously only suffixes were allowed.
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
    authored josh committed
Something went wrong with that request. Please try again.