Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jun 7, 2012
  1. @jonleighton

    Revert "Perf: Don't load the association for #delete_all."

    jonleighton authored
    This reverts commit b98d1e2.
    Closes #6609
Commits on May 19, 2012
  1. @drogus

    Ensure that CollectionAssociation#replace returns proper target

    drogus authored
    The fix commited in e2a070c was returning the `new_target`, as
    a try to return whatever user replaced association with. The
    problem is, the resulting association target may be ordered
    differently. In such case we want to return the target that
    will be later used for that association.
Commits on May 18, 2012
  1. @jonleighton

    Perf: Don't load the association for #delete_all.

    jonleighton authored
    Bug #6289
Commits on May 17, 2012
  1. @drogus

    Fix CollectionAssociation#replace to return new target (closes #6231)

    drogus authored
Commits on Jan 31, 2012
  1. @jonleighton

    Merge pull request #4783 from gregolsen/ids_reader_fix

    jonleighton authored
    ids_reader method fixed, test added to has_many association (for PostgreSQL)
Commits on Dec 18, 2011
  1. @lest

    bypass preloading for ids_reader

    lest authored
    when fetching ids for a collection, bypass preloading
    to avoid the unnecessary performance overhead
Commits on Dec 14, 2011
  1. @jonleighton
Commits on Nov 25, 2011
  1. @samsonasu

    load has_many associations keyed off a custom primary key if that key…

    samsonasu authored
    … is present but the record is unsaved
Commits on Nov 4, 2011
  1. @jeremy

    Merge pull request #3507 from jmazzi/issue-3503

    jeremy authored
    Preserve SELECT columns on the COUNT for finder_sql when possible
Commits on Jul 24, 2011
  1. @oem

    Changed a few instances of of words in the API docs written in Britis…

    oem authored
    …h English to
    American English(according to Weber)
Commits on Jul 6, 2011
  1. @lysenko

    Fix bug in collection_singular_ids on has many through association wi…

    lysenko authored
    …th conditions and includes,
    when condtions references tables from includes.
    Test fail because of invalid sql:
    ActiveRecord::StatementInvalid: SQLite3::SQLException: no such column:
    SELECT "posts".id FROM "posts" INNER JOIN "readers" ON "posts"."id" = "readers"."post_id"
    WHERE "readers"."person_id" = 1 AND ( is null)
    Bug described in github#925
    This commit will revert fix from 3436fdf , but tests is ok.
    Bug described in #6569 ticket.
Commits on Jul 5, 2011
  1. @bogdan

    Fixed CollectionAssociation#find to be compatible with Array#find

    bogdan authored
    In order to make CollectionAssociation behave closer to Array
    Add the ability to pass block to #find method just like Array#find does.
Commits on Jun 30, 2011
  1. @jonleighton

    Assign the association attributes to the associated record before the…

    jonleighton authored
    … before_initialize callback of the record runs. Fixes #1842.
Commits on Jun 12, 2011
  1. @jonleighton
  2. @benedikt @jonleighton

    Don't wrap operations on collection associations in transactions when…

    benedikt authored jonleighton committed
    … they are not needed, so the connection adapter does not send empty BEGIN COMMIT transactions blocks to the database.
Commits on Jun 3, 2011
  1. @pixeltrix
Commits on May 31, 2011
  1. @jonleighton
  2. @jonleighton

    Implementing @dmathieu's cleaner fix from #1425. Unfortunately he del…

    jonleighton authored
    …eted the branch so I cannot just merge it.
  3. @arunagw
  4. @arunagw
Commits on May 23, 2011
  1. @smartinez87
Commits on May 17, 2011
  1. @pixeltrix

    Pass the attribute and option hashes to build_association

    pixeltrix authored
    The build_association method was added as an API for plugins
    to hook into in 1398db0. This commit restores this API and the
    ability to override to return a subclass based on
    a virtual attribute in the attributes hash.
Commits on May 14, 2011
  1. @jonleighton

    These extra array operations appear to be unnecessary. Reasoning:

    jonleighton authored
     * It is not necessary to subtract 'id' from the list of copied attributes because record and mem_record are equal, so therefore their id attributes are also equal (so there is no harm in copying it, and this reduces the complexity of the code)
     * It is not necessary to intersect the attribute names, since record and mem_record are equal, so they have the same id and class, so they have the same columns in the database. If record has non-column attributes then it seems reasonable to also copy them onto mem_record (though I am not sure what situation this would ever happen in)
  2. @jonleighton

    CollectionAssociation#merge_target_lists should write to the underlyi…

    jonleighton authored
    …ng attributes when copying, rather than using the assignment method
  3. @jonleighton
Commits on May 13, 2011
  1. @jonleighton

    Instead of doing find(:all) which does scoped.find(:all) which does s…

    jonleighton authored
    …coped.all, just do scoped.all.
  2. @jonleighton

    Remove pointless rescue (it doesn't happen anywhere in the tests, and…

    jonleighton authored
    … I can't see a way that it would happen ever)
Commits on May 11, 2011
  1. @BlackBulletIV
Commits on May 10, 2011
  1. @jonleighton

    Remove unnecessary '|| {}'

    jonleighton authored
  2. @jonleighton
  3. @josevalim
  4. @josevalim

    Revert "b9ea751d0e56bd00d341766977a607ed3f7ddd0f".

    josevalim authored
    Wrapping each in a transaction is going to
    make several unneeded queries. Reverting this commit also fixes #479.
Commits on May 1, 2011
  1. @joshk

    singular and collection relations in AR can now specify mass-assignme…

    joshk authored
    …nt security options (:as and :without_protection) in build, create and create! methods.
Commits on Apr 13, 2011
  1. @jonleighton @tenderlove

    Removing the scope-caching which happens on association proxies, beca…

    jonleighton authored tenderlove committed
    …use the query is already cached by the query cacher. For formalised proof see
Commits on Mar 10, 2011
  1. @jonleighton

    Move the code which builds a scope for through associations into a ge…

    jonleighton authored
    …neric AssociationScope class which is capable of building a scope for any association.
Something went wrong with that request. Please try again.