Skip to content
Commits on Aug 28, 2012
  1. @rafaelfranca

    Merge pull request #7470 from kennyj/fix_method_redefined_warning

    rafaelfranca committed Aug 28, 2012
    Fix method redefined warnings.
  2. @kennyj

    Fix method redefined warnings.

    kennyj committed Aug 29, 2012
  3. @josevalim

    Merge pull request #7469 from kennyj/fix_many_warnings_in_am

    josevalim committed Aug 28, 2012
    Fixes warnings when executing rake test in ActionMailer.
  4. @kennyj
  5. @josevalim

    Merge pull request #7468 from kennyj/tiny_fixings

    josevalim committed Aug 28, 2012
    Tiny fixes in railties/test/application.
  6. @kennyj

    Remove unused require.

    kennyj committed Aug 29, 2012
  7. @kennyj

    Fixes wrong test class names.

    kennyj committed Aug 29, 2012
  8. @fxn

    fixes a bug in dependencies.rb

    fxn committed Aug 28, 2012
    loaded stores file names without the .rb extension, but search_for_file
    returns file names with the extension.
    
    The solution is hackish, but this file needs a revamp.
  9. @rafaelfranca

    Merge pull request #7466 from arunagw/warning_removed_ap

    rafaelfranca committed Aug 28, 2012
    removed :  warning: `*' interpreted as argument prefix
  10. @arunagw
  11. @rafaelfranca

    Add missing require

    rafaelfranca committed Aug 28, 2012
  12. @rafaelfranca

    Merge pull request #7452 from arunagw/memcached_dalli

    rafaelfranca committed Aug 28, 2012
    Memcached to dalli for actionpack test.
  13. @josevalim

    Merge pull request #7465 from wpp/generator_controller_plural

    josevalim committed Aug 28, 2012
    Change generators controller help from singular to plural example.
  14. Change generators controller help from singular to plural example.

    Philipp Weissensteiner committed Aug 28, 2012
    When running `rails generate controller --help` an example
    with creating a (singular) "CreditCard" controller is
    shown. The convention is to generate controllers with plural
    names though.
  15. @rafaelfranca

    Merge pull request #7458 from frodsan/fix_orddep_basics

    rafaelfranca committed Aug 28, 2012
    fix order dependent test in AR::BasicsTest
  16. @drogus

    Merge branch 'actionview-decoupling'

    drogus committed Aug 28, 2012
    This branch contains set of changes that will allow to extract Action
    View out of Action Pack in the future. This work will be probably done
    after Rails 4.0 release, because of a few deprecations that were done
    to make decoupling possible.
  17. @drogus
  18. @drogus

    Deprecate AV::RecordIdentifier in controllers

    drogus committed Aug 25, 2012
    Methods provided by RecordIdentifier are not widely used in controllers
    nowadays as they're view specific (this is probably a legacy left after
    RJS rendering directly in controllers). However if people still need to
    use it, it's trivial to include ActionView::RecordIdentifier by
    themselves.
  19. @drogus

    Fix ActionView::RecordIdentifier to work as a singleton

    drogus committed Aug 25, 2012
    We extend it with self, but the methods were not working properly were
    used directly on module.
  20. @drogus

    No need to use included hook for include

    drogus committed Aug 25, 2012
    When module is extended ActiveSupport::Concern, include calls are lazily
    loaded, so there is no need to wrap it with included hook.
  21. @drogus

    Deprecate Template#mime_type

    drogus committed Aug 25, 2012
  22. @drogus
  23. @drogus

    Implement ActionView::Template::Types

    drogus committed Jul 5, 2012
    AV::Template::Types is a small abstraction to allow to specify template types
    that can be used in ActionView. When Action Pack is loaded it's replaced with
    Mime::Type.
  24. @drogus

    Don't require action_dispatch in ActionView::UrlHelpers

    drogus committed Jun 21, 2012
    ActionDispatch::Routing::UrlFor was always required in UrlHelpers. This
    was changed by splitting previous implementation of UrlHelper into 2
    modules: ActionView::Helpers::UrlHelper and
    ActionView::Routing::UrlHelper. The former one keeps only basic
    implementation of url_for. The latter adds features that allow to use
    routes and is only required when url_helpers or mounted_helpers are
    required.
  25. @drogus
  26. @drogus

    Add ActionView::Base.default_formats

    drogus committed Jun 15, 2012
    default_formats array is used by LookupContext in order to allow
    rendering templates when :formats option is not passed. Previously it
    was always set to Mime::SET, which created dependency on Action Pack. In
    order to remove this dependency, Mime::SET is used only if
    ActionController is loaded.
  27. @drogus

    Remove Mime::Type translations from Action View

    drogus committed Jun 15, 2012
    Action View should not be responsible for translating mime types. Any
    translation that's needed should be handled at controller level.
  28. @drogus

    Deprecate mime types lookup in auto_discovery_link_tag

    drogus committed Aug 11, 2012
    Automatically handling mime types for things other than :rss and :atom
    is not functionality that justifies dependency on Mime::Type from
    actionpack.
  29. @drogus

    Remove comment about getting rid of old AV::Base.new behavior

    drogus committed Jun 14, 2012
    I've talked to José Valim, who added this comment, and there is no need
    to remove old API. It's good to have a simple way to instantiate
    ActionView::Base, by just passing view paths as a first argument,
    instead of constructing LookupContext and then the Renderer.
    
    [ci skip]
  30. @drogus

    Remove stubs from LogSubscriber tests

    drogus committed Jun 14, 2012
    We can use another way to instantiate ActionView::Base, by passing
    renderer as a first option. Thanks to that we can just pass prefixes to
    LookupContext instead stubbing them on the controller. This is also good,
    because that kind of API is used in Rails code.
  31. @drogus

    Move action_controller/vendor/html-scanner to action_view

    drogus committed Jun 9, 2012
    This is another step in moving Action View's dependencies in Action Pack
    to Action View itself. Also, HtmlScanner seems to be better suited for
    views rather than controllers.
  32. @drogus
  33. @drogus

    Add ActionView::ModelNaming

    drogus committed Aug 15, 2012
    It's just a duplicate of ActionController::ModelNaming. These are just a
    simple helpers for decoupling Active Model, so it does not make sense to
    extract it to Active Support, but the point is to decouple also Action
    View and Action Pack
  34. @drogus

    Move ActionController::RecordIdentifier to ActionView

    drogus committed Jun 9, 2012
    Since it's more about DOM classes and ids it belongs to Action View
    better. What's more, it's more convenient to make it part of Action View
    to follow the rule that Action Pack can depend on Action View, but not
    the other way round.
  35. @drogus

    Remove dependency on actionpack in ActionView::AssetPaths

    drogus committed Aug 11, 2012
    Since Action View should not depend on actionpack, it's best to delegate
    invalid_asset_host! to controller and just rely on such simple contract
    instead of raising ActionController::RoutingError directly.
Something went wrong with that request. Please try again.