Permalink
Commits on May 25, 2012
  1. Merge pull request #6487 from avakhov/range-sum-optimization

    Fix Range#sum optimized version
    rafaelfranca committed May 25, 2012
  2. Fix Range#sum optimized version

    At 1bd4d1c was added Range#sum
    optimized version for arithmetic progressions. This improvment injected
    a defect with not integer range boundaries. The defect was fixed by
    e0adfa8. The second commit really
    disabled optimization at all because in Ruby integer-valued numbers are
    instances of Fixnum and Bignum classes. We should #use is_a?
    (#kind_of?) method instead #instance_of? to check if value is numerical:
    
        1.class                 # => Fixnum
        1.instance_of?(Integer) # => false
        1.is_a?(Integer)        # => true
    
        -100_000_000_000.class                 # => Bignum
        -100_000_000_000.instance_of?(Integer) # => false
        -100_000_000_000.is_a?(Integer)        # => true
    
    Moreover original implementation of Range#sum has a defect with reverse
    range boundaries. If the first boundary is less than the second range is
    empty. Current commit fixes and tests this case too.
    avakhov committed May 25, 2012
  3. Merge pull request #4785 from ayamomiji/add-self-to-allow-method-name…

    …-using-ruby-keyword
    
    add `self.` to allow method name using ruby keyword
    josevalim committed May 25, 2012
  4. Merge pull request #6482 from waseem/fix_build_4008

    Fixes build 4008.1
    josevalim committed May 25, 2012
  5. Fixes build 4008.1

    This fixex build 4008.1[1] because of the changes made in
    
    4001835
    
    [1] http://travis-ci.org/#!/rails/rails/jobs/1429671
    waseem committed May 25, 2012
  6. Merge pull request #6481 from schneems/schneems/sextant-routes

    Remove Unnecessary Test from route_inspect_test
    rafaelfranca committed May 25, 2012
Commits on May 24, 2012
  1. `name` should be public.

    tenderlove committed May 24, 2012
  2. Merge pull request #5925 from Juanmcuello/pg_structure_dump

    Quote arguments in db:structure:dump for PostgreSQL.
    carlosantoniodasilva committed May 24, 2012
  3. Use deep_dup in the deep_transform_keys tests.

    Using only dup make some tests to not catch up an implementation error
    because the methods were changing the nested hashes.
    
    Related to:
    541429f#L1R96
    rafaelfranca committed May 24, 2012
  4. Merge pull request #6461 from schneems/schneems/sextant-routes

    View your Routes without waiting on Rake
    pixeltrix committed May 24, 2012
  5. Rails::InfoController tests passing

    This includes new tests for /rails/info/routes
    schneems committed May 23, 2012
  6. /rails/info/routes path shows routing information

    Will show similar contents to the output of `$ rake routes` in the browser in development. This speeds the time required to generate routes, since the application is already initialized.
    schneems committed May 22, 2012
  7. Merge pull request #6471 from parndt/rails_root_should_be_join_able

    Fixes possible backward incompatibility
    josevalim committed May 24, 2012
  8. Merge pull request #6447 from chancancode/add_backporting_instruction…

    …s_to_contrib_guides
    
    Added instructions for backporting changes to guides.
    drogus committed May 24, 2012
  9. Fixed backward incompatibility for engines.

    - Many engines rely on being able to join directories to the Rails root:
    
        Rails.root.join('somedir')
    
    - This was now impossible because Rails.root returned a String:
    
        NoMethodError: undefined method `join' for "/code/myrailsapp":String
    
    - This was broken in 4001835
    parndt committed May 24, 2012
Commits on May 23, 2012
  1. Revert "require the constants we use. ensure that root always returns…

    … a Pathname"
    
    This reverts commit d77b576.
    tenderlove committed May 23, 2012
  2. removing more pathnameisms

    tenderlove committed May 23, 2012
  3. Merge pull request #6466 from markmcspadden/hash_deep_transform_keys

    Add Hash#deep_transform_keys and Hash#deep_transform_keys! Also convert ...
    rafaelfranca committed May 23, 2012
  4. Whitespaces ✂️

    rafaelfranca committed May 23, 2012
  5. PGconn doesn't accepts :checkout_timeout option.

    This option was added on cb6f839
    renaming the :wait_timeout option.
    
    Fix build http://travis-ci.org/#!/rails/rails/jobs/1413405
    rafaelfranca committed May 23, 2012
  6. Add Hash#deep_transform_keys and Hash#deep_transform_keys! Also conve…

    …rt deep_*_keys to use deep_transform_keys.
    markmcspadden committed May 23, 2012
  7. Added instructions for backporting changes to guides.

    I was looking for instructions on backporting changes the other day and
    wasn't able to find it anywhere. I updated the contrib guides based on
    the disccusion in #6420, #6215 and #6447.
    chancancode committed May 22, 2012
  8. Merge pull request #6383 from oscardelben/add_oscardelben_to_authors

    Add oscardelben to authors
    vijaydev committed May 23, 2012
  9. Merge pull request #6194 from ayrton/optimized_images

    Optimizing all images used in the guides
    vijaydev committed May 23, 2012
  10. Merge pull request #6462 from grosser/feature/licenses

    Add license field to gemspecs, by Matt Griffin
    josevalim committed May 23, 2012
  11. Revert "Remove Obsolute root specifiying short syntax"

    This reverts commit feaa7b3.
    
    Reason: Incorrect change. That's a Rails 4 feature and will not
    obviously work in 3.2.3.
    
    [ci skip]
    vijaydev committed May 23, 2012