Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Feb 25, 2013
  1. @fxn

    removes redundant require

    fxn authored
    It turns out this file is required in active_record.rb.
  2. @fxn
Commits on Aug 17, 2012
  1. @jonleighton

    Renaming active_record_deprecated_finders to activerecord-deprecated_…

    jonleighton authored
    …finders
    
    For consistency with the other AR extension plugins we are creating.
Commits on Jul 27, 2012
  1. @rafaelfranca

    Revert "Removing composed_of from ActiveRecord."

    rafaelfranca authored
    This reverts commit 14fc8b3.
    
    Reason: we need to discuss a better path from this removal.
    
    Conflicts:
    	activerecord/lib/active_record/reflection.rb
    	activerecord/test/cases/base_test.rb
    	activerecord/test/models/developer.rb
Commits on Jun 22, 2012
  1. @mschneider

    made dynamic finders alias_attribute aware

    mschneider authored
    previously dynamic finders only worked in combination with the actual
    column name and not its alias defined with #alias_attribute
Commits on Jun 18, 2012
  1. @steveklabnik

    Removing composed_of from ActiveRecord.

    steveklabnik authored
    This feature adds a lot of complication to ActiveRecord for dubious
    value. Let's talk about what it does currently:
    
    class Customer < ActiveRecord::Base
      composed_of :balance, :class_name => "Money", :mapping => %w(balance amount)
    end
    
    Instead, you can do something like this:
    
        def balance
          @balance ||= Money.new(value, currency)
        end
    
        def balance=(balance)
          self[:value] = balance.value
          self[:currency] = balance.currency
          @balance = balance
        end
    
    Since that's fairly easy code to write, and doesn't need anything
    extra from the framework, if you use composed_of today, you'll
    have to add accessors/mutators like that.
    
    Closes #1436
    Closes #2084
    Closes #3807
Commits on May 4, 2012
  1. @jonleighton
  2. @jonleighton
  3. @jonleighton

    #to_sym is unnecessary

    jonleighton authored
  4. @jonleighton

    de-globalise method

    jonleighton authored
  5. @jonleighton
  6. @jonleighton
Commits on Mar 3, 2012
  1. @carlosantoniodasilva

    Refactor and cleanup in some ActiveRecord modules

    carlosantoniodasilva authored
    * Avoid double hash lookups in AR::Reflection when reflecting associations/aggregations
    * Minor cleanups: use elsif, do..end, if..else instead of unless..else
    * Simplify DynamicMatchers#respond_to?
    * Use "where" instead of scoped with conditions hash
    * Extract `scoped_by` method pattern regexp to constant
    * Extract noisy class_eval from method_missing in dynamic matchers
    * Extract readonly check, avoid calling column#to_s twice in persistence
    * Refactor predicate builder, remove some variables
Commits on Jan 28, 2012
  1. @pwim
Commits on Jan 27, 2012
  1. @pwim

    Fix regression from Rails 3.1

    pwim authored
    Under Rails 3.1, you were allowed to pass a hash to a find_or_create
    method with multiple attribute names, but this was broken as the
    arguments were being improperly validated.
Commits on Dec 15, 2011
  1. @jonleighton
Something went wrong with that request. Please try again.