Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 31, 2012
Commits on Oct 8, 2012
  1. @packagethief
Commits on Sep 21, 2012
  1. @spastorino

    start could be a string

    spastorino authored
    Related to 761bc75 and
    eb876c4
  2. @spastorino

    Revert "Fix find_in_batches with customized primary_key"

    spastorino authored
    This reverts commit 761bc75.
    
    This commit wasn't fixing any issue just using the same table for
    different models with different primary keys.
Commits on Sep 16, 2012
  1. @toshi-kawanishi
Commits on Aug 2, 2012
  1. @fxn
Commits on Jul 27, 2012
  1. @jonleighton

    Deprecate Relation#all.

    jonleighton authored
    It has been moved to active_record_deprecated_finders.
    
    Use #to_a instead.
Commits on Jul 17, 2012
  1. @oscardelben

    Update batches docs

    oscardelben authored
Commits on May 30, 2012
  1. @vijaydev
Commits on May 28, 2012
  1. @alvaropereyra
Commits on Apr 13, 2012
  1. @jonleighton
Commits on Sep 4, 2011
  1. @arunagw
Commits on Jul 14, 2011
  1. @spastorino

    Merge pull request #1807 from caius/find_in_batches_id_bug

    spastorino authored
    Bugfix by stopping find_in_batches using the records after yielding.
Commits on Jul 7, 2011
  1. @knapo

    Make `ActiveRecord::Batches#find_each` to not return `self`.

    knapo authored
    This caused that `find_each` was producing extra db call taking all the records from db, and was less efficient than `ActiveRecord::Base#all`.
Commits on Jun 21, 2011
  1. @caius

    Stop find_in_batches using the records after yielding.

    caius authored
    Currently if the code that calls .find_in_batches modifies the yielded array in place then .find_in_batches can enter an infinite loop searching with ruby object ids in the database instead of the primary key of records in the database. This happens because it naively assumes the yielded array hasn't been modified before calling #id on the last object in the array. And ruby (1.8 at least) alias' #id to #object_id so an integer is still returned no matter what the last object is.
    
    By moving finding the #id of the last object before yielding the array it means the calling code can do whatever it wants to the array in terms of modifying it in place, and .find_in_batches doesn't care.
Commits on Mar 29, 2011
  1. @pixeltrix
Commits on Feb 18, 2011
  1. @nixterrimus
Commits on Jan 4, 2011
  1. @jonleighton @tenderlove

    ActiveRecord::Relation#primary_key should return a string, just like …

    jonleighton authored tenderlove committed
    …ActiveRecord::Base.primary_key does.
Commits on Sep 21, 2010
  1. @fxn

    un-nodocs AR::Batches

    fxn authored
Commits on Sep 10, 2010
  1. @tenderlove
Commits on Aug 4, 2010
  1. @tenderlove
  2. @tenderlove

    fisting indentation

    tenderlove authored
Commits on May 9, 2010
  1. @lifo

    Improve code from 231d767

    lifo authored
  2. @joshk @josevalim

    corrected AR find_each and find_in_batches to raise when the user use…

    joshk authored josevalim committed
    …s select but does not specify the primary key
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Mar 29, 2010
  1. @miloops
Commits on Mar 28, 2010
  1. @fxn
Commits on Feb 12, 2010
  1. @lifo

    Move batch finders to Relation

    lifo authored
Something went wrong with that request. Please try again.