Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Sep 21, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	actionmailer/lib/action_mailer/base.rb
    	activesupport/lib/active_support/configurable.rb
    	activesupport/lib/active_support/core_ext/module/deprecation.rb
    	guides/source/action_controller_overview.md
    	guides/source/active_support_core_extensions.md
    	guides/source/ajax_on_rails.textile
    	guides/source/association_basics.textile
    	guides/source/upgrading_ruby_on_rails.md
    
    While resolving conflicts, I have chosen to ignore changes done in
    docrails at some places - these will be most likely 1.9 hash syntax
    changes.
  2. @jonleighton

    Support for specifying transaction isolation level

    jonleighton authored
    If your database supports setting the isolation level for a transaction,
    you can set it like so:
    
      Post.transaction(isolation: :serializable) do
        # ...
      end
    
    Valid isolation levels are:
    
    * `:read_uncommitted`
    * `:read_committed`
    * `:repeatable_read`
    * `:serializable`
    
    You should consult the documentation for your database to understand the
    semantics of these different levels:
    
    * http://www.postgresql.org/docs/9.1/static/transaction-iso.html
    * https://dev.mysql.com/doc/refman/5.0/en/set-transaction.html
    
    An `ActiveRecord::TransactionIsolationError` will be raised if:
    
    * The adapter does not support setting the isolation level
    * You are joining an existing open transaction
    * You are creating a nested (savepoint) transaction
    
    The mysql, mysql2 and postgresql adapters support setting the
    transaction isolation level. However, support is disabled for mysql
    versions below 5, because they are affected by a bug
    (http://bugs.mysql.com/bug.php?id=39170) which means the isolation level
    gets persisted outside the transaction.
  3. @steveklabnik

    Add extra note about :dependent => :destroy.

    steveklabnik authored
    Callbacks may interfere with each other.
  4. @jonleighton

    Merge pull request #5248 from jcoleman/should-unset-association-when-…

    jonleighton authored
    …an-existing-record-is-destroyed
    
    Unset association when existing record is destroyed.
Commits on Sep 20, 2012
  1. rename AR::Model::Tag to AR::Tag - fixes #7714

    Francesco Rodriguez authored
  2. @spastorino
  3. @spastorino
  4. @tenderlove

    Merge pull request #7631 from jeremyevans/patch-1

    tenderlove authored
    Freeze columns before using them as hash keys
  5. update AR::AttributeAssignment documentation [ci skip]

    Francesco Rodriguez authored
  6. @rafaelfranca

    Merge pull request #7710 from guilleiguaran/refactor-ar-attributes-me…

    rafaelfranca authored
    …thod
    
    AR::Base#attributes= is just an alias for AR::Base#assign_attributes
  7. @guilleiguaran
  8. @alexreisner

    Fix out-of-date URL.

    alexreisner authored
Commits on Sep 19, 2012
  1. @jeremy
  2. @jeremy

    Revert "Make sure :environment task is executed before db:schema:load…

    jeremy authored
    … or db:structure:load
    "
    
    Breaks db:setup because it tries to load the environment before creating the database.
    
    This reverts commit 5ca11fe.
  3. @dmathieu

    fix querying with an empty hash

    dmathieu authored
    Closes #6960
  4. @guilleiguaran

    Remove unused private method AR::NestedAttributes#unassignable_keys a…

    guilleiguaran authored
    …nd reference to mass_assignment options
  5. fix :nodoc:s in AR::Timestamp [ci skip]

    Francesco Rodriguez authored
  6. @guilleiguaran

    Update AR::Base.create and AR:Base#update_attributes docs to remove r…

    guilleiguaran authored
    …eferences to mass assignment options
  7. @guilleiguaran
Commits on Sep 18, 2012
  1. @dhh

    Merge pull request #7251 from rails/integrate-strong_parameters

    dhh authored
    Integrate strong_parameters in Rails 4
Commits on Sep 17, 2012
  1. @rafaelfranca

    Merge pull request #7661 from ernie/build-join-records-on-unsaved-hmt

    rafaelfranca authored
    Fix collection= on hm:t join models when unsaved
  2. @ernie

    Fix collection= on hm:t join models when unsaved

    ernie authored
    If assigning to a has_many :through collection against an unsaved
    object using the collection=[<array_of_items>] syntax, the join models
    were not properly created, previously.
  3. @guilleiguaran
  4. @guilleiguaran
  5. @guilleiguaran

    attr_accessible and attr_protected raise an exception pointing to use…

    guilleiguaran authored
    … plugin or new protection model
  6. @guilleiguaran
  7. @guilleiguaran
  8. @rafaelfranca

    Merge pull request #7547 from danmcclain/pg-arrays

    rafaelfranca authored
    Adds migration and type casting support for PostgreSQL Array datatype
  9. @rafaelfranca

    Remove debug code :bomb:

    rafaelfranca authored
  10. @rafaelfranca

    Merge pull request #7651 from steveklabnik/issue_3956

    rafaelfranca authored
    Don't preserve SELECT columns on COUNT
    
    Closes #7651
  11. @steveklabnik @rafaelfranca

    Don't preserve SELECT columns on COUNT

    steveklabnik authored rafaelfranca committed
    The COUNT clause of a finder_sql relationship is being rewritten from
    COUNT(*) to COUNT(table_name.*). This does not appear to be valid syntax
    in MySQL:
    
    ```
    mysql> SELECT COUNT( table_name.* ) FROM `table_name`;
    ERROR 1064 (42000): You have an error in your SQL syntax; check the
    manual that corresponds to your MySQL server version for the right
    syntax to use near '* ) FROM `table_name`' at line 1
    ```
    
    This fixes the bug, as well as adding tests so we don't re-introduce
    it in the future.
    
    Fixes #3956.
Commits on Sep 16, 2012
  1. @kennyj
  2. @toshi-kawanishi
  3. @henrik
Commits on Sep 15, 2012
  1. @kennyj
Something went wrong with that request. Please try again.