Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jul 23, 2012
  1. @spastorino

    Add CHANGELOG entry

    spastorino authored
Commits on Jul 21, 2012
  1. Add back `:disable_with` and change deprecation horizon to 4.1

    Carlos Galdino + Rafael Mendonça França authored
  2. Add back `:confirm` and change deprecation horizon to 4.1

    Carlos Galdino + Rafael Mendonça França authored
Commits on Jul 18, 2012
  1. @carlosgaldino

    Remove `:confirm` in favor of `:data => { :confirm => 'Text' }` option

    carlosgaldino authored
    This applies to the following helpers:
Commits on Jul 8, 2012
  1. @carlosantoniodasilva
Commits on Jul 7, 2012
  1. @schneems
  2. @kennyj

    Added support add_flash_types

    kennyj authored
Commits on Jul 3, 2012
  1. @carlosantoniodasilva

    Update 4.0 Release Notes with changelogs [ci skip]

    carlosantoniodasilva authored
    Also fix some wrong formatting.
    Related discussion:
Commits on Jun 30, 2012
  1. @carlosantoniodasilva
Commits on Jun 15, 2012
  1. @kennyj
Commits on Jun 11, 2012
  1. @spastorino
Commits on Jun 1, 2012
  1. @drogus

    Allow to use mounted helpers in ActionView::TestCase

    drogus authored
    Similarly to 6525002, this allows to use routes helpers for mounted
    helpers, but this time in ActionView::TestCase
  2. @rafaelfranca
  3. @drogus

    Include routes.mounted_helpers into integration tests

    drogus authored
    In integration tests, you might want to use helpers from engines that
    you mounted in your application. It's not hard to add it by yourself,
    but it's unneeded boilerplate. mounted_helpers are now included by
    default. That means that given engine mounted like:
        mount Foo::Engine => "/foo", :as => "foo"
    you will be able to use paths from this engine in tests this way:
        foo.root_path #=> "/foo"
    (closes #6573)
Commits on May 31, 2012
  1. @jeremyf

    Extracted redirect logic from ActionController::Force::ClassMethods.f…

    jeremyf authored
    Prior to this patch the existing .force_ssl method handles both defining
    the filter and handling the logic for performing the redirect.
    With this patch the logic for redirecting to the HTTPS protocol is
    separated from the filter logic that determines if a redirect should
    occur.  By separating the two levels of behavior, an instance method
    for ActionController (i.e. #force_ssl_redirect) is exposed and available
    for more granular SSL enforcement.
    Cleaned up indentation.
Commits on May 30, 2012
  1. @lest

    accept a block in button_to helper

    lest authored
    Make possible to use a block in button_to helper if button text is hard
    to fit into the name parameter, e.g.:
        <%= button_to [:make_happy, @user] do %>
          Make happy <strong><%= %></strong>
        <% end %>
        # => "<form method="post" action="/users/1/make_happy" class="button_to">
        #      <div>
        #        <button type="submit">
        #          Make happy <strong>Name</strong>
        #        </button>
        #      </div>
        #    </form>"
Commits on May 28, 2012
  1. @drogus

    Fix sorting of helpers from different paths

    drogus authored
    When more than one directory for helpers is provided to a controller, it
    should preserver the order of directories. Given 2 paths:
        MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"]
    helpers from dir1 should be loaded first. Before this commit, all
    helpers were mixed and then sorted alphabetically, which essentially
    would require to rename helpers to get desired order.
    This is a problem especially for engines, where you would like to be
    able to predict accurately which engine helpers will load first.
    (closes #6496)
Commits on May 26, 2012
  1. @rafaelfranca

    Add `:escape` option for `truncate`

    rafaelfranca authored
    This options can be used to not escape the result by default.
  2. @rafaelfranca
Commits on May 21, 2012
  1. @carlosgaldino

    Add several HTML5 input helpers

    carlosgaldino authored
    The input types added are:
    - input[type="month"]
    - input[type="week"]
    - input[type="datetime"]
    - input[type="datetime-local"]
  2. @carlosgaldino
Commits on May 20, 2012
  1. @rafaelfranca

    Fix CHANGELOG order and add a brief description of the changes in the

    rafaelfranca authored
    Action Pack in the upgrading guide. [ci skip]
  2. @pixeltrix

    Return 400 Bad Request for URL paths with invalid encoding.

    pixeltrix authored
    Passing path parameters with invalid encoding is likely to trigger errors
    further on like `ArgumentError (invalid byte sequence in UTF-8)`. This will
    result in a 500 error whereas the better error to return is a 400 error which
    allows exception notification libraries to filter it out if they wish.
    Closes #4450
  3. @pixeltrix

    Raise ActionController::BadRequest for malformed parameter hashes.

    pixeltrix authored
    Currently Rack raises a TypeError when it encounters a malformed or
    ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this
    through to the application this commit captures the exception and
    re-raises it using a new ActionController::BadRequest exception.
    The new ActionController::BadRequest exception returns a 400 error
    instead of the 500 error that would've been returned by the original
    TypeError. This allows exception notification libraries to ignore
    these errors if so desired.
    Closes #3051
  4. @dchelimsky

    Raise Assertion instead of RoutingError for routing assertion failures.

    dchelimsky authored
    Before this change, assert_recognizes, assert_generates, and
    assert_routing raised ActionController::RoutingError when they failed to
    recognize the route.
    This commit changes them to raise Assertion instead. This aligns with
    convention for logical failures, and supports reporting tools that care
    about the difference between logical failures and errors e.g. the
    summary at the end of a test run.
    - Fixes #5899
Commits on May 19, 2012
  1. @carlosantoniodasilva

    Clarify grouped_options_for_select method API, add changelog entry

    carlosantoniodasilva authored
    Make the method API more clear by explicitly showing the expected
    arguments. This means that the options cannot be passed as second
    argument because we are not relying on extract_options! anymore,
    you are expected to give a selected key or `nil` if you want to pass
    options, as it is the last argument.
    Notice that this does not change the current method arguments contract
    available in 3.2, it just brings back the same functionality with the
    divider addition.
Commits on May 18, 2012
  1. @soulim
Commits on May 17, 2012
  1. @iHiD
  2. @josevalim
Commits on May 15, 2012
  1. @josevalim

    Revert "Revert "Remove `:disable_with` in favor of `'data-disable-wit…

    josevalim authored
    …h'` option from `submit_tag`, `button_tag` and `button_to` helpers.""
    Finally remove `:disable_with` but use `:data => { :disable_with => ... }`
    in examples to show off a better API (which looks nicer in Ruby 1.9)
    This reverts commit a5c38a9.
  2. @josevalim

    Revert "Remove `:disable_with` in favor of `'data-disable-with'` opti…

    josevalim authored
    …on from `submit_tag`, `button_tag` and `button_to` helpers."
    `disable_with:` is much easier to type than `"data-disable-with" =>`,
    and the fact it uses "data-disable-with" => is an implementation concern,
    it should not affect the public API.
    This reverts commit 683fc4d.
Commits on May 14, 2012
  1. Remove `:disable_with` in favor of `'data-disable-with'` option from …

    Carlos Galdino + Rafael Mendonça França authored
    …`submit_tag`, `button_tag` and `button_to` helpers.
Commits on May 13, 2012
  1. @rafaelfranca
  2. @rafaelfranca

    `:include_blank` should be true if the size option is nil

    Rafael Mendonça França authored rafaelfranca committed
  3. @rafaelfranca

    Merge pull request #6225 from acapilleri/select_with_required_true_in…

    rafaelfranca authored
    HTML5 validation error with options_from_collection_for_select
    Fixes #5908
Something went wrong with that request. Please try again.