Skip to content
Commits on Jul 27, 2012
  1. @yahonda

    Modity the :json_data_empty attribute from `:null => false` to `:null…

    yahonda committed
    … => true`
    
    to address ORA-01400 errors with Oracle enhanced adapter.
    
    The original commit 3c0bf04 requires :json_data_empty attribute
    has empty string OR null, then setting `:default => ""` is enough.
  2. @josevalim

    Merge pull request #6827 from zephyr-dev/master

    josevalim committed
    Validates_presence_of associated object marked for destruction
  3. @jonleighton
  4. @jonleighton

    Deprecate Relation#all.

    jonleighton committed
    It has been moved to active_record_deprecated_finders.
    
    Use #to_a instead.
  5. @jonleighton

    Deprecate ActiveRecord::Base.scoped.

    jonleighton committed
    It doesn't serve much purpose now that ActiveRecord::Base.all returns a
    Relation.
    
    The code is moved to active_record_deprecated_finders.
  6. @jonleighton

    ActiveRecord::Base.all returns a Relation.

    jonleighton committed
    Previously it returned an Array.
    
    If you want an array, call e.g. `Post.to_a` rather than `Post.all`. This
    is more explicit.
    
    In most cases this should not break existing code, since
    Relations use method_missing to delegate unknown methods to #to_a
    anyway.
  7. @rafaelfranca

    Only require the `:rails_env` task where is needed.

    rafaelfranca committed
    `:rails_env` tasks is not needed in all the tasks that depends of
    `load_config`, only in the tasks that uses `Rails.env`.
    
    Since `:rails_env` task set the `Rails.env` to be "development" if it is
    not set we don't need the `||` statements too
    
    Fix #7175.
    
    Conflicts:
    	activerecord/lib/active_record/railties/databases.rake
  8. @yahonda

    Modify the preference attribute from `:null => false` to `:null => true`

    yahonda committed
    to address ORA-01400 errors with Oracle enhanced adapter.
    
    Issue #4856 had been fixed and tested with
    the attribute `:null => false, :default => ""`.
    Now `:null => false` attribute is not necessary to test this issue.
Commits on Jul 26, 2012
  1. @beerlington

    Refactor ActiveRecord::Inheritance.base_class logic

    beerlington committed
    Moved logic from class_of_active_record_descendant(class) to the
    base_class method. This method was confusing because it required
    an argument, but that argument was 'self'.
    
    Moved base_class tests to inheritance_test.rb and added some test
    coverage for some untested cases.
  2. @route

    Missed extend for eager_autoload

    route committed
  3. @jonleighton

    Merge pull request #7166 from ayrton/patch-1

    jonleighton committed
    Update activerecord/CHANGELOG.md
  4. @jonleighton

    Merge pull request #7161 from michaelfairley/eager_load_active_record…

    jonleighton committed
    …_association_helpers
    
    Eager autoload ActiveRecord association helpers
  5. @ayrton

    Update activerecord/CHANGELOG.md

    ayrton committed
    Fixed markdown code indenting
  6. @parndt

    Switched update_column recommendation in changelog to update_columns

    parndt committed
    Related to #7164
    
    Looks like the last one; thanks!
  7. @michaelfairley
Commits on Jul 25, 2012
  1. @tenderlove

    Merge pull request #6654 from stevecj/postgresql-auto-reconnect-2

    tenderlove committed
    Postgresql auto reconnect 2
  2. @yahonda

    Use string datatype for the setting attribute

    yahonda committed
    to make store works all database adapters.
Commits on Jul 24, 2012
  1. @rafaelfranca
  2. @rafaelfranca
  3. @smartinez87 @rafaelfranca
  4. @yahonda

    This pull requests addresses ORA-01400 errors and also supports #6115

    yahonda committed
    …issue tested.
    
    Issue #6115 has been fixed and tested with
    the attribute `:null => false, :default => ""`
    However `:null => false` attribute is not necessary to test this issue,
    which causes many ORA-01400 errors with Oracle enhanced adapter.
Commits on Jul 22, 2012
  1. @kennyj

    Restore connection_id on error.

    kennyj committed
Commits on Jul 21, 2012
  1. @vijaydev
  2. @vijaydev
  3. @vijaydev

    minor copy edits [ci skip]

    vijaydev committed
Commits on Jul 20, 2012
  1. AR has a subclass of AM:PresenceValidator.

    Brent Wheeldon & Nick Monje committed with Ben Moss
    This allows us to mark the parent object as invalid if all associated objects
    in a presence validated association are marked for destruction.
    
    See: #6812
  2. @jonleighton

    rm unnecessary test

    jonleighton committed
    interpolation is no longer a thing separate from "normal" assoc
    conditions.
  3. @jonleighton

    rm redundant test

    jonleighton committed
    now everything is converted to the new style, this is not needed
  4. @jonleighton

    remove unused method

    jonleighton committed
  5. @jonleighton

    we don't need this arg

    jonleighton committed
  6. @jonleighton
  7. @jonleighton

    Remove obsolete line.

    jonleighton committed
    This code is broken (it should say association_scope.uniq_value rather
    than options[:uniq]) but the tests still pass.
    
    I think it is designed to uniq-ify associations using finder_sql.
    However, I am about to remove that anyway.
  8. @jonleighton
  9. @jonleighton

    Avoid options ever being nil

    jonleighton committed
    This fixes active_record_deprecated_finders.
Commits on Jul 19, 2012
  1. @oscardelben

    Fix typos

    oscardelben committed
Something went wrong with that request. Please try again.