Skip to content
Commits on Jul 27, 2012
  1. @jonleighton

    Deprecate Relation#all.

    jonleighton committed
    It has been moved to active_record_deprecated_finders.
    Use #to_a instead.
Commits on Jul 18, 2012
  1. @lexmag
  2. revert Default timestamps to non-null

    Dave Kroondyk committed
    Commit 3dbedd2 added NOT NULL constraints to timestamps.
    Commit fcef728 started to revert this, but was incomplete.
    With this commit, 3dbedd2 should be fully reverted and
    timestamps will no longer default to NOT NULL.
Commits on Jul 17, 2012
  1. @lexmag

    Add join table migration generator

    lexmag committed
    For instance, running
        rails g migration CreateMediaJoinTable artists musics:uniq
    will create a migration with
        create_join_table :artists, :musics do |t|
          # t.index [:artist_id, :music_id]
          t.index [:music_id, :artist_id], unique: true
Commits on Jul 7, 2012
  1. @vijaydev
  2. @carlosantoniodasilva
Commits on Jul 6, 2012
  1. @sidonath
Commits on Jul 5, 2012
  1. fix quoting for ActiveSupport::Duration instances

    Francesco Rodriguez committed
    This patch fixes quoting for ActiveSupport::Duration instances:
        # before
        >> ActiveRecord::Base.connection.quote 30.minutes
        => "'--- 1800\n...\n'"
        # after
        >> ActiveRecord::Base.connection.quote 30.minutes
        => "1800"
    Also, adds a test for type casting ActiveSupport::Duration instances.
    Related to #1119.
Commits on Jul 3, 2012
  1. @rafaelfranca
  2. @lexmag @rafaelfranca
  3. @lexmag @rafaelfranca

    Add references schema statements

    lexmag committed with rafaelfranca
        add_reference :products, :supplier, polymorphic: true, index: true
        remove_reference :products, :user
    `add_belongs_to` and `remove_belongs_to` are
Commits on Jun 30, 2012
  1. fix AR::SchemaStatements#column_exists? example [ci skip]

    Francesco Rodriguez committed
  2. update AR::SchemaStatements#column_exists? documentation [ci skip]

    Francesco Rodriguez committed
  3. @lexmag

    Add more options to column_exists? method

    lexmag committed
    Also fix failures in check options for nil
Commits on Jun 22, 2012
  1. add :nodoc: to internal implementations [ci skip]

    Francesco Rodriguez committed
Commits on Jun 17, 2012
  1. @dylanahsmith
Commits on Jun 15, 2012
  1. @jonleighton

    Simplify AR configuration code.

    jonleighton committed
    Get rid of ActiveModel::Configuration, make better use of
    ActiveSupport::Concern + class_attribute, etc.
Commits on Jun 11, 2012
  1. @rafaelfranca

    Merge pull request #6492 from pmahoney/fair-connection-pool2

    rafaelfranca committed
    Fair connection pool2
Commits on Jun 6, 2012
  1. @amatsuda
Commits on May 31, 2012
  1. @jeremy
Commits on May 29, 2012
  1. @kennyj
Commits on May 25, 2012
  1. @pmahoney

    Make connection pool fair with respect to waiting threads.

    pmahoney committed
    The core of this fix is a threadsafe, fair Queue class.  It is
    very similar to Queue in stdlib except that it supports waiting
    with a timeout.
    The issue this solves is that if several threads are contending for
    database connections, an unfair queue makes is possible that a thread
    will timeout even while other threads successfully acquire and release
    connections.  A fair queue means the thread that has been waiting the
    longest will get the next available connection.
    This includes a few test fixes to avoid test ordering issues that
    cropped up during development of this patch.
Commits on May 23, 2012
  1. @rafaelfranca

    Whitespaces :scissors:

    rafaelfranca committed
  2. @jrochkind

    ConnectionPool wait_timeout no longer used for different types of tim…

    jrochkind committed
    …eouts. #6441
    An AR ConnectionSpec `wait_timeout` is pre-patch used for three
    different things:
    * mysql2 uses it for MySQL's own wait_timeout (how long MySQL
      should allow an idle connection before closing it), and
      defaults to 2592000 seconds.
    * ConnectionPool uses it for "number of seconds to block and
      wait for a connection before giving up and raising a timeout error",
      default 5 seconds.
    * ConnectionPool uses it for the Reaper, for deciding if a 'dead'
      connection can be reaped. Default 5 seconds.
    Previously, if you want to change these from defaults, you need
    to change them all together. This is problematic _especially_
    for the mysql2/ConnectionPool conflict, you will generally _not_
    want them to be the same, as evidenced by their wildly different
    defaults. This has caused real problems for people #6441 #2894
    But as long as we're changing this, forcing renaming the
    ConnectionPool key to be more specific, it made sense
    to seperate the two ConnectionPool uses too -- these two
    types of ConnectionPool timeouts ought to be able to be
    changed independently, you won't neccesarily want them
    to be the same, even though the defaults are (currently)
    the same.
Commits on May 22, 2012
  1. @rafaelfranca

    Revert "Merge pull request #6416 from pmahoney/threadsafe-connection-…

    rafaelfranca committed
    This reverts commit d2901f0, reversing
    changes made to 525839f.
    Reason: This change broke the build (!/rails/rails/builds/1391490)
    and we don't have any solution until now. I asked the author to try to
    fix it and open a new pull request.
Commits on May 21, 2012
  1. @pmahoney
Commits on May 19, 2012
  1. @pmahoney
Commits on May 16, 2012
Commits on May 10, 2012
  1. @vijaydev
Commits on May 9, 2012
  1. @tenderlove

    Merge pull request #5362 from zenprogrammer/quoting_bug

    tenderlove committed
    Fixed bug in ActiveRecord that caused classes to be quoted incorrectly
Commits on May 2, 2012
  1. @ebeigarts

    Refactored remove_column

    ebeigarts committed
Commits on Apr 29, 2012
  1. @mark-rushakoff

    Remove unused assignments

    mark-rushakoff committed
Commits on Apr 27, 2012
  1. @tenderlove

    Merge pull request #5698 from dougcole/support_postgresql_partitioning

    tenderlove committed
    Support postgresql partitioning by making INSERT RETURNING optional
Commits on Apr 17, 2012
  1. @vijaydev
Commits on Apr 16, 2012
  1. @tenderlove
Something went wrong with that request. Please try again.