Skip to content
This repository

Oct 30, 2012

  1. Alexey Gaziev

    Make caller attribute in deprecation methods optional

    gazay authored

Oct 29, 2012

  1. Nikita Afanasenko

    Provide a call stack for deprecation warnings where needed.

    It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
    nikitug authored

Oct 21, 2012

  1. Francesco Rodríguez

    minor edits in AM documentation [ci skip]

    frodsan authored

Aug 04, 2012

  1. Vijay Dev

    Merge branch 'master' of

    vijaydev authored

Aug 03, 2012

  1. Jon Leighton

    Remove ActiveRecord::Base.to_a

    On reflection, it seems like a bit of a weird method to have on
    ActiveRecord::Base, and it shouldn't be needed most of the time anyway.
    jonleighton authored

Aug 02, 2012

  1. Xavier Noria

    load active_support/deprecation in active_support/rails

    fxn authored

Jul 31, 2012

  1. Francesco Rodríguez

    update ActiveModel::Observer documentation [ci skip]

    frodsan authored
  2. Francesco Rodríguez

    add :nodoc: to ActiveModel::Observing#inherited [ci skip]

    frodsan authored
  3. Francesco Rodríguez

    update ActiveModel::Observing documentation [ci skip]

    frodsan authored

Jul 27, 2012

  1. Jon Leighton

    ActiveRecord::Base.all returns a Relation.

    Previously it returned an Array.
    If you want an array, call e.g. `Post.to_a` rather than `Post.all`. This
    is more explicit.
    In most cases this should not break existing code, since
    Relations use method_missing to delegate unknown methods to #to_a

Jul 03, 2012

  1. Angelo Capilleri

    observer update refactoring

    acapilleri authored

May 01, 2012

  1. Marc-André Lafortune

    notify_observers should be public

    marcandre authored

Apr 30, 2012

  1. Aaron Patterson

    Merge pull request #6063 from marcandre/observer_extra_args

    Allow extra arguments for Observers
    tenderlove authored
  2. Marc-André Lafortune

    Allow extra arguments for Observers

    marcandre authored
  3. Jeremy Kemper

    Merge pull request #6071 from marcandre/observer_redef

    Fix Observer by acting on singleton class. Fixes #3505.
    jeremy authored
  4. Marc-André Lafortune

    Fix Observer by acting on singleton class [#3505]

    Also [issue #1034] [pull #6068]
    marcandre authored

Apr 29, 2012

  1. Marc-André Lafortune

    Generate appropriate error more judiciously

    marcandre authored
  2. Marc-André Lafortune

    Fix error message:

    - can pass the class, not the instance
    - "instance method" is confusing, use "method :instance" instead
    marcandre authored

Apr 25, 2012

  1. Oscar Del Ben

    Refactor Observer.observed_class

    oscardelben authored
  2. José Valim

    Merge pull request #5841 from oscardelben/rename_count_observers

    Rename Observing#count_observers to Observing#observers_count
    josevalim authored

Apr 18, 2012

  1. Oscar Del Ben

    Improve observers documentation

    oscardelben authored

Apr 14, 2012

  1. Oscar Del Ben

    Rename notify_observers argument *arg to *args to make it more clear

    that the method accepts multiple arguments
    oscardelben authored
  2. Oscar Del Ben

    Rename Observing#count_observers to Observing#observers_count

    oscardelben authored

Jan 24, 2012

  1. Manoj

    quote fix ` to ' in the ArgumentError message

    message quote fix
    railsaholic authored

Jan 06, 2012

  1. Rafael Mendonça França

    Remove Array.wrap call in ActiveModel

    rafaelfranca authored

Nov 07, 2011

  1. Anand

    replaced remove and define method calls to :redefine

    luckydev authored

Aug 13, 2011

  1. Myron Marston

    Allow ActiveRecord observers to be disabled.

    We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
    myronmarston authored

May 21, 2011

  1. Ganesh Kumar

    ActionMailer deliver method Documentation corrected Ticket #761

May 19, 2011

  1. Guillermo Iguaran

    Prefer each instead of for in

May 06, 2011

  1. Myron Marston

    Add documentation for new observer enable/disable feature.

Apr 30, 2011

  1. Sebastian Martinez

    Improved ActiveModel Observing docs.

    smartinez87 authored

Apr 28, 2011

  1. Myron Marston

    Fix bug with AM::Observer disablement.

    Now that we propagate the enabling/disabling to descendants, we no longer have to check the disabled_observer Set on each superclass of the model class.  This was causing a bug when disabling all observers at a superclass level and then enabling an individual observer at a subclass level.
    Plus the logic is simpler now :).
    myronmarston authored
  2. Myron Marston

    Fix dev env memory leaks by using AS::DescendantsTracker rather than …

    …keeping track of subclasses manually.
    There's also no need to keep track of all ObserverArray instances in a hash, as this is likely to leak memory, too.
    myronmarston authored
  3. Myron Marston

    Revert "Revert "Handle enabling/disabling observers at different leve…

    …ls of the class hierarchy.""
    This reverts commit 2a25c58.
    I'm going to add another commit that keeps the same behavior of fixes
    the problems of leaking memory in development.
    myronmarston authored
  4. José Valim

    Revert "Handle enabling/disabling observers at different levels of th…

    …e class hierarchy."
    This reverts commit ad62f19 because the current
    subclasses implementation leaks memory in development.
    Instead of keeping an array of subclasses, the better solution is to
    ask the parent if an observer is being disabled or not.
    josevalim authored
Something went wrong with that request. Please try again.