Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 28, 2012
  1. @purcell

    Don't enable validations when passing false hash values to ActiveMode…

    purcell authored
    …l.validates
    
    Passing a falsey option value for a validator currently causes that validator to
    be enabled, just like "true":
    
        ActiveModel.validates :foo, :presence => false
    
    This is rather counterintuitive, and makes it inconvenient to wrap `validates` in
    methods which may conditionally enable different validators.
    
    As an example, one is currently forced to write:
    
          def has_slug(source_field, options={:unique => true})
            slugger = Proc.new { |r| r[:slug] = self.class.sluggify(r[source_field]) if r[:slug].blank? }
            before_validation slugger
            validations = { :presence => true, :slug => true }
            if options[:unique]
              validations[:uniqueness] = true
            end
            validates :slug, validations
          end
    
    because the following reasonable-looking alternative fails to work as expected:
    
          def has_slug(source_field, options={:unique => true})
            slugger = Proc.new { |r| r[:slug] = self.class.sluggify(r[source_field]) if r[:slug].blank? }
            before_validation slugger
            validates :slug, :presence => true, :slug => true, :uniqueness => options[:unique]
          end
    
    (This commit includes a test, and all activemodel and activerecord tests pass as before.)
Commits on Apr 24, 2012
  1. @bcardarella

    Reordered changelog entry

    bcardarella authored
  2. @bcardarella

    Updated CHANGELOG

    bcardarella authored
Commits on Mar 9, 2012
  1. @rafaelfranca

    Fix my name in the CHANGELOG to follow the convention

    rafaelfranca authored
    Also add missing entries and use the formating convention
Commits on Mar 8, 2012
  1. @vijaydev
Commits on Mar 3, 2012
  1. @guilleiguaran
Commits on Mar 1, 2012
  1. @claudiob

    Add release dates to documentation

    claudiob authored
    Set "March 1, 2012" as the release date for 3.2.2, 3.1.4, 3.0.12
Commits on Feb 25, 2012
  1. @pacoguzman

    Update changelogs with rails 3.0-stable branch info

    pacoguzman authored pacoguzman committed
Commits on Feb 20, 2012
  1. @bogdan
Commits on Feb 7, 2012
  1. @josevalim
Commits on Jan 26, 2012
  1. @claudiob
Commits on Nov 30, 2011
  1. @josevalim

    Revert "Implement ArraySerializer and move old serialization API to a…

    josevalim authored
    … new namespace."
    
    This reverts commit 8896b4f.
    
    Conflicts:
    
    	activemodel/lib/active_model.rb
    	activemodel/lib/active_model/serializable.rb
    	activemodel/lib/active_model/serializer.rb
    	activemodel/test/cases/serializer_test.rb
Commits on Nov 29, 2011
  1. @jonleighton

    Deprecated `define_attr_method` in `ActiveModel::AttributeMethods`

    jonleighton authored
    This only existed to support methods like `set_table_name` in Active
    Record, which are themselves being deprecated.
Commits on Nov 25, 2011
  1. @josevalim
  2. @josevalim
Commits on Nov 4, 2011
  1. @jonleighton

    Convert CHANGELOGs to Markdown format.

    jonleighton authored
    Reasons:
    
     * Markdown reads well as plain text, but can also be formatted.
     * It will make it easier for people to read on the web as Github
       formats the Markdown nicely.
     * It will encourage a level of consistency when people are writing
       CHANGELOG entries.
    
    The script used to perform the conversion is at
    https://gist.github.com/1339263
Something went wrong with that request. Please try again.