Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 12, 2012
  1. @josh
  2. @arunagw
  3. @dfens

    Cleanup trailing whitespaces

    dfens authored
  4. @frodsan

    update AC::Parameters#permit documentation [ci skip]

    frodsan authored
    bdd105d changes the behaviour of AC::Parameters#permit.
  5. @spastorino

    When executing permit with just a key that points to a hash, DO NOT a…

    spastorino authored
    …llow all the hash
    
    params.require(:person).permit(:projects_attributes) was returning
    => {"projects_attributes"=>{"0"=>{"name"=>"Project 1"}}}
    
    When should return
    => {}
    
    You should be doing ...
    params.require(:person).permit(projects_attributes: :name)
    to get just the projects attributes you want to allow
Commits on Oct 11, 2012
  1. @mrship
  2. @senny

    refactor `ActionView::TestCase` internals to track rendered locals

    senny authored senny committed
    this refactoring extracts the semi complex data structure of rendered locals
    per view into into a separate class
  3. @senny

    recognizes when a partial was rendered twice. Closes #3675

    senny authored senny committed
Commits on Oct 10, 2012
  1. @vijaydev

    Merge pull request #7890 from AvnerCohen/new_hash_syntax

    vijaydev authored
    Moving to new hash syntax
  2. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	activerecord/lib/active_record/persistence.rb
    	railties/lib/rails/generators/rails/resource_route/resource_route_generator.rb
  3. @dhh
  4. @josh

    Remove expansion config

    josh authored
  5. @josh

    Remove old asset tag concatenation

    josh authored
    Use sprockets, jammit, or some other asset bundler
Commits on Oct 9, 2012
  1. @AvnerCohen
Commits on Oct 8, 2012
  1. @AvnerCohen

    Closed unclosed <tt>, working on a complete solution for docrails, bu…

    AvnerCohen authored
    …t testing push process first
Commits on Oct 7, 2012
  1. @alexeymuranov

    Rename "Fixtures" class to "FixtureSet"

    alexeymuranov authored
    Rename `ActiveRecord::Fixtures` class to `ActiveRecord::FixtureSet`.  Instances of this class normally hold a collection of fixtures (records) loaded either from a single YAML file, or from a file and a folder with the same name.  This change make the class name singular and makes the class easier to distinguish from the modules like `ActiveRecord::TestFixtures`, which operates on multiple fixture sets, or `DelegatingFixtures`, `::Fixtures`, etc., and from the class `ActiveRecord::Fixture`, which corresponds to a single fixture.
  2. @jeremy

    Ruby 2 compat. CGI.escapeHTML has changed the way it escapes apostrop…

    jeremy authored
    …hes a few times, so fix up the test to work with however it chooses to escape.
  3. @rafaelfranca

    Fix nodoc comment

    rafaelfranca authored
  4. @rafaelfranca
  5. @rafaelfranca

    We don't need to check blank? here.

    rafaelfranca authored
    Also the blank? check introduced a bug.
    
    $ rails generate model Foo blank:boolean
    
    form_for(Foo.new(:blank => true)) => ArgumentError, "First argument in form cannot contain nil or be empty"
  6. @rafaelfranca

    Update some code styles.

    rafaelfranca authored
    * Uses the Ruby 1.9 hash syntax
    * Avoid escaping " inside string using the %{} syntax
Commits on Oct 6, 2012
  1. @teleological

    Accept :remote as symbol in link_to options

    teleological authored
    Accept either :remote or 'remote' in both the html_options and
    (url_)options hash arguments to link_to.
  2. @senny

    can't pass :locals to #assert_template without a view test case. Closes

    senny authored
    #3415
    
    the documentation on #assert_template states that the :locals option is
    only available in view test cases:
    
        # In a view test case, you can also assert that specific locals are passed
        # to partials:
    
    I added a warning when it's passed in an inapropriate context to prevent
    a NoMethodError.
  3. @rafaelfranca
Commits on Oct 5, 2012
  1. @rafaelfranca

    Allow parameter filters to match multi-parameter attributes

    rafaelfranca authored
    This will make easier to permit date/time attributes generated by
    helpers like date_select.
    
    [Sven Schwyn + Rafael Mendonça França]
  2. @spastorino

    Revert "Use flat_map { } instead of map {}.flatten"

    spastorino authored
    This reverts commit abf8de8.
    We should take a deeper look to those cases flat_map doesn't do deep
    flattening.
    
    irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten
    => [1, 3, 1, 2]
    irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i}
    => [[1, 3], [1, 2]]
  3. @spastorino
  4. @guilleiguaran
  5. @guilleiguaran
Commits on Oct 4, 2012
  1. @rafaelfranca

    Remove unneeded CHANGELOG entry.

    rafaelfranca authored
    This was added in Rails 4 and we don't need changelog entries to
    behavior changes
    
    [ci skip]
  2. @dhh

    Merge pull request #7847 from bloudermilk/recursive_permit

    dhh authored
    ActionController::Parameters#permit! is recursive
  3. @bloudermilk
  4. @rafaelfranca

    Do not set removed option

    rafaelfranca authored
    Sine page caching was remove from the core we don't have the
    page_cache_directory anymore
  5. @rafaelfranca

    Merge pull request #7833 from frodsan/extract_ap_pages_actions_caching

    rafaelfranca authored
    Extract AP Page and Action caching from Rails
  6. @frodsan
Something went wrong with that request. Please try again.