Skip to content
Commits on May 1, 2012
  1. @marcandre
Commits on Apr 30, 2012
  1. @tenderlove

    Merge pull request #6063 from marcandre/observer_extra_args

    tenderlove committed
    Allow extra arguments for Observers
  2. @marcandre
  3. @jeremy

    Merge pull request #6071 from marcandre/observer_redef

    jeremy committed
    Fix Observer by acting on singleton class. Fixes #3505.
  4. @marcandre

    Fix Observer by acting on singleton class [#3505]

    marcandre committed
    Also [issue #1034] [pull #6068]
Commits on Apr 29, 2012
  1. @marcandre
  2. @marcandre

    Fix error message:

    marcandre committed
    - can pass the class, not the instance
    - "instance method" is confusing, use "method :instance" instead
Commits on Apr 25, 2012
  1. @oscardelben
  2. @josevalim

    Merge pull request #5841 from oscardelben/rename_count_observers

    josevalim committed
    Rename Observing#count_observers to Observing#observers_count
Commits on Apr 18, 2012
  1. @oscardelben
Commits on Apr 14, 2012
  1. @oscardelben

    Rename notify_observers argument *arg to *args to make it more clear

    oscardelben committed
    that the method accepts multiple arguments
  2. @oscardelben
Commits on Jan 24, 2012
  1. @hindenbug

    quote fix ` to ' in the ArgumentError message

    hindenbug committed
    message quote fix
Commits on Jan 6, 2012
  1. @rafaelfranca
Commits on Nov 7, 2011
  1. @luckydev
Commits on Aug 13, 2011
  1. @myronmarston

    Allow ActiveRecord observers to be disabled.

    myronmarston committed
    We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
Commits on May 21, 2011
  1. @ganeshkumar
Commits on May 19, 2011
  1. @guilleiguaran
Commits on May 6, 2011
  1. @myronmarston
Commits on Apr 30, 2011
  1. @smartinez87
Commits on Apr 28, 2011
  1. @myronmarston

    Fix bug with AM::Observer disablement.

    myronmarston committed
    Now that we propagate the enabling/disabling to descendants, we no longer have to check the disabled_observer Set on each superclass of the model class.  This was causing a bug when disabling all observers at a superclass level and then enabling an individual observer at a subclass level.
    
    Plus the logic is simpler now :).
  2. @myronmarston

    Fix dev env memory leaks by using AS::DescendantsTracker rather than …

    myronmarston committed
    …keeping track of subclasses manually.
    
    There's also no need to keep track of all ObserverArray instances in a hash, as this is likely to leak memory, too.
  3. @myronmarston

    Revert "Revert "Handle enabling/disabling observers at different leve…

    myronmarston committed
    …ls of the class hierarchy.""
    
    This reverts commit 2a25c58.
    
    I'm going to add another commit that keeps the same behavior of fixes
    the problems of leaking memory in development.
  4. @josevalim

    Revert "Handle enabling/disabling observers at different levels of th…

    josevalim committed
    …e class hierarchy."
    
    This reverts commit ad62f19 because the current
    subclasses implementation leaks memory in development.
    
    Instead of keeping an array of subclasses, the better solution is to
    ask the parent if an observer is being disabled or not.
  5. @myronmarston @dhh

    Handle enabling/disabling observers at different levels of the class …

    myronmarston committed with dhh
    …hierarchy.
    
    Last call wins.
  6. @myronmarston @dhh

    Allow observers to be enabled and disabled.

    myronmarston committed with dhh
    This is useful in situations like model unit tests and the occasional rake task to backfill old data.
  7. @myronmarston @dhh
Commits on Apr 22, 2011
  1. @joshk
Commits on Mar 6, 2011
  1. remove unused assigned variable

    Paco Guzman committed
Commits on Feb 21, 2011
  1. @fxn

    copy-edits 6d7a826

    fxn committed
  2. @nixterrimus
Commits on Feb 16, 2011
  1. @jimmycuadra

    add note about observer config for rails apps

    jimmycuadra committed
    ActiveModel::Observer and ActiveRecord::Observer have similar
    documentation, but a Rails user looking at the ActiveModel version
    might not realize that a change to config/application.rb is
    required to activate the observer. This change adds a note to
    that effect, pointing to the AR version from the AM version.
Commits on Jan 15, 2011
  1. @brainopia
Commits on Sep 1, 2010
  1. @subbarao @josevalim

    reader method eliminates defined? checks

    subbarao committed with josevalim
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Aug 26, 2010
  1. @jaimeiniesta @fxn
Something went wrong with that request. Please try again.