Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Apr 12, 2012
  1. @kennyj
  2. @kennyj

    Some refactor for association.

    kennyj authored
    * Remove unused association_class method.
    * Remove a unnecessary assignment.
    * Move @updated to BelongsToAssociation that only reference this instance variable.
    * Reset @stale_state at the reset method. I think this place is right place.
Commits on Apr 3, 2012
  1. @kennyj
Commits on Mar 13, 2012
  1. @carlosantoniodasilva
Commits on Mar 5, 2012
  1. @byroot @tenderlove

    Fix #5069 - Protect foreign key from mass assignment throught associa…

    byroot authored tenderlove committed
    …tion builder
Commits on Mar 4, 2012
  1. @carlosantoniodasilva

    Initialize @stale_state to nil in association

    carlosantoniodasilva authored
    This apparently fix the warning related to @new_record variable not
    being initialized in AR's test suit, when an association is built and
    the object is marshalled/loaded.
    See these tests in AR's base_test.rb:
    Closes #3720.
Commits on Dec 21, 2011
  1. @qoobaa

    added failing tests for has_many, has_one and belongs_to associations…

    qoobaa authored
    … with strict mass assignment sanitizer, fixed build_record to not merge creation_attributes, removed failing nested attributes tests (that feature was broken anyway) #4051
Commits on Dec 15, 2011
  1. @akaspick

    Allow nested attributes in associations to update values in it's owne…

    akaspick authored
    …r object. Fixes a regression from 3.0.x
Commits on Aug 15, 2011
  1. @jonleighton

    Fix private methods which are delegated to. This previously worked be…

    jonleighton authored
    …cause Module#delegate previously ignored method visibility.
Commits on Jul 7, 2011
  1. @jonleighton

    Don't construct association scope in initializer. This yields a big p…

    jonleighton authored
    …erformance gain for cases where the association is never used to load the target, for example with preloading. Related: #1873.
Commits on Jun 30, 2011
  1. @jonleighton

    Assign the association attributes to the associated record before the…

    jonleighton authored
    … before_initialize callback of the record runs. Fixes #1842.
Commits on Jun 7, 2011
  1. @jonleighton

    Allow polymorphic has_one to work when the association is set before …

    jonleighton authored
    …the owner has been saved. Fixes #1524.
  2. @jonleighton

    When you add a record to a polymorphic has_one, you should be able to…

    jonleighton authored
    … access the owner from the associated record
Commits on Apr 13, 2011
  1. @sikachu @dhh

    Remove `#among?` from Active Support

    sikachu authored dhh committed
    After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.
    It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
Commits on Apr 11, 2011
  1. @dhh
Commits on Apr 10, 2011
  1. @sikachu @dhh

    Using Object#in? and Object#either? in various places

    sikachu authored dhh committed
    There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
Commits on Mar 10, 2011
  1. @jonleighton

    Move the code which builds a scope for through associations into a ge…

    jonleighton authored
    …neric AssociationScope class which is capable of building a scope for any association.
Commits on Mar 5, 2011
  1. @rtlechow @fxn

    Active Record typos.

    rtlechow authored fxn committed
Commits on Mar 4, 2011
  1. @jonleighton @tenderlove

    Fix a couple of tests in join_model_test.rb which were failing when t…

    jonleighton authored tenderlove committed
    …he identity map is turned off
Commits on Feb 21, 2011
  1. @jonleighton @tenderlove

    Rename target_klass to klass

    jonleighton authored tenderlove committed
  2. @jonleighton @tenderlove

    Delegate Association#options to the reflection, and replace 'reflecti…

    jonleighton authored tenderlove committed
    …on.options' with 'options'. Also add through_options and source_options methods for through associations.
  3. @jonleighton @tenderlove

    Associations - where possible, call attributes methods rather than di…

    jonleighton authored tenderlove committed
    …rectly accessing the instance variables
Commits on Feb 18, 2011
  1. @miloops
  2. @miloops
  3. @miloops

    Merge remote branch 'rails/master' into identity_map

    miloops authored
  4. @jonleighton

    Split AssociationProxy into an Association class (and subclasses) whi…

    jonleighton authored
    …ch manages the association, and a CollectionProxy class which is *only* a proxy. Singular associations no longer have a proxy. See CHANGELOG for more.
Something went wrong with that request. Please try again.