Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 29, 2012
  1. @josevalim

    Merge pull request #6525 from freerange/minitest-passthrough-exceptions

    josevalim authored
    Exceptions like Interrupt & NoMemoryError should not be rescued in tests.
  2. @floehopper
  3. @amutz
  4. @carlosantoniodasilva

    Review requires from number helper

    carlosantoniodasilva authored
    Some of these requires are now only necessary in
    ActiveSupport::NumberHelper. Add hash/keys require due to symbolize_keys
    usage in number helpers. Also remove some whitespaces.
    
    Closes #6414
Commits on May 28, 2012
  1. @floehopper

    Exceptions like Interrupt should not be rescued.

    floehopper authored
    Neither Test::Unit nor MiniTest rescue exceptions like Interrupt or
    NoMemoryError, but ActiveSupport::Testing::SetupAndTeardown#run which
    overrides MiniTest::Unit::TestCase#run rescues them.
    
    Rescuing an Interrupt exception is annoying, because it means when you
    are running a lot of tests e.g. when running one of the rake test tasks,
    you cannot break out using ctrl-C.
    
    Rescuing exceptions like NoMemoryError is foolish, because the most
    sensible thing to happen is for the process to terminate as soon as
    possible.
    
    This solution probably needs some finessing e.g. I'm not clear whether
    the assumption is that only MiniTest is supported. Also early versions
    of MiniTest did not have this behaviour. However, hopefully it's a
    start.
    
    Integrating with Test::Unit & MiniTest has always been a pain. It would
    be great if both of them provided sensible extension points for the kind
    of things that both Rails and Mocha want to do.
  2. @lest

    make AS::Multibyte::Chars work w/o multibyte core ext

    lest authored
    Use ActiveSupport::Multibyte::Chars.new instead of String#mb_chars.
    It allows to use ActiveSupport::Multibyte::Chars without requiring
    String multibyte core extension.
  3. @lest

    remove unnecessary require

    lest authored
    AS::Multibyte are no longer required by access and filters string
    core extensions.
  4. @jaredbeck
  5. @amutz
Commits on May 27, 2012
  1. @vijaydev
  2. @frodsan
  3. @frodsan
  4. @frodsan
Commits on May 26, 2012
  1. @rafaelfranca
  2. @vijaydev
Commits on May 25, 2012
  1. @markmcspadden
  2. @avakhov
  3. @avakhov

    Fix Range#sum optimized version

    avakhov authored
    At 1bd4d1c was added Range#sum
    optimized version for arithmetic progressions. This improvment injected
    a defect with not integer range boundaries. The defect was fixed by
    e0adfa8. The second commit really
    disabled optimization at all because in Ruby integer-valued numbers are
    instances of Fixnum and Bignum classes. We should #use is_a?
    (#kind_of?) method instead #instance_of? to check if value is numerical:
    
        1.class                 # => Fixnum
        1.instance_of?(Integer) # => false
        1.is_a?(Integer)        # => true
    
        -100_000_000_000.class                 # => Bignum
        -100_000_000_000.instance_of?(Integer) # => false
        -100_000_000_000.is_a?(Integer)        # => true
    
    Moreover original implementation of Range#sum has a defect with reverse
    range boundaries. If the first boundary is less than the second range is
    empty. Current commit fixes and tests this case too.
  4. @avakhov

    Clean Date#beginning_of_month description

    avakhov authored
    Unnecessary peace of text was injected at
    507da04 by mistake.
  5. @avakhov

    Update examples of Array #in_groups and #in_groups_of

    avakhov authored
    Examples should be not square to visually underline a difference between
    Array#in_groups and Array#in_groups_of.
  6. @avakhov
Commits on May 24, 2012
  1. @carlosantoniodasilva
Commits on May 23, 2012
  1. @markmcspadden

    Add Hash#deep_transform_keys and Hash#deep_transform_keys! Also conve…

    markmcspadden authored
    …rt deep_*_keys to use deep_transform_keys.
  2. @lucashungaro
  3. @markmcspadden
  4. @acapilleri

    changed xml type datetime to dateTime, fixes #6328

    acapilleri authored
    XmlMini define the xml 'datatime', but according to
    http://www.w3.org/TR/xmlschema-2/#dateTime could be better
    change this to 'dateTime' with upper case letter 'T.
    So 'DateTime' and 'Time' are redefined from 'datetime' to 'dateTime'
    
    add the changing to the changelog
Commits on May 22, 2012
  1. @spastorino

    Fix the build

    spastorino authored
  2. @spastorino
  3. @janx
  4. @janx

    remove useless require

    janx authored
  5. @NZKoz

    Merge pull request #5125 from winston/log_exception_when_cache_read_f…

    NZKoz authored
    …ails
    
    #read_entry in ActiveSupport::Cache::FileStore should log details of the exception when an exception is thrown
Commits on May 21, 2012
  1. @avakhov
Commits on May 20, 2012
  1. @drogus
Commits on May 19, 2012
  1. @kennyj
  2. @pixeltrix
Something went wrong with that request. Please try again.