Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jan 5, 2014
  1. @pixeltrix

    Use a custom route vistor for optimized route generation

    pixeltrix authored
    Using a Regexp to replace dynamic segments in a path string is fraught
    with difficulty and can lead to odd edge cases like #13349. Since we
    already have a parsed representation of the path it makes sense to use
    that to generate an array of segments that can be used to build an
    optimized route's path quickly.
    
    Tests on a simple route (e.g. /posts/:id) show a speedup of 35%:
    https://gist.github.com/pixeltrix/8261932
    
    Calculating -------------------------------------
        Current Helper:       5274 i/100ms
        New Helper:           8050 i/100ms
    -------------------------------------------------
        Current Helper:     79263.6 (±3.7%) i/s -     395550 in   4.997252s
        New Helper:        153464.5 (±4.9%) i/s -     772800 in   5.047834s
    
    Tests on a more complex route show even an greater performance boost:
    https://gist.github.com/pixeltrix/8261957
    
    Calculating -------------------------------------
        Current Helper:       2367 i/100ms
        New Helper:           5382 i/100ms
    -------------------------------------------------
        Current Helper:     29506.0 (±3.2%) i/s -     149121 in   5.059294s
        New Helper:         78815.5 (±4.1%) i/s -     398268 in   5.062161s
    
    It also has the added benefit of fixing the edge cases described above.
    
    Fixes #13349
Commits on Sep 28, 2013
  1. @thedarkone
Commits on Sep 24, 2013
  1. @rafaelfranca

    No need the else clause

    rafaelfranca authored
  2. @rafaelfranca

    Use join to concat the both side of the AST

    rafaelfranca authored
    Onf of the sides can be nil and it will raise a Conversion error
Commits on Aug 28, 2013
  1. @bogdan
Commits on Jun 30, 2013
  1. @charliesome
Commits on Mar 3, 2013
  1. @pixeltrix

    Use custom visitor class for optimized url helpers

    pixeltrix authored
    Rather than trying to use gsub to remove the optional route segments,
    which will fail with nested optional segments, use a custom visitor
    class that returns a empty string for group nodes.
    
    Closes #9524
Commits on Dec 20, 2012
  1. update AD::Journey to follow Rails coding conventions

    Francesco Rodriguez authored
  2. :nodoc: Journey because is not part of the public API [ci skip]

    Francesco Rodriguez authored
Commits on Dec 19, 2012
  1. @pixeltrix

    Integrate Journey into Action Dispatch

    pixeltrix authored
    Move the Journey code underneath the ActionDispatch namespace so
    that we don't pollute the global namespace with names that may
    be used for models.
    
    Fixes rails/journey#49.
Something went wrong with that request. Please try again.