Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Oct 7, 2012
  1. @rafaelfranca
  2. @rafaelfranca

    We don't need to check blank? here.

    rafaelfranca authored
    Also the blank? check introduced a bug.
    $ rails generate model Foo blank:boolean
    form_for( => true)) => ArgumentError, "First argument in form cannot contain nil or be empty"
  3. @rafaelfranca

    Update some code styles.

    rafaelfranca authored
    * Uses the Ruby 1.9 hash syntax
    * Avoid escaping " inside string using the %{} syntax
Commits on Oct 6, 2012
  1. @teleological

    Accept :remote as symbol in link_to options

    teleological authored
    Accept either :remote or 'remote' in both the html_options and
    (url_)options hash arguments to link_to.
  2. @senny

    can't pass :locals to #assert_template without a view test case. Closes

    senny authored
    the documentation on #assert_template states that the :locals option is
    only available in view test cases:
        # In a view test case, you can also assert that specific locals are passed
        # to partials:
    I added a warning when it's passed in an inapropriate context to prevent
    a NoMethodError.
  3. @rafaelfranca
Commits on Oct 5, 2012
  1. @rafaelfranca

    Allow parameter filters to match multi-parameter attributes

    rafaelfranca authored
    This will make easier to permit date/time attributes generated by
    helpers like date_select.
    [Sven Schwyn + Rafael Mendonça França]
  2. @spastorino

    Revert "Use flat_map { } instead of map {}.flatten"

    spastorino authored
    This reverts commit abf8de8.
    We should take a deeper look to those cases flat_map doesn't do deep
    irb(main):002:0> [[[1,3], [1,2]]].map{|i| i}.flatten
    => [1, 3, 1, 2]
    irb(main):003:0> [[[1,3], [1,2]]].flat_map{|i| i}
    => [[1, 3], [1, 2]]
  3. @spastorino
  4. @guilleiguaran
  5. @guilleiguaran
Commits on Oct 4, 2012
  1. @rafaelfranca

    Remove unneeded CHANGELOG entry.

    rafaelfranca authored
    This was added in Rails 4 and we don't need changelog entries to
    behavior changes
    [ci skip]
  2. @dhh

    Merge pull request #7847 from bloudermilk/recursive_permit

    dhh authored
    ActionController::Parameters#permit! is recursive
  3. @bloudermilk
  4. @rafaelfranca

    Do not set removed option

    rafaelfranca authored
    Sine page caching was remove from the core we don't have the
    page_cache_directory anymore
  5. @rafaelfranca

    Merge pull request #7833 from frodsan/extract_ap_pages_actions_caching

    rafaelfranca authored
    Extract AP Page and Action caching from Rails
  6. @rgarver
Commits on Oct 3, 2012
  1. rename page_cache_extension option to default_static_extension

    Francesco Rodriguez authored
Commits on Oct 2, 2012
  1. @rgarver
  2. @steveklabnik

    Failsafe exception returns text/plain.

    steveklabnik authored
    It's best to just return text/plain when something has gone terribly
    Fixes #5660.
  3. @rafaelfranca

    Merge pull request #7708 from bdurand/optimize_log_subscribers

    rafaelfranca authored
    Optimize log subscribers to check if the log level is sufficient
  4. @spastorino
  5. @spastorino

    Merge pull request #7794 from guilleiguaran/extract-rack-cache

    spastorino authored
    Use Rack::Cache middleware only if is in Gemfile
  6. @guilleiguaran
Commits on Oct 1, 2012
  1. @senny

    prefix TemplateAssertions ivars (#7459)

    senny authored senny committed
  2. @senny

    resource and resources do no longer modify passed options

    senny authored senny committed
    this is a patch for #7777.
  3. @steveklabnik

    fix cache store test

    steveklabnik authored
    Pull #7800 broke the build, this should fix it.
Commits on Sep 30, 2012
  1. @jeremy

    Add a changelog entry for asset aliasing update in sprockets-rails. S…

    jeremy authored
    …upports referencing foo.js as foo/index.js and vice versa.
  2. @bdurand

    Optimize log subscribers to check if the log level is sufficient befo…

    bdurand authored
    …re performing an operations.
  3. @guilleiguaran
  4. @rafaelfranca

    Whitespaces :scissors: [ci skip]

    rafaelfranca authored
  5. @HugoLnx

    `assert_template` no more passing with what ever string that matches.

    HugoLnx authored
    Given Im rendering an template `/layout/hello.html.erb`, assert_template was
    passing with any string that matches. This behavior allowed false passing like:
    	assert_template "layout"
    	assert_template "out/hello"
    Now the passing possibilities are:
    	assert_template "layout/hello"
    	assert_template "hello"
    fixing assert_template bug when template matches expected, but not ends with
    Cherry Pick Merge: Fixes issue #3849 assert_template false positive
    taking redundant test off
    prevening incorrect assert_template when rendering with repeated names in path
    updating CHANGELOG with bugfix: assert_template false passing
Commits on Sep 28, 2012
  1. @vijaydev

    Merge branch 'master' of

    vijaydev authored
Something went wrong with that request. Please try again.