Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Aug 29, 2012
  1. @pixeltrix

    Merge pull request #7230 from schneems/schneems/expose_required_keys

    pixeltrix committed
    Add Missing Keys from Journey on Failed URL Format
Commits on Aug 4, 2012
  1. @pixeltrix

    Revert "Refactor passing url options via array for polymorphic_url"

    pixeltrix committed
    Passing options as the last value in an array doesn't work with form_for.
    This reverts commit 6be564c.
  2. @pixeltrix

    Refactor passing url options via array for polymorphic_url

    pixeltrix committed
    Rather than keep the url options in record_or_hash_or_array, extract it
    and reverse merge with options as it may contain important private keys
    like `:routing_type`.
    Closes #7259
Commits on May 20, 2012
  1. @pixeltrix

    Return 400 Bad Request for URL paths with invalid encoding.

    pixeltrix committed
    Passing path parameters with invalid encoding is likely to trigger errors
    further on like `ArgumentError (invalid byte sequence in UTF-8)`. This will
    result in a 500 error whereas the better error to return is a 400 error which
    allows exception notification libraries to filter it out if they wish.
    Closes #4450
  2. @pixeltrix

    Raise ActionController::BadRequest for malformed parameter hashes.

    pixeltrix committed
    Currently Rack raises a TypeError when it encounters a malformed or
    ambiguous hash like `foo[]=bar&foo[4]=bar`. Rather than pass this
    through to the application this commit captures the exception and
    re-raises it using a new ActionController::BadRequest exception.
    The new ActionController::BadRequest exception returns a 400 error
    instead of the 500 error that would've been returned by the original
    TypeError. This allows exception notification libraries to ignore
    these errors if so desired.
    Closes #3051
Commits on May 11, 2012
  1. @pixeltrix
Commits on Apr 28, 2012
  1. @pixeltrix

    Merge session arg with existing session instead of overwriting

    pixeltrix committed
    This may break existing tests that are asserting the whole session contents
    but should not break existing tests that are asserting individual keys - e.g:
    class SomeControllerTest < ActionController::TestCase
      setup do
        session['user_id'] = 1
      test "some test" do
        get :some_action, nil, { 'another_var' => 2 }
        # This assertion will now fail
        assert_equal({ 'another_var' => 2 }, session)
        # This assertion will still pass
        assert_equal 2, session['another_var]
    Fixes #1529.
Commits on Feb 23, 2012
  1. @pixeltrix
Something went wrong with that request. Please try again.