Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Feb 7, 2011
  1. @jonleighton

    Refactor the implementations of AssociatioCollection#delete and #dest…

    jonleighton authored
    …roy to be more consistent with each other, and to stop passing blocks around, thus making the execution easier to follow.
  2. @jonleighton

    Make record.association.destroy(*records) on habtm and hm:t only dele…

    jonleighton authored
    …te records in the join table. This is to make the destroy method more consistent across the different types of associations. For more details see the CHANGELOG entry.
Commits on Jan 30, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Jan 16, 2011
  1. @jonleighton @tenderlove

    Removed support for accessing attributes on a has_and_belongs_to_many…

    jonleighton authored tenderlove committed
    … join table. This has been documented as deprecated behaviour since April 2006. Please use has_many :through instead. A deprecation warning will be added to the 3-0-stable branch for the 3.0.4 release.
Commits on Jan 7, 2011
  1. @jonleighton @tenderlove

    Construct an actual ActiveRecord::Relation object for the association…

    jonleighton authored tenderlove committed
    … scope, rather than a hash which is passed to apply_finder_options. This allows more flexibility in how the scope is created, for example because scope.where(a, b) and scope.where(a).where(b) mean different things.
Commits on Jan 5, 2011
  1. @tenderlove
  2. @tenderlove
  3. @tenderlove
  4. @tenderlove
Commits on Jan 4, 2011
  1. @rsim

    Explicitly select * from has_and_belongs_to_many association tables, …

    rsim authored
    …simplify exists? query
    
    Previous version (after commit 3103296) was generating wrong SQL for Oracle when calling exists? method on HABTM association.
  2. @jonleighton @tenderlove
  3. @jonleighton @tenderlove

    Let AssociationCollection#find use #scoped to do its finding. Note th…

    jonleighton authored tenderlove committed
    …at I am removing test_polymorphic_has_many_going_through_join_model_with_disabled_include, since this specifies different behaviour for an association than for a regular scope. It seems reasonable to expect scopes and association proxies to behave in roughly the same way rather than having subtle differences.
Commits on Dec 31, 2010
  1. @jonleighton

    Rename AssociationReflection#primary_key_name to foreign_key, since t…

    jonleighton authored
    …he options key which it relates to is :foreign_key
Commits on Dec 26, 2010
  1. @jonleighton @tenderlove

    Refactor we_can_set_the_inverse_on_this? to use a less bizarre name a…

    jonleighton authored tenderlove committed
    …mongst other things
  2. @jonleighton

    Associations: DRY up the code which is generating conditions, and mak…

    jonleighton authored
    …e it all use arel rather than SQL strings
Commits on Dec 20, 2010
  1. @jonleighton @tenderlove

    Remove unnecessary overloaded methods create, create! and create_reco…

    jonleighton authored tenderlove committed
    …rd from HasAndBelongsToManyAssociation
  2. @jonleighton @tenderlove

    Specify insert_record with NotImplementedError in AssociationCollecti…

    jonleighton authored tenderlove committed
    …on, to indicate that subclasses should implement it. Also add save_record to reduce duplication.
Commits on Dec 2, 2010
  1. @tenderlove
  2. @tenderlove
Commits on Nov 28, 2010
  1. @josevalim

    Partialy revert f1c13b0

    josevalim authored
Commits on Nov 25, 2010
  1. @miloops @spastorino

    Remove explicit return.

    miloops authored spastorino committed
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Nov 9, 2010
  1. @dchelimsky @spastorino

    use persisted? instead of new_record? wherever possible

    dchelimsky authored spastorino committed
    - persisted? is the API defined in ActiveModel
    - makes it easier for extension libraries to conform to ActiveModel APIs
      without concern for whether the extended object is specifically
      ActiveRecord
    
    [#5927 state:committed]
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Oct 30, 2010
  1. @jonleighton @tenderlove

    Refactoring: replace the mix of variables like @finder_sql, @counter_…

    jonleighton authored tenderlove committed
    …sql, etc with just a single scope hash (created on initialization of the proxy). This is now used consistently across all associations. Therefore, all you have to do to ensure finding/counting etc is done correctly is implement the scope correctly.
Commits on Sep 22, 2010
  1. @miloops @spastorino

    Perf: refactor method.

    miloops authored spastorino committed
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
  2. @tenderlove
Commits on Aug 25, 2010
  1. @tenderlove
Commits on Aug 24, 2010
  1. @tenderlove
Commits on Aug 14, 2010
  1. @spastorino

    Deletes trailing whitespaces (over text files only find * -type f -ex…

    spastorino authored
    …ec sed 's/[ \t]*$//' -i {} \;)
Commits on Aug 13, 2010
  1. @sikachu @tenderlove

    Removing most of the symbol to proc usage in Active Record

    sikachu authored tenderlove committed
    This will hopefully make Active Record run a bit more faster.
  2. @tenderlove
  3. @tenderlove
Commits on Aug 2, 2010
  1. @neerajdotname
Commits on Jul 21, 2010
  1. @josevalim
  2. @neerajdotname @josevalim

    Timestamp columns of HABTM join table should record timestamps

    neerajdotname authored josevalim committed
    [#5161 state:resolved]
Something went wrong with that request. Please try again.