Skip to content
Commits on May 9, 2012
  1. @carlosantoniodasilva

    Stop showing deprecations for Ruby 1.8.7 with remove_column

    carlosantoniodasilva committed
    String is Enumerable in 1.8.7, which means that passing a String to
    remove_column was generating deprecation warnings during tests.
Commits on May 5, 2012
  1. @tenderlove

    Merge pull request #6128 from frodsan/delete_all_limit_32

    tenderlove committed
    Fix #4979 against 3-2-stable
Commits on May 2, 2012
  1. Fix #4979 against 3-2-stable - delete_all raise an error if a limit i…

    Francesco Rodriguez committed
    …s provided
  2. @drogus
Commits on Apr 19, 2012
  1. @amatsuda @jeremy

    Be sure to correctly fetch PK name from MySQL even if the PK has some…

    amatsuda committed with jeremy
    … custom option
    
    Backports #5900
    
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
    	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
  2. @benedikt
  3. @benedikt

    Revert "Revert "Fix #5667. Preloading should ignore scoping.""

    benedikt committed
    This reverts commit 1166d49.
    
    Conflicts:
    
    	activerecord/test/cases/associations/eager_test.rb
  4. @benedikt

    Removes caching from ActiveRecord::Core::ClassMethods#relation

    benedikt committed
    The #relation method gets called in four places and the return value was instantly cloned in three of them. The only place that did not clone was ActiveRecord::Scoping::Default::ClassMethods#unscoped. This introduced a bug described in #5667 and should really clone the relation, too. This means all four places would clone the relation, so it doesn't make a lot of sense caching it in the first place.
    
    The four places with calls to relations are:
    
    activerecord/lib/active_record/scoping/default.rb:110:in `block in build_default_scope'"
    activerecord/lib/active_record/scoping/default.rb:42:in `unscoped'"
    activerecord/lib/active_record/scoping/named.rb:38:in `scoped'"
    activerecord/lib/active_record/scoping/named.rb:52:in `scope_attributes'"
    
    Conflicts:
    
    	activerecord/lib/active_record/core.rb
  5. @jeremy

    Revert "Fix #5667. Preloading should ignore scoping."

    jeremy committed
    Causes a subtle regression where record.reload includes the default
    scope. Hard to reproduce in isolation. Seems like the relation is
    getting infected by some previous usage.
    
    This reverts commit dffbb52.
Commits on Apr 18, 2012
  1. @norman

    Check for nil logger

    norman committed
Commits on Apr 9, 2012
  1. @fxn

    Merge pull request #5725 from kevmoo/remove_unused_castcode

    fxn committed
    Remove unused castcode
Commits on Apr 4, 2012
  1. @hone
  2. @kevmoo
Commits on Apr 3, 2012
  1. @tpope @tenderlove
Commits on Mar 30, 2012
  1. @tenderlove

    Merge pull request #5662 from arturopie/3-2_fixing_IM_when_using_find…

    tenderlove committed
    …_select
    
    Fixing Identity Map when using find select in rails 3.2
  2. @spastorino
  3. @spastorino

    Bump up to 3.2.3

    spastorino committed
  4. @jonleighton

    Fix #5667. Preloading should ignore scoping.

    jonleighton committed
    Conflicts:
    
    	activerecord/test/cases/associations/eager_test.rb
  5. @arturopie

    refactor instantiate method in base, so we remove nesting if's which …

    arturopie committed
    …make the code harder to read. Minor changes to contain_all_columns in IdentityMap.
    
    Conflicts:
    
    	activerecord/lib/active_record/base.rb
  6. @arturopie

    refactor the checking of the attributes of the record in IdentityMap#…

    arturopie committed
    …add, so it's more readable
  7. @arturopie

    Do not add record to identity map if the record doesn't have values f…

    arturopie committed
    …or all the columns, so we don't get 'MissingAttributeError' later when trying to access other fields of the same record.
Commits on Mar 29, 2012
  1. @spastorino

    Bumping to 3.2.3.rc2

    spastorino committed
Commits on Mar 28, 2012
  1. @jonleighton

    Fix #5549.

    jonleighton committed
Commits on Mar 27, 2012
  1. @drogus

    Merge pull request #5618 from lest/patch-1

    drogus committed
    force datetime attributes to be changed
  2. @lest

    force datetime attributes to be changed

    lest committed
    backport ddb5d2f to 3-2-stable
  3. @spastorino

    Bumping to 3.2.3.rc1

    spastorino committed
  4. @tenderlove

    Merge pull request #2621 from icco/master

    tenderlove committed
    Issue with schema dump
Commits on Mar 21, 2012
  1. @kennyj
Commits on Mar 18, 2012
  1. @kennyj
Commits on Mar 15, 2012
  1. @tenderlove

    Merge pull request #5437 from kennyj/fix_5430

    tenderlove committed
    Fix GH #5430. A Payload name for schema_search_path should be SCHEMA.
Commits on Mar 13, 2012
  1. @jrochkind

    ConnectionPool.checkout takes account of ruby using 'non-blocking con…

    jrochkind committed
    …dition variables' in mutex ConditionVariables
  2. @kennyj

    [3-2-stable] Fix GH #5399. connection_pools's keys are ActiveRecord::…

    kennyj committed
    …Base::ConnectionSpecification objects.
  3. @denisj @arunagw

    fix activerecord query_method regression with offset into Fixnum

    denisj committed with arunagw
    add test to show offset query_methods on mysql & mysql2
    
    change test to cover public API
Commits on Mar 12, 2012
  1. @tenderlove
  2. @tenderlove

    Merge pull request #5391 from jrochkind/connection_pool_doc

    tenderlove committed
    ConnectionPooll#clear_active_connections! rdoc inaccuracy since 3.2.0
Something went wrong with that request. Please try again.