Skip to content
Commits on Jan 20, 2012
  1. @jonleighton

    Fix another race condition.

    jonleighton committed Jan 20, 2012
    From 2c667f6.
    
    Thanks @pwnall for the heads-up.
    
    Conflicts:
    
    	activerecord/lib/active_record/core.rb
Commits on Jan 13, 2012
  1. @jonleighton

    Fix race condition :bomb:

    jonleighton committed Jan 13, 2012
Commits on Dec 23, 2011
  1. @jonleighton
  2. @jonleighton

    Fix #4046.

    jonleighton committed Dec 23, 2011
Commits on Dec 15, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Dec 14, 2011
  1. @jonleighton
Commits on Dec 1, 2011
  1. @jonleighton

    Remove the need for type_cast_attribute.

    jonleighton committed Dec 1, 2011
    This is good because it reduces duplication.
  2. @jonleighton

    Remove unnecessary *args

    jonleighton committed Dec 1, 2011
Commits on Sep 13, 2011
  1. @jonleighton

    Stop trying to be clever about when to define attribute methods.

    jonleighton committed Sep 13, 2011
    There is no meaningful performance penalty in defining attribute
    methods, since it only happens once.
    
    There is also no reason *not* to define them, since they get thrown in
    an included module, so they will not 'overwrite' anything. In fact, this
    is desirable, since it allows us to call super.
  2. @jonleighton

    We don't need to build a set for DangerousAttributeError.

    jonleighton committed Sep 13, 2011
    We can just use method_defined? and private_method_defined?
Commits on Sep 12, 2011
  1. @jonleighton

    Deprecate using method_missing for attributes that are columns.

    jonleighton committed Sep 12, 2011
    This shouldn't ever happen unless people are doing something
    particularly weird, but adding a deprecation in case there are bugs not
    caught by our tests.
  2. @jonleighton

    Let Ruby deal with method visibility.

    jonleighton committed Sep 12, 2011
    Check respond_to_without_attributes? in method_missing. If there is any
    method that responds (even private), let super handle it and raise
    NoMethodError if necessary.
  3. @jonleighton

    Always generate attribute methods on the base class.

    jonleighton committed Sep 11, 2011
    This fixes a situation I encountered where a subclass would cache the
    name of a generated attribute method in @_defined_class_methods. Then,
    when the superclass has it's attribute methods undefined, the subclass
    would always have to dispatch through method_missing, because the
    presence of the attribute in @_defined_class_methods would mean that it
    is never generated again, even if undefine_attribute_methods is called
    on the subclass.
    
    There various other confusing edge cases like this. STI classes share
    columns, so let's just keep all the attribute method generation state
    isolated to the base class.
  4. @jonleighton

    Fix warnings.

    jonleighton committed Sep 10, 2011
    Make sure we don't redefine an already-defined attribute method.
Something went wrong with that request. Please try again.