Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Dec 14, 2012
  1. @thedarkone

    Replace some global Hash usages with the new thread safe cache.

    thedarkone authored
    Summary of the changes:
     * Add thread_safe gem.
     * Use thread safe cache for digestor caching.
     * Replace manual synchronization with ThreadSafe::Cache in Relation::Delegation.
     * Replace @attribute_method_matchers_cache Hash with ThreadSafe::Cache.
     * Use TS::Cache to avoid the synchronisation overhead on listener retrieval.
     * Replace synchronisation with TS::Cache usage.
     * Use a preallocated array for performance/memory reasons.
     * Update the controllers cache to the new AS::Dependencies::ClassCache API.
       The original @controllers cache no longer makes much sense after @tenderlove's
       changes in 7b6bfe8 and f345e23.
     * Use TS::Cache in the connection pool to avoid locking overhead.
     * Use TS::Cache in ConnectionHandler.
Commits on Dec 5, 2012
  1. @claudiob

    Replace comments' non-breaking spaces with spaces

    claudiob authored
    Sometimes, on Mac OS X, programmers accidentally press Option+Space
    rather than just Space and don’t see the difference. The problem is
    that Option+Space writes a non-breaking space (0XA0) rather than a
    normal space (0x20).
    This commit removes all the non-breaking spaces inadvertently
    introduced in the comments of the code.
Commits on Nov 27, 2012
  1. @fxn
Commits on Nov 15, 2012
  1. @fxn

    let remove_constant still delete Kernel#autoload constants [rounds #8213

    fxn authored
    The method #remove_const does not load the file, so we
    can still remove the constant.
  2. @fxn
Commits on Sep 17, 2012
  1. update AS docs [ci skip]

    Francesco Rodriguez authored
Commits on Sep 6, 2012
  1. @fxn

    we already have the module objects, do not constantize

    fxn authored
    I have also chosen a variable name that matches the
    parameter in the definition of load_missing_constant.
  2. @fxn

    restores awesome comment

    fxn authored
    Those who say source code should be without comments lie.
  3. @fxn

    no more const_missing combinatorics

    fxn authored
    Basically, const_missing had a loop to try parent namespaces
    if the constant lookup failed, but at the same time delegated
    to load_missing_constant which in turn also walks up parent
    namespaces calling const_missing by hand. In the case of missing
    constants this results in repeated work in some funky nested way.
Commits on Sep 3, 2012
  1. @fxn

    revised the exception message "Expected #{file_path} to define #{qual…

    fxn authored
    Users need to know the ultimate problem here is that AS was
    trying to autoload a constant and it failed.
Commits on Aug 29, 2012
  1. @fxn

    fixes a regexp

    fxn authored
    We need to anchor to remove the extension. In addition to
    be the correct way to do that, files in ~/.rbenv get that
    .rb removed, so it is a real source of bugs, as reported in
Commits on Aug 28, 2012
  1. @fxn

    detect circular constant autoloading

    fxn authored
    Nowadays circular autoloads do not work, but the user gets a NameError
    that says some constant is undefined. That's puzzling, because he is
    normally trying to autoload a constant he knows can be autoloaded.
    With this check we can give a better error message.
  2. @fxn

    fixes a bug in dependencies.rb

    fxn authored
    loaded stores file names without the .rb extension, but search_for_file
    returns file names with the extension.
    The solution is hackish, but this file needs a revamp.
Commits on Aug 25, 2012
  1. @fxn

    simplifies yet another regexp

    fxn authored
  2. @fxn
  3. @fxn

    simplifies a regexp

    fxn authored
    We simplify two things here: First since * is greedy it is enough to go
    look for the rightmost ::, no need to ask the regexp engine to match the
    rest of the string since we are not validating anything, only capturing.
    The second simplification comes from using a look-ahead assertion, that
    allows us to have the capture in $&, thus removing the need of a group.
Commits on Aug 23, 2012
  1. @fxn

    simplifies a regexp

    fxn authored
    The new regexp has less work to do, we anchor a fixed string at the end
    and need no group.
Commits on Aug 20, 2012
  1. @fxn

    Revert "removes unused optional argument in AS::Dependencies::Loadabl…

    fxn authored
    This argument is there because that's the signature of Kernel#load.
    This reverts commit bf3fa34.
  2. @fxn
Commits on Aug 19, 2012
  1. @fxn

    removes the second argument of the AS const_missing hook

    fxn authored
    Ruby does not pass the nesting to const_missing (unfortunately).
    That second argument was there in case that changed, Yehuda
    sent a patch to MRI
    but there is not much movement there and Matz told me in
    Amsterdam there was no immediate plan to pass the nesting.
    So let's go back to implement what happens now, and if
    in the future we get the nesting then we will adapt this.
    Double-checked this with Mr Katz.
  2. @fxn
Commits on Jun 12, 2012
  1. @tenderlove

    raise the same exception in order to keep path info

    tenderlove authored
    Ruby 2.0.0 implements LoadError#path, but newly raised load errors will
    not contain the path information.  Replace the error message, copy
    blame, and rereaise the same exception object
Commits on Jun 9, 2012
  1. @fxn

    removes the obsolete require_association method from dependencies

    fxn authored
    This is an obsolete method from the very early days,
    apparently it was used circa 2004 because STI support
    was not smart enough. This method is not public
    interface, and we are heading a major version, so
    removal seems right.
Commits on May 13, 2012
  1. @lest

    use const_defined? with second argument in AS::Dependencies

    lest authored
    there is no need in local_const_defined? helper method
Commits on Mar 16, 2012
  1. @carlosantoniodasilva

    Remove deprecation from AS::Deprecation behavior, some minor cleanups

    carlosantoniodasilva authored
    * Refactor log subscriber, use select! to avoid a new object
    * Remove deprecation messages related to AS::Deprecation behavior
      This was added about 2 years ago for Rails 3:
    * Remove some not used requires
    * Refactor delegate to avoid string conversions and if statements inside each block
Commits on Jan 12, 2012
  1. @fxn
Commits on Dec 20, 2011
  1. @josevalim
Commits on Dec 6, 2011
  1. @josevalim

    Just track "require" if we have something in the watching stack.

    josevalim authored
    A patch has been provided earlier and we have asked for feedback:
    Except one case, all other cases showed improvements in boot time.
  2. @tenderlove
  3. @tenderlove
Commits on Nov 30, 2011
  1. @tenderlove
  2. @tenderlove

    Revert "avoid hundreds of thousands of calls to (Symbol|String)#to_s"

    tenderlove authored
    Test coverage isn't comprehensive enough to catch what this breaks. :(
    This reverts commit 45dad59.
  3. @tenderlove
Commits on Nov 23, 2011
  1. @josevalim
  2. @josevalim
Something went wrong with that request. Please try again.