Skip to content
This repository

Feb 27, 2013

  1. Santiago Pastorino

    There's no need to access Railties through self.class

    Closes #9386
    authored February 27, 2013

Feb 19, 2013

  1. Andrew White

    Revert "Deprecate the `eager_load_paths` configuration"

    Because of the possibility of lib being unintentionally eager loaded
    it's been agreed that we'll leave autoload paths and eager load paths
    separate for Rails 4.0.
    
    This reverts commit 0757b33.
    
    Conflicts:
    	railties/CHANGELOG.md
    authored February 19, 2013

Jan 24, 2013

  1. Andrew White

    Deprecate the `eager_load_paths` configuration

    Since the default in Rails 4.0 is to run in 'threadsafe' mode we need
    to eager load all of the paths in `autoload_paths` so we alias
    `eager_load_paths` to it. This may have unintended consequences if
    you have added 'lib' to `autoload_paths` such as loading unneeded
    code or code intended only for development and/or test environments.
    If this applies to your application you should thoroughly check what
    is being eager loaded.
    authored January 24, 2013

Jan 22, 2013

  1. Rafael Mendonça França

    Merge pull request #8557 from timraymond/add_back_engines_and_deprecate

    Adding Back Rails::Engine::Railties#engines
    
    Conflicts:
    	railties/CHANGELOG.md
    authored January 22, 2013

Jan 08, 2013

  1. Vijay Dev

    Merge branch 'master' of github.com:lifo/docrails

    Conflicts:
    	guides/source/getting_started.md
    authored January 09, 2013

Jan 07, 2013

  1. Carlos Antonio da Silva

    Revert some warning removals related to Ruby 2.0

    These warnings were actually a bug in Ruby 2.0, the accessors should not
    be raising such warnings, they are only meant for ivars.
    
    -
    
    Revert "fix warnings in Ruby 2.0"
    
    This reverts commit 26702a6.
    
    -
    
    Revert "Merge pull request #8282 from arunagw/warning_removed_for_ruby2"
    
    This reverts commit f63d654, reversing
    changes made to 3a89068.

Jan 06, 2013

  1. Gosha Arinich

    delegate to :class rather than 'self.class'

    authored January 06, 2013

Jan 03, 2013

  1. Timothy J. Raymond

    Adding Back Rails::Engine::Railties#engines

    Removing it breaks functionality with gems such as Thinking Sphinx.
    This restores it with a deprecation warning. Closes #8551
    authored December 19, 2012

Jan 02, 2013

  1. Gosha Arinich

    make symbol reference in docs appear as code

    authored January 03, 2013

Nov 29, 2012

  1. Rafael Mendonça França

    Remove observers and sweepers

    They was extracted from a plugin.
    
    See https://github.com/rails/rails-observers
    
    [Rafael Mendonça França + Steve Klabnik]
    authored October 14, 2012

Nov 20, 2012

  1. Arun Agrawal

    Initialize accessors to remove some warnings in Ruby 2.0

    authored November 21, 2012

Oct 14, 2012

  1. Robin Dupret

    Use Ruby 1.9 Hash syntax in railties

    authored October 14, 2012

Sep 21, 2012

  1. Stephan Hagemann

    Updated description of what engines are used for

    authored September 21, 2012

Aug 21, 2012

  1. José Valim

    Get rid of config.preload_frameworks in favor of config.eager_load_na…

    …mespaces
    
    The new option allows any Ruby namespace to be registered and set
    up for eager load. We are effectively exposing the structure existing
    in Rails since v3.0 for all developers in order to make their applications
    thread-safe and CoW friendly.
    authored August 01, 2012

Aug 10, 2012

  1. Piotr Sarnacki

    Fix handling SCRIPT_NAME from within mounted engine's

    When you mount your application at a path, for example /myapp, server
    should set SCRIPT_NAME to /myapp. With such information, rails
    application knows that it's mounted at /myapp path and it should generate
    routes relative to that path.
    
    Before this patch, rails handled SCRIPT_NAME correctly only for regular
    apps, but it failed to do it for mounted engines. The solution was to
    hardcode default_url_options[:script_name], which is not the best answer
    - it will work only when application is mounted at a fixed path.
    
    This patch fixes the situation by respecting original value of
    SCRIPT_NAME when generating application's routes from engine and the
    other way round - when you generate engine's routes from application.
    
    This is done by using one of 2 pieces of information in env - current
    SCRIPT_NAME or SCRIPT_NAME for a corresponding router. This is because
    we have 2 cases to handle:
    
    - generating engine's route from application: in this situation
      SCRIPT_NAME is basically SCRIPT_NAME set by the server and it
      indicates the place where application is mounted, so we can just pass
      it as :original_script_name in url_options. :original_script_name is
      used because if we use :script_name, router will ignore generating
      prefix for engine
    
    - generating application's route from engine: in this situation we
      already lost information about the SCRIPT_NAME that server used. For
      example if application is mounted at /myapp and engine is mounted at
      /blog, at this point SCRIPT_NAME is equal /myapp/blog. Because of that
      we need to keep reference to /myapp SCRIPT_NAME by binding it to the
      current router. Later on we can extract it and use when generating url
    
    Please note that starting from now you *should not* use
    default_url_options[:script_name] explicitly if your server already
    passes correct SCRIPT_NAME to rack env.
    
    (closes #6933)
    authored August 10, 2012

Jul 04, 2012

  1. Wojciech Wnętrzak

    There is only task for installing migrations when using engines

    authored July 04, 2012

Jun 29, 2012

  1. José Valim

    Revert "Allow loading external route files from the router"

    This reverts commit 6acebb3.
    
    Usage of this feature did not reveal any improvement in existing apps.
    
    Conflicts:
    
    	actionpack/lib/action_dispatch/routing/mapper.rb
    	guides/source/routing.textile
    	railties/lib/rails/engine.rb
    	railties/lib/rails/paths.rb
    	railties/test/paths_test.rb
    authored June 29, 2012
  2. José Valim

    Remove unused responsibilities and add a few load definitions to engines

    Since plugins were removed, we can clean up a few methods in engines.
    We also use this opportunity to move `load_console`, `load_tasks` and
    `load_runner` to Rails::Engine. This means that, if someone wants to
    improve script/rails for engines to support console or runner commands,
    part of the work is already done.
    authored June 29, 2012
  3. José Valim

    Remove unnecessary Railties structure now that plugins are gone

    authored June 29, 2012

May 29, 2012

  1. Toshinori Kajihara

    Add support runner hook.

    authored May 29, 2012

May 24, 2012

  1. Philip Arndt

    Fixed backward incompatibility for engines.

    - Many engines rely on being able to join directories to the Rails root:
    
        Rails.root.join('somedir')
    
    - This was now impossible because Rails.root returned a String:
    
        NoMethodError: undefined method `join' for "/code/myrailsapp":String
    
    - This was broken in 4001835
    authored May 24, 2012

May 23, 2012

  1. Aaron Patterson

    removing more pathnameisms

  2. Aaron Patterson

    I guess we have to return a pathname object. o_O

    authored May 22, 2012
  3. Aaron Patterson

    use File.realpath and avoid making Pathname objects

    authored May 22, 2012

May 22, 2012

  1. Aaron Patterson

    use RUBY_PLATFORM in case of cross compiled ruby

    authored May 22, 2012
  2. Aaron Patterson

    initialize our instance variables

    authored May 22, 2012

May 16, 2012

  1. Piotr Sarnacki

    Load all the env files available in config.paths (closes #6335)

    authored May 16, 2012

May 14, 2012

  1. Francesco Rodríguez

    Removing ==Examples and last blank lines of docs from railties

    authored May 14, 2012

May 04, 2012

  1. Piotr Sarnacki

    Merge pull request #5821 from Deradon/fix-engine-tasks

    Provided fix for calling rake tasks within mountable engines
    authored May 03, 2012

May 01, 2012

  1. Vijay Dev

    Merge branch 'master' of github.com:lifo/docrails

    authored May 01, 2012

Apr 28, 2012

  1. Piotr Sarnacki

    Fix Engine#routes to not call draw_paths multiple times

    authored April 28, 2012
  2. Roman V. Babenko

    Engine#routes? method has been fixed

    authored April 06, 2012 drogus committed April 28, 2012
  3. Mark Rushakoff

    Code-format references to config settings

Apr 26, 2012

  1. Yehuda Katz

    Routes reloader knows how to reload external files

    authored April 25, 2012

Apr 25, 2012

  1. Yehuda Katz

    Fix the build

    authored April 25, 2012
Something went wrong with that request. Please try again.