Skip to content
This repository
branch: master

Apr 22, 2014

  1. Rafael Mendonça França

    Perfer to define methods instead of calling test

    This file is using this pattern already
    authored April 22, 2014
  2. Rafael Mendonça França

    Fix syntax error

    authored April 22, 2014
  3. Rafael Mendonça França

    Add CHANGELOG entry for #14757 [ci skip]

    authored April 22, 2014
  4. Rafael Mendonça França

    Merge pull request #14757 from estsauver/14752

    Fix behavior of select! to be consistent with select #14752
    authored April 22, 2014
  5. Rafael Mendonça França

    Merge pull request #14573 from habermann24/has_many_through_fix

    Properly handle scoping with has_many :through. Fixes #14537.
    
    Conflicts:
    	activerecord/CHANGELOG.md
    	activerecord/test/cases/associations/has_many_through_associations_test.rb
    authored April 22, 2014
  6. Rafael Mendonça França

    Merge pull request #14801 from kuldeepaggarwal/fix-string-inflection

    Fix inconsistent behavior from String#pluralize
    authored April 22, 2014
  7. Yves Senn

    Merge pull request #14836 from jonatack/patch-5

    Fix run-on sentences and improve grammar [skip ci]
    authored April 22, 2014
  8. Jon Atack

    Fix run-on sentences and improve grammar [skip ci]

    authored April 22, 2014
  9. Rafael Mendonça França

    Merge pull request #13335 from glorieux/favicon_link_tag_mimetype

    Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon to image/x-icon.
    authored April 22, 2014
  10. Rafael Mendonça França

    Merge pull request #10764 from mokevnin/replace_class_eval_by_define_…

    …method
    
    replace class_eval by define_method in abstract_controller/callbacks
    authored April 22, 2014
  11. Rafael Mendonça França

    Merge pull request #14835 from zzak/test_form_helper_label_with_block…

    …_and_html
    
    Add test for using ActionView::Helpers::FormHelper.label with block and html
    authored April 22, 2014
  12. Zachary Scott

    Add test for using ActionView::Helpers::FormHelper.label with block a…

    …nd html
    authored April 22, 2014

Apr 21, 2014

  1. Earl St Sauver

    select! renamed to avoid name collision Array#select!

    Fixes #14752
    
    Select mimics the block interface of arrays, but does not mock the
    block interface for select!. This change moves the api to be a
    private method, _select!.
    authored April 15, 2014
  2. Jeremy Kemper

    Rearrange deck chairs on the titanic. Organize connection handling te…

    …st cases.
    authored April 21, 2014
  3. Geoffroy Lorieux

    Change favicon_link_tag helper mimetype from image/vnd.microsoft.icon…

    … to image/x-icon.
    
    Although the official IANA-registered MIME type for ICO files is image/vnd.microsoft.icon,
    registered in 2003, it was submitted to IANA by a third party and is not recognized by Microsoft products.
    The MIME type image/x-icon should be used since is the one recognized by the major browsers on the market.
    authored December 16, 2013

Apr 20, 2014

  1. Arthur Nogueira Neves

    Merge pull request #14826 from stevegraham/action_controller_renderer…

    …_doc_fix
    
    ActionController::Renderers documentation fix
    authored April 20, 2014
  2. Arun Agrawal

    Merge pull request #14825 from arunagw/aa-remove-missleading-comment

    Removed missleading comment [ci skip]
    authored April 20, 2014
  3. Stevie Graham

    ActionController::Renderers documentation fix

    ActionController::Renderers::RENDERERS is an instance of Set. Docs incorrectly
    state that it's a Hash.
    authored April 20, 2014
  4. Arun Agrawal

    Changed miss-leading comment [ci skip]

    After this 21dbe6f
    
    2.1.1 :001 > 'business'.classify
     => "Business"
    
    2.1.1 :004 > 'calculus'.classify
     => "Calculu"
    2.1.1 :005 >
    authored April 20, 2014
  5. Arun Agrawal

    Merge pull request #14823 from kuldeepaggarwal/fix-inflector-example

    correct the classify example's output.
    authored April 20, 2014
  6. Kuldeep Aggarwal

    [ci-skip] correct the classify example's output

  7. Mokevnin Kirill

    replace class_eval by define_method in abstract_controller/callbacks

    authored May 26, 2013
  8. Richard Schneeman

    Merge pull request #14820 from akshay-vishnoi/doc_changes

    [ci skip] builtin -> built-in
    authored April 20, 2014
  9. Arthur Nogueira Neves

    Merge pull request #14821 from jonatack/patch-5

    Fix code indentation and improve formatting
    authored April 20, 2014
  10. Akshay Vishnoi

    [ci skip] builtin -> built-in

  11. Jon Atack

    Fix code indentation and improve formatting

    in the Getting Started Guide.
    
    This PR regroups #14817, #14818 and #14819 into one commit.
    
    [skip ci]
    authored April 20, 2014
  12. Robin Dupret

    Merge pull request #14816 from jonatack/patch-2

    Grammar fix in Getting Started Guide [ci skip]
    authored April 20, 2014
  13. Jon Atack

    Grammar fix in Getting Started Guide

    authored April 20, 2014
  14. Andrew White

    Make URL escaping more consistent

    1. Escape '%' characters in URLs - only unescaped data
       should be passed to URL helpers
    
    2. Add an `escape_segment` helper to `Router::Utils`
       that escapes '/' characters
    
    3. Use `escape_segment` rather than `escape_fragment`
       in optimized URL generation
    
    4. Use `escape_segment` rather than `escape_path`
       in URL generation
    
    For point 4 there are two exceptions. Firstly, when a route uses wildcard
    segments (e.g. *foo) then we use `escape_path` as the value may contain '/'
    characters. This means that wildcard routes can't be optimized. Secondly,
    if a `:controller` segment is used in the path then this uses `escape_path`
    as the controller may be namespaced.
    
    Fixes #14629, #14636 and #14070.
    authored April 20, 2014
  15. Andrew White

    Optimize URI escaping

    The URI::Parser#escape method is a general use method that has to deal
    with a variety of input however our use of it is limited in scope so
    we can increase the performance by implementing our specific needs
    within ActionDispatch::Journey::Router::Utils directly.
    
    If there is no encoding required then there is no change in performance
    or number of objects allocated, but for each character that needs to be
    encoded we save five object allocations and gain a performance boost.
    The performance boost seen varies from 20% when there is one character
    to over 50% when encoding ten characters.
    authored April 19, 2014
  16. Edho Arief

    Always escape string passed to url helper.

    Makes it clear that anything passed with the helper must not be percent encoded.
    
    Fixes previous behavior which tricks people into believing passing
    non-percent-encoded will generate a proper percent-encoded path while in
    reality it doesn't ('%' isn't escaped).
    
    The intention is nice but the heuristic is broken.
    authored April 07, 2014 pixeltrix committed April 20, 2014

Apr 19, 2014

  1. Guillermo Iguaran

    Merge pull request #14811 from qrush/master

    Remove statement assuming coffee shop/public space wifi is inherently insecure
    authored April 19, 2014
  2. Nick Quaranto

    Remove statement assuming coffee shop/public space wifi is inherently…

    … insecure
    authored April 19, 2014
  3. Godfrey Chan

    Merge pull request #14810 from robin850/patch-18

    Don't rely on Arel master in bug report template
    authored April 19, 2014
  4. Robin Dupret

    Don't rely on Arel master in bug report template [ci skip]

    We should rely instead on the version supported by Active Record
    
    Closes #14809
    authored April 19, 2014
Something went wrong with that request. Please try again.