Commits on Jul 24, 2016
  1. @fxn

    systematic revision of =~ usage in AV

    Where appropriate, prefer the more concise Regexp#match?,
    String#include?, String#start_with?, or String#end_with?
    fxn committed Jul 25, 2016
  2. @fxn

    use \A and \z when you mean \A and \z

    In Ruby ^ and $ mean start and end of *line*.
    
    A regexp that validates an email should not check if
    some line of the string looks like an email, and maybe
    be surrounded by the entire Joyce's Ulysses. What the
    regexp has to check is if the string itself looks like
    an email.
    
    This validator is used only in tests, the ^/$ anchors
    implied no risk.
    fxn committed Jul 24, 2016
  3. @fxn

    adds missing requires

    fxn committed Jul 24, 2016
  4. @fxn
  5. @prathamesh-sonpatki

    Merge pull request #25928 from mechanicles/info-for-cache-fetch-block

    Add proper description for `Rails.cache.fetch` [ci skip]
    prathamesh-sonpatki committed on GitHub Jul 24, 2016
  6. @mechanicles
Commits on Jul 23, 2016
  1. @fxn

    removes spurious line

    fxn committed Jul 24, 2016
  2. @fxn

    give some love to this test file

    It all started noticing some foo.method({ ... }) method calls
    in passing. This is a whole pass modernizing this file.
    
    While some string literals are edited where I touched code,
    this pass does not uniformizes quotes. A ton are left untouched
    on purposes. We have no defined style.
    fxn committed Jul 23, 2016
  3. @fxn

    systematic revision of =~ usage in AR

    Where appropriatei, prefer the more concise Regexp#match?,
    String#include?, String#start_with?, or String#end_with?
    fxn committed Jul 23, 2016
  4. @kaspth

    Merge pull request #25908 from mechanicles/derives-from

    Explain meaning of the code very well and Remove confusion. [ci skip]
    kaspth committed on GitHub Jul 23, 2016
  5. @mechanicles

    Explain meaning of the code very well and Remove confusion. [ci skip]

    Code like `render(topics) => render("topics/topic")` adds confusion
    for the readers. On first impression, that code feels like hash kind
    of data, but it's not. So make it more clear and meaningful.
    mechanicles committed Jul 21, 2016
Commits on Jul 22, 2016
  1. @rafaelfranca

    Merge pull request #25914 from jmccartie/jm/not_in

    Adds `not_in?` onto Object
    rafaelfranca committed on GitHub Jul 22, 2016
  2. @fxn

    revises a regexp

    The exclamation mark is not a metacharacter.
    fxn committed Jul 22, 2016
  3. @fxn

    systematic revision of =~ usage in AS

    Where appropriate prefer the more concise Regexp#match?, String#include?,
    String#start_with?, and String#end_with?
    fxn committed Jul 22, 2016
Commits on Jul 21, 2016
  1. @fxn

    adds require for Regexp#match?

    fxn committed Jul 22, 2016
  2. @fxn

    revises style

    fxn committed Jul 22, 2016
  3. @fxn
  4. @jmccartie

    Adds `not_in?` onto Object

    jmccartie committed Jul 21, 2016
  5. @fxn

    performance boost for String#blank? in Ruby 2.4

    Some casual benchmarks showed a 2x factor.
    
    All credit goes to @nurse.
    fxn committed Jul 22, 2016
  6. @fxn

    define Range#match? if Ruby < 2.4

    See the rationale in the documentation included in this patch.
    
    We are going to gradually introduce this predicate in the code base.
    fxn committed Jul 21, 2016
  7. @bdewater @jeremy

    Allow MessageEncryptor to take advantage of authenticated encryption …

    …modes
    
    AEAD modes like `aes-256-gcm` provide both confidentiality and data authenticity, eliminating the need to use MessageVerifier to check if the encrypted data has been tampered with.
    
    Signed-off-by: Jeremy Daer <jeremydaer@gmail.com>
    bdewater committed with jeremy Jul 18, 2016
  8. @fxn

    Merge pull request #25911 from juno/fix-comment-indent

    Fix incorrect indentation in method comment
    fxn committed on GitHub Jul 21, 2016
  9. @juno
  10. @fxn

    explain the meaning of some RuboCop config options [ci skip]

    For consistency mainly.
    
    Also, some have a name that could make the reader think they
    enforce the opposite of what they do, because the default is
    not visible there.
    fxn committed Jul 21, 2016
  11. @senny

    Merge pull request #25907 from gsamokovarov/lock-web-console-for-5.0

    Enforce minimal web-console version for Rails 5
    senny committed on GitHub Jul 21, 2016
  12. @gsamokovarov

    Enforce minimal web-console version for Rails 5

    I dropped the version constraint in web-console with the idea it will be
    easier to upgrade the console between Rails releases. However, issues
    like #25899 started popping up.
    
    I'm reintroducing the constraint, but this time, I don't set an upper
    limit to the major version. This will keep the web-console in a version
    that always works for the current Rails version and can be easily
    upgraded to the last one with `bundle update`.
    
    We may need to backport this for Rails 5.0.1.
    
    Fixes #25899.
    gsamokovarov committed Jul 21, 2016
  13. @kaspth

    Merge pull request #25616 from ignatiusreza/callable_cache_key

    Bring back support for callable cache key when rendering collection
    kaspth committed on GitHub Jul 21, 2016
Commits on Jul 20, 2016
  1. @ignatiusreza
  2. @rafaelfranca

    Merge pull request #25902 from etiennebarrie/remove-tabs-before-commands

    Remove tab chars before commands to be run
    rafaelfranca committed on GitHub Jul 20, 2016
  3. @etiennebarrie
  4. @rafaelfranca

    Merge pull request #25885 from kamipo/fix_explain_logging_with_binds

    Fix explain logging with binds
    rafaelfranca committed on GitHub Jul 20, 2016
  5. @rafaelfranca

    Merge pull request #25786 from kamipo/add_exists_and_update_all_to_co…

    …llection_proxy
    
    Add `exists?` and `update_all` to `CollectionProxy` for respects an association scope
    rafaelfranca committed on GitHub Jul 20, 2016
  6. @rafaelfranca

    Merge pull request #25897 from yahonda/remove_set_date_columns_and_mo…

    …dify_attributes_test
    
    Remove Oracle specific tests based on deprecated behaviors
    rafaelfranca committed on GitHub Jul 20, 2016
  7. @yahonda

    Oracle TIMESTAMP sql type is associated with Rails `DateTime` type now

     - Refer rsim/oracle-enhanced#845
    Remove `set_date_columns` which has been deprecated in Oracle enhanced adapter
     - Refer rsim/oracle-enhanced#869
    yahonda committed Jul 20, 2016
  8. @kamipo

    Fix explain logging with binds

    `binds` is an array of a query attribute since Active Record 5.0.
    kamipo committed Jul 19, 2016