Skip to content
This repository
branch: master

Apr 16, 2014

  1. Rafael Mendonça França

    Merge pull request #14770 from crazymykl/avoid_dos_vuln_in_i18n_guide

    Avoid suggesting dangerous code in i18n guide
    authored
  2. Mike MacDonald

    [ci skip] Avoid suggesting dangerous code in i18n guide

    Calling `to_sym` on user input opens apps up to Denial of Service attacks, via the symbol table being expanded to consume vast swathes of memory.
    
    It is a fairly common configuration to have DNS configured such that all subdomains route to your Rails app, in which case an attacker visits `www1.foo.com`, `www2.foo.com`, and so on until something gives.
    
    It is far less likely to have this problem with TLDs, so that change was only for consistency.
    authored

Apr 15, 2014

  1. Rafael Mendonça França

    Merge pull request #14733 from akshay-vishnoi/test-cases

    Improve tests for duplicable, remove unnecessary constant
    authored
  2. Akshay Vishnoi

    Object#duplicable?

    1. Improve tests
    2. Remove unnecessary constant
    3. Add docs for BigDecimal#duplicable?
  3. Rafael Mendonça França

    Merge pull request #14768 from spectator/ac_metal_docfix

    Update AC::Metal documentation example
    authored
  4. Yury Velikanau

    Update AC::Metal documentation example [ci skip]

    Include proper module since AV was extracted form AP as mentioned in #14659.
    authored
  5. Rafael Mendonça França

    Add CHANGELOG entry for #14766 [ci skip]

    authored
  6. Rafael Mendonça França

    Merge pull request #14765 from byroot/refactor-counter-cache-create-a…

    …nd-destroy
    
    Refactor counter cache create and destroy
    authored
  7. Rafael Mendonça França

    Merge pull request #14766 from eric-chahin/migration_bug

    Changed change_column in PG schema_statements.rb to make sure that the u...
    authored
  8. eric-chahin

    Changed change_column in PG schema_statements.rb to make sure that th…

    …e uuid_generate function was not being quoted.
    authored
  9. Jean Boussier

    Hide BelongsToAssociation#increment_counters and #decrement_counters

    authored
  10. Jean Boussier

    Restore the destroy_by_association check in post destroy counter cache

    authored
  11. Jean Boussier

    Set _after_create_counter_called flag to make update counter cache work

    authored
  12. Rafael Mendonça França

    Merge pull request #14745 from razum2um/plain-text-diagnostics

    Display diagnostics in text format for xhr request
    authored
  13. Arthur Nogueira Neves

    Merge pull request #14762 from dwo/master

    use YAML.load_file in database tasks example
    authored
  14. Rafael Mendonça França

    Merge pull request #14756 from laurocaetano/fix-count-on-association-…

    …relation
    
    Fix count on association relation (calls to empty and size).
    authored
  15. Rob

    use YAML.load_file in database tasks example

    rather than YAML.load(File.read(path)). YAML.load_file is also used in
    guides/rails_guides/helper.rb since 2011, the only other precedent I could find.
    authored
  16. Yves Senn

    Merge pull request #14758 from JuanitoFatas/migrations-md

    [ci skip] Add missing end in one of the examples in Migrations.md.
    authored
  17. Juanito Fatas

    [ci skip] Add missing end in one of the examples in Migrations.md.

    authored
  18. Yves Senn

    Merge pull request #14728 from stomar/assertion-msg

    Remove surplus period from assertion messages
    authored
  19. Yves Senn

    Merge pull request #14642 from tgxworld/fix_notifications_not_unsubsc…

    …ribing
    
    Fix subscriptions not being unsubscribed.
    authored
  20. Lauro Caetano

    Make sure the column_name is different from 'all'.

    968c581 have fixed the EagerLoadTest, but
    not in the correct way.
    
    The problem was when `empty?` or `size` was called on relation. It was
    triggering `count(:all)`, which was passing `:all` as the column name to `count`
    on Calculations.
    
    On the other hand, the method `calculate` on Calculations was calling
    `construct_relation_for_association_calculations` instead of `perform_calculation`,
    because `has_include?` was returning `true` since `column_name` was present.
    
    To prevent calling the wrong method to perform the calculation, we have to check
    if the `column_name` is present and if it is different from `:all` (which is now used
    to correctly do `count` with `select`).
    
    More information here: 968c581#commitcomment-6006135
    authored
  21. Lauro Caetano

    The Association Relation should use `empty?` and `size` from Relation.

    968c581 have introduced this bug #14744
    on Association Relation when the method `empty?` or `size` was called.
    
    Example:
      # Given an author that does have 3 posts, but none of them with the
      # title 'Some Title'
      Author.last.posts.where(title: 'Some Title').size
      # => 3
    
    It was occurring, because the Association Relation had implemented these
    methods based on `@association`, this way giving wrong results.
    
    To fix it, was necessary to remove the methods `empty?` and `size` from
    Association Relation. It just have to use these methods from Relation.
    
    Example:
      # Given an author that does have 3 posts, but none of them with the
      # title 'Some Title'
      Author.last.posts.where(title: 'Some Title').size
      # => 0
      # Now it will return the correct value.
    
    Fixes #14744.
    authored

Apr 14, 2014

  1. Rafael Mendonça França

    Make console and generators blocks works at Application instance level

    Like rake tasks and runner blocks these blocks should also being shared
    between applications since they are stored at the classes.
    
    Fixes #14748
    authored
  2. Rafael Mendonça França

    :scissors:

    authored
  3. Rafael Mendonça França

    Return null type format when format is not know

    When requesting a controller with the following code with a unknown format:
    
        def my_action
          respond_to do |format|
            format.json { head :ok }
            format.any { render text: 'Default response' }
          end
        end
    
    we should render the default response instead of raising ActionController::UnknownFormat
    
    Fixes #14462
    
    Conflicts:
    	actionpack/CHANGELOG.md
    	actionpack/test/controller/mime/respond_with_test.rb
    
    Conflicts:
    	actionpack/CHANGELOG.md
    authored
  4. Rafael Mendonça França

    Remove outdated comment

    authored
  5. Richard Schneeman

    Merge pull request #14729 from akshay-vishnoi/doc_changes

    [ci skip] Improve doc, fix grammatical issue
    authored
  6. Jean Boussier

    Use inheritance chain instead of callbacks to increment counter cache…

    …s after destroy
    authored
  7. Jean Boussier

    Use inheritance chain instead of callbacks to increment counter cache…

    …s after create
    authored
  8. Aaron Patterson

    Merge pull request #14735 from byroot/idempotent-counter-caches

    Idempotent counter caches, fix concurrency issues with counter caches
    authored
  9. tgxworld

    Fix subscriptions not being unsubscribed.

    authored
  10. Marcus Stollsteimer

    Refine tests for assert_select failure messages

    authored
  11. Yves Senn

    Merge pull request #14746 from zenati/master

    Reference and link to install RVM in the Getting Started Guide. [ci skip]
    authored
  12. zenati

    [ci skip] Added link to ruby-lang.org installation.

    authored
Something went wrong with that request. Please try again.