Permalink
Commits on Aug 29, 2016
  1. @rafaelfranca

    Remove unneeded FIXME note

    This is the intended behavior. You should not do more than one request
    in a controller test.
    rafaelfranca committed Aug 29, 2016
  2. @kaspth

    Merge pull request #26311 from y-yagi/use_inspect_for_show_value

    use `inspect` for show `from` value
    kaspth committed on GitHub Aug 29, 2016
  3. @maclover7

    Merge pull request #26310 from kjellberg/guides

    Add .gitignore to "files & purpose" list - getting started docs
    maclover7 committed on GitHub Aug 29, 2016
  4. @kjellberg
  5. @y-yagi

    use `inspect` for show `from` value

    If `from` is nil, in order to avoid the blank is showed.
    y-yagi committed Aug 29, 2016
Commits on Aug 28, 2016
  1. @kaspth

    Merge pull request #26305 from kamipo/follow-up-to-26301

    Switch back to `Hash.dup`
    kaspth committed on GitHub Aug 28, 2016
  2. @kaspth

    Merge pull request #26306 from kamipo/remove_under_ruby-1.9

    Remove "Under Ruby 1.9" [ci skip]
    kaspth committed on GitHub Aug 28, 2016
  3. @kamipo

    Remove "Under Ruby 1.9" [ci skip]

    Rails dropped Ruby 1.9 support, but this comment still true.
    kamipo committed Aug 28, 2016
  4. @kamipo

    Switch back to `Hash.dup`

    Follow up to #26301.
    kamipo committed Aug 28, 2016
  5. @guilleiguaran

    validate_each in NumericalityValidator is never called in this case.

    NumericalityValidator#validate_each is never called when allow_nil is true and
    the value is nil because it is already skipped in EachValidator#validate.
    guilleiguaran committed Aug 28, 2016
  6. @ncreuschling @guilleiguaran

    Add test for allow_blank in numericality validation

    Signed-off-by: Guillermo Iguaran <guilleiguaran@gmail.com>
    ncreuschling committed with guilleiguaran Aug 25, 2016
  7. @guilleiguaran

    Merge pull request #26301 from maclover7/jm-fix-comment

    Switch back to `Hash.dup`
    guilleiguaran committed on GitHub Aug 28, 2016
Commits on Aug 27, 2016
  1. @maclover7

    Switch back to `Hash.dup`

    The performance difference between `Hash[]` and `Hash.dup` looks to have
    been narrowed by @tenderlove via this commit --> ruby/ruby@b3803cc#diff-eff9999082c8ce7d8ba1fc1d79f439cf.
    Since this commit first appeared in Ruby 2.0.0, and since Rails now
    requires a minimum Ruby version of 2.2.2, this performance boost should
    be available for all users.
    
    Relevant links:
    
    - This behavior was originally added via 02174a3
    - The conversation on the Ruby issue tracker lives here --> https://bugs.ruby-lang.org/issues/7166
    maclover7 committed Aug 27, 2016
  2. @vipulnsward

    Merge pull request #26299 from davydovanton/fix-typo

    Fix typo in Delegation#delegate_missing_to doc [ci skip]
    vipulnsward committed on GitHub Aug 27, 2016
  3. @davydovanton
  4. @vijaydev

    Merge pull request #26297 from ledermann/patch-1

    Errors#add_on_blank: Fix typo in deprecation message
    vijaydev committed on GitHub Aug 27, 2016
  5. @ledermann

    Fix typo in deprecation message

    This fixes a copy-and-paste-issue slipped in by #18996
    ledermann committed on GitHub Aug 27, 2016
  6. @guilleiguaran

    Merge pull request #26293 from mechanicles/move-custom-assertion

    Move Rails' custom assertion method `assert_nothing_raised` to its proper place.
    guilleiguaran committed on GitHub Aug 27, 2016
  7. @mechanicles

    Move custom assertion to its proper place

    ActiveSupport::Testing::Assertions.
    
    We have a separate module in which have defined Rails' own custom
    assertions. So it would be good to keep all custom Rails' assertions in
    one place i.e. in this module.
    mechanicles committed Aug 27, 2016
Commits on Aug 26, 2016
  1. @eileencodes

    Missing key should throw KeyError

    It should not throw a NameError, but should throw a KeyError.
    
    Fixes #26278
    eileencodes committed Aug 26, 2016
  2. @guilleiguaran

    Merge pull request #26288 from maclover7/jm-revert-21995

    Update `Rails.configuration` documentation
    guilleiguaran committed on GitHub Aug 26, 2016
  3. @maclover7
  4. @maclover7

    Add back in `config_for` example

    [ci skip]
    maclover7 committed Aug 26, 2016
  5. @maclover7

    Revert "Merge pull request #21995 from tak1n/master"

    This reverts commit 4973704, reversing
    changes made to 78edeb3.
    maclover7 committed Aug 26, 2016
  6. @maclover7

    Merge pull request #26287 from mechanicles/rails-assertion

    Move `assert_nothing_raised` method to Rails Specific Assertions section [ci skip]
    maclover7 committed on GitHub Aug 26, 2016
  7. @mechanicles

    Move `assert_nothing_raised` method to Rails Specific Assertions

    section [ci skip]
    
    - Method `assert_nothing_raised` is Rails' own custom assertion method and
    not a part of Minitest. So move it from Minitest assertions section to Rails
    Specific Assertions section.
    mechanicles committed Aug 26, 2016
  8. @guilleiguaran

    Merge pull request #26284 from kamipo/fix_warnig

    Fix "warning: assigned but unused variable - task"
    guilleiguaran committed on GitHub Aug 26, 2016
Commits on Aug 25, 2016
  1. @kamipo

    Fix "warning: assigned but unused variable - task"

    kamipo committed Aug 25, 2016
  2. @rafaelfranca
  3. @rafaelfranca

    Add load hooks to all tests classes

    Usually users extends tests classes doing something like:
    
        ActionView::TestCase.include MyCustomTestHelpers
    
    This is bad because it will load the ActionView::TestCase right aways
    and this will load ActionController::Base making its on_load hooks to
    execute early than it should.
    
    One way to fix this is using the on_load hooks of the components like:
    
        ActiveSupport.on_load(:action_view) do
          ActionView::TestCase.include MyCustomTestHelpers
        end
    
    The problem with this approach is that the test extension will be only
    load when ActionView::Base is loaded and this may happen too late in the
    test.
    
    To fix this we are adding hooks to people extend the test classes that
    will be loaded exactly when the test classes are needed.
    rafaelfranca committed Aug 25, 2016
Commits on Aug 24, 2016
  1. @tenderlove

    kick different instrumentation method

    We can eliminate a conditional by calling a different instrumentation
    method depending on the situation.  In this case, we'll call the special
    case "!render_template" instrumentation method and eliminate the case /
    when clause from the `instrument` method.
    tenderlove committed Aug 24, 2016
  2. @tenderlove

    remove useless freeze

    Ruby already does this freeze for us.
    tenderlove committed Aug 24, 2016
  3. @tenderlove

    Simplify cache hit logging

    CacheHelper is mixed in to Helpers, Helpers is mixed in to AV::Base.
    This means we can count on instances of AV::Base to have the "cache hit"
    method on them, and we can stop setting an ivar for cache logging and
    just ask the view if it was a cache hit.
    tenderlove committed Aug 24, 2016
  4. @guilleiguaran

    Merge pull request #26271 from jcoleman/fix-unnecessary-query-cache-b…

    …usting-test
    
    Test that AR query cache isn't busted when types are not same object
    guilleiguaran committed on GitHub Aug 24, 2016
  5. @sgrif

    Merge pull request #26235 from samphippen/allow-early-setting-of-inte…

    …gration-session
    
    Allow the `integration_sesion` to be set early on ActionDispatch::Integration::Runner.
    sgrif committed on GitHub Aug 24, 2016