Skip to content
Commits on Apr 24, 2016
  1. @prathamesh-sonpatki

    Deprecate `request_via_redirect` method.

    prathamesh-sonpatki committed Apr 23, 2016
    - Followup of #18693.
    - I think we missed deprecating `request_via_redirect` in that pull
      request.
    - Originally requested by DHH here
      #18333.
Commits on Apr 11, 2016
  1. @vipulnsward

    Pass over all Rails 5 warnings, to make sure:

    vipulnsward committed Apr 10, 2016
    - we are ending sentences properly
    - fixing of space issues
    - fixed continuity issues in some sentences.
    
    Reverts 8fc97d1 .
    This change reverts making sure we add '.' at end of deprecation sentences.
    This is to keep sentences within Rails itself consistent and with a '.' at the end.
Commits on Mar 7, 2016
  1. @bronson

    extract ActionDispatch::IntegrationTest::Behavior

    bronson committed Feb 25, 2016
    Similar to 176fbfd, this makes it possible for other test
    frameworks to hook into Rails integration test facilities.
  2. @yui-knk

    Prevent not-intended loading of `ActionDispatch::IntegrationTest`

    yui-knk committed Mar 7, 2016
    After 9d37874 `ActionDispatch::IntegrationTest`
    class is loaded and defined in all Rails environments, not only test but also
    production. This is not-intended loading of a class which is only used in
    test environment.
    To prevent not-intended loading, add `ActiveSupport.run_load_hooks` to
    `ActionDispatch::IntegrationTest` with `action_dispatch_integration_test` name
    and use it in `ActionMailer`.
Commits on Mar 2, 2016
  1. Do not run app.executor callbacks in integration tests

    Jorge Bejar and Santiago Pastorino committed Mar 2, 2016
    This reverts changes made to integration tests in PR #23807.
    The issue happens when using capybara with a driver that needs to start a
    server in a separate thread like (poltergeist, selenium, etc).
    Both threads the capybara server one and the test thread end running
    syncronize over the interlock.
Commits on Mar 1, 2016
  1. @matthewd

    Publish AS::Executor and AS::Reloader APIs

    matthewd committed Feb 22, 2016
    These should allow external code to run blocks of user code to do
    "work", at a similar unit size to a web request, without needing to get
    intimate with ActionDipatch.
Commits on Feb 12, 2016
  1. @kaspth

    Add fixes accidentally removed.

    kaspth committed Feb 12, 2016
    Yesterday, when improving how `parsed_body` extracted a parser I wrote
    77bbf1e. Then I thought that was too many changes in one commit
    and broke it up locally... or so I thought.
    
    When pushed the extra commits removed the changes! Wups!
    
    In shame, lob those changes together here:
    
      * 3b94c38 which meant to fix the CHANGELOG syntax error.
      * 5007df5 which meant to mention `parsed_body` in the docs.
      * 036a7a0 which meant to memoize the `parsed_body`.
Commits on Feb 11, 2016
  1. @kaspth

    [ci skip] Mention `parsed_body` in docs.

    kaspth committed Feb 11, 2016
    Little easier to understand when you know the method that's used.
  2. @kaspth

    Make `parsed_body` extract parser from the content type.

    kaspth committed Feb 11, 2016
    We're not guaranteed to have a `RequestEncoder` to assign on `get` requests
    because we aren't extracting the parser from the response content type.
    
    Until now.
Commits on Feb 10, 2016
  1. @kaspth

    Add `parsed_body` to spare writing out parsing routines.

    kaspth committed Feb 10, 2016
    When testing:
    
    ```ruby
    post articles_path, params: { article: { title: 'Ahoy!' } }, as: :json
    ```
    
    It's common to want to make assertions on the response body. Perhaps the
    server responded with JSON, so you write `JSON.parse(response.body)`.
    But that gets tedious real quick.
    
    Instead add `parsed_body` which will automatically parse the reponse
    body as what the last request was encoded `as`.
  2. @dhh

    Merge pull request #21671 from kaspth/integration-request-encoding-he…

    dhh committed Feb 10, 2016
    …lpers
    
    Add `as` to encode a request as a specific mime type.
Commits on Feb 3, 2016
  1. @sgrif

    Sleep well, sweet prince

    sgrif committed Feb 2, 2016
    Prototype, you have served us well. But you are no longer how we make an
    XMLHttpRequest. RIP
Commits on Jan 4, 2016
  1. @kaspth

    Add `as` to encode a request as a specific mime type.

    kaspth committed Sep 19, 2015
    Turns
    
    ```
    post articles_path(format: :json), params: { article: { name: 'Ahoy!' } }.to_json,
      headers: { 'Content-Type' => 'application/json' }
    ```
    
    into
    
    ```
    post articles_path, params: { article: { name: 'Ahoy!' } }, as: :json
    ```
Commits on Dec 6, 2015
  1. @eileencodes

    Push `before_sending` to super class

    eileencodes committed Dec 1, 2015
    We want to get rid of the `Live::Response` so we are consolidating methods
    from `Live::Response` and `Response` by merging them together.
    
    This adds an `#empty` method to the request so we don't need to
    hard-code the empty array each time we call an empty
    `ActionDispatch::Request`.
    
    The work here is a continuation on combining controller and integration
    test code bases into one.
Commits on Oct 28, 2015
  1. @Gaurav2728

    specify deprecated waring, follow the standard conventions

    Gaurav2728 committed Oct 28, 2015
    `skip_filter`, `skip_action_callback` may both are deprecated in Rails 5.1 so waring msg should be specific.
Commits on Oct 6, 2015
  1. @jeremy

    Use `Mime[:foo]` instead of `Mime::Type[:FOO]` for back compat

    jeremy committed Oct 4, 2015
    Rails 4.x and earlier didn't support `Mime::Type[:FOO]`, so libraries
    that support multiple Rails versions would've had to feature-detect
    whether to use `Mime::Type[:FOO]` or `Mime::FOO`.
    
    `Mime[:foo]` has been around for ages to look up registered MIME types
    by symbol / extension, though, so libraries and plugins can safely
    switch to that without breaking backward- or forward-compatibility.
    
    Note: `Mime::ALL` isn't a real MIME type and isn't registered for lookup
    by type or extension, so it's not available as `Mime[:all]`. We use it
    internally as a wildcard for `respond_to` negotiation. If you use this
    internal constant, continue to reference it with `Mime::ALL`.
    
    Ref. efc6dd5
Commits on Sep 21, 2015
  1. @tenderlove

    stop calling deprecated methods

    tenderlove committed Sep 21, 2015
    We should be asking the mime type method for the mime objects rather
    than via const lookup
Commits on Aug 21, 2015
  1. @tenderlove
Commits on Aug 7, 2015
  1. @tenderlove

    stop using @_env in the controller instance

    tenderlove committed Aug 7, 2015
    Actions are processed through `dispatch`, so they should have the
    request set on them before any user land code can be executed.  Lets
    stop setting _env on the controller, and give access to it through the
    `env` method.
  2. @grosser

    do not add common ports to HTTP_HOST

    grosser committed Aug 6, 2015
     - webservers do not do it
     - it makes redirect urls ugly when request.host is used for redirection
Commits on Jul 28, 2015
  1. @robin850
Commits on Jun 1, 2015
  1. @rafaelfranca

    Merge pull request #20138 from tgxworld/deprecated_assert_template

    rafaelfranca committed Jun 1, 2015
    Deprecate `assert_template` and `assigns()`.
Commits on May 31, 2015
  1. @eileencodes

    Use `any?` rather than `present?` to check args

    eileencodes committed May 31, 2015
    It's better to use Ruby methods when possible over methods defined by
    Active Support because then it does not need to rely on any
    dependencies.
Commits on May 30, 2015
  1. @tgxworld
Commits on May 18, 2015
  1. @repinel
Commits on May 2, 2015
  1. @eileencodes

    Use `args` instead of `*args` in `kwargs_request?` method

    eileencodes committed May 1, 2015
    `*args` is not required here and should be avoided when not necessary
    because `*args` are slower than `args` and create unnecessary array
    allocations.
Commits on Apr 17, 2015
  1. @sikachu

    Add missing require for String#strip_heredoc

    sikachu committed Apr 17, 2015
    This method is being used in `#xml_http_request`, but was not properly
    required. This causes `NoMethodError` on projects that are doing
    integration test.
Commits on Mar 9, 2015
  1. @eileencodes

    Call super last in before_setup

    eileencodes committed Mar 9, 2015
    This fixes the reasons 4cf3b8a, 303567e, and fa63448 needed to be
    reverted in 7142059. The revert has been reverted and this fixes
    the issues caused previously.
    
    If we call `super` first we will end up nuking the session settings in the
    application tests that do `setup do` - so any session login or cookie
    settings will not be persisted thoughout the test sessions.
    
    Calling `super` last prevents `@integration_session` from getting nuked
    and set to nil if it's already set.
    
    Test added to prevent regression of this behavior in the future.
  2. @eileencodes

    Revert "Revert integration test refactoring that caused app test regr…

    eileencodes committed Mar 9, 2015
    …essions"
    
    This reverts commit 7142059.
Commits on Mar 7, 2015
  1. @y-yagi
Commits on Feb 27, 2015
  1. @jeremy

    Revert integration test refactoring that caused app test regressions

    jeremy committed Feb 26, 2015
    Haven't diagnosed yet. No similarly failing tests in Rails to work from.
    
    cc @tenderlove, @eileencodes
    
    Revert "there is always an integration session, so remove the check"
    Revert "lazily create the integration session"
    Revert "use before_setup to set up test instance variables"
    
    This reverts commits 4cf3b8a, 303567e, and fa63448.
Commits on Feb 25, 2015
  1. @jeremy

    Fix default headers in test responses

    jeremy committed Feb 24, 2015
    Fixes regression in #18423. Merge default headers for new responses,
    but don't merge when creating a response from the last session request.
    
    hat tip @senny :heart:
Commits on Feb 13, 2015
  1. @arthurnn

    Add missing comma

    arthurnn committed Feb 13, 2015
  2. @tgxworld
  3. @tgxworld

    Improve deprecation message.

    tgxworld committed Feb 13, 2015
Something went wrong with that request. Please try again.