Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jun 21, 2010
  1. Jeroen van Dijk José Valim

    Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an opt…

    jeroenvandijk authored josevalim committed
    …ions hash and make various Validators pass their (filtered) options.
    
    This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format".
    
    Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation.
    
    Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options).
    
    Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now.
    
    The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on May 15, 2010
  1. Jeroen van Dijk Jeremy Kemper

    Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an opt…

    jeroenvandijk authored jeremy committed
    …ions hash and make various Validators pass their (filtered) options.
    
    This makes it possible to pass additional options through Validators to message
    generation. E.g. plugin authors want to add validates_presence_of :foo, :format
    => "some format".
    
    Also, cleanup the :default vs :message options confusion in ActiveModel
    validation message generation.
    
    Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in
    favor of ActiveModel::Errors#add_on_blank(attributes, options).
    
    Original patch by Sven Fuchs, some minor changes and has been changed to be applicable to master again
    
    [#4057 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Something went wrong with that request. Please try again.