Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Feb 20, 2015
  1. @rafaelfranca
  2. @y-yagi
Commits on Feb 2, 2015
  1. @eileencodes

    Fix validations on child record when record parent has validate: false

    eileencodes authored
    Fixes #17621. This 5 year old (or older) issue causes validations to fire
    when a parent record has `validate: false` option and a child record is
    saved. It's not the responsibility of the model to validate an
    associated object unless the object was created or modified by the
    parent.
    
    Clean up tests related to validations
    
    `assert_nothing_raised` is not benefiting us in these tests
    Corrected spelling of "respects"
    It's better to use `assert_not_operator` over `assert !r.valid`
Commits on Jan 2, 2015
  1. @claudiob

    Use Active Model, not ActiveModel in plain English

    claudiob authored
    Also prevents the word "Model" from linking to the documentation
    of ActiveModel::Model because that's not intended.
    
    [ci skip]
Commits on Jul 28, 2014
  1. @Domon

    Fix example code of `EachValidator` [ci skip]

    Domon authored
    We have to specify the `:title` option to really use the
    `TitleValidator` defined above.
Commits on Jun 10, 2014
  1. @kuldeepaggarwal
Commits on Dec 19, 2013
  1. @vijaydev
Commits on Dec 13, 2013
  1. @rafaelfranca

    Fix typo [ci skip]

    rafaelfranca authored
Commits on Dec 12, 2013
  1. @aayushkhandelwal11
Commits on Dec 3, 2013
  1. @laurocaetano
Commits on May 23, 2013
  1. @apotonick @rafaelfranca

    deprecate Validator#setup (to get rid of a respond_to call). validato…

    apotonick authored rafaelfranca committed
    …rs do their setup in their constructor now.
Commits on Feb 9, 2013
  1. @henrik

    Clarify ActiveModel::Validator initialization in docs.

    henrik authored
    As discussed with @josevalim on Ruby Rogues Parley.
Commits on Jan 9, 2013
  1. Set default value to ActiveModel::Validator initializer attribute

    Irio Irineu Musskopf Junior authored
    Makes it easier to test its objects.
Commits on Dec 21, 2012
  1. @rafaelfranca

    Remove ActiveModel::Errors#add_on_present method.

    rafaelfranca authored
    We don't need to define a new method in ActiveMode::Errors for each
    validatior.
    
    See
    d72a07f#commitcomment-2325333
Commits on Dec 5, 2012
  1. @claudiob

    Replace comments' non-breaking spaces with spaces

    claudiob authored
    Sometimes, on Mac OS X, programmers accidentally press Option+Space
    rather than just Space and don’t see the difference. The problem is
    that Option+Space writes a non-breaking space (0XA0) rather than a
    normal space (0x20).
    
    This commit removes all the non-breaking spaces inadvertently
    introduced in the comments of the code.
Commits on Nov 4, 2012
  1. @carlosantoniodasilva

    Raise ArgumentError when no attribute is given to AMo::EachValidator

    carlosantoniodasilva authored
    ArgumentError is better suited than RuntimeError for this.
Commits on Oct 22, 2012
  1. @AvnerCohen
Commits on Oct 21, 2012
  1. minor edits in AM documentation [ci skip]

    Francesco Rodriguez authored
Commits on Aug 5, 2012
  1. @fxn

    removes usage of Object#in? from the code base (the method remains de…

    fxn authored
    …fined by Active Support)
    
    Selecting which key extensions to include in active_support/rails
    made apparent the systematic usage of Object#in? in the code base.
    After some discussion in
    
        5ea6b0d
    
    we decided to remove it and use plain Ruby, which seems enough
    for this particular idiom.
    
    In this commit the refactor has been made case by case. Sometimes
    include? is the natural alternative, others a simple || is the
    way you actually spell the condition in your head, others a case
    statement seems more appropriate. I have chosen the one I liked
    the most in each case.
Commits on Aug 4, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	activemodel/lib/active_model/secure_password.rb
    	activerecord/lib/active_record/associations/collection_proxy.rb
Commits on Aug 2, 2012
  1. @fxn
  2. @fxn
Commits on Jul 30, 2012
  1. update ActiveModel::Validations docs [ci skip]

    Francesco Rodriguez authored
Commits on Jul 29, 2012
  1. update ActiveModel::Validator docs [ci skip]

    Francesco Rodriguez authored
Commits on Jul 6, 2012
Commits on Jan 6, 2012
  1. @rafaelfranca
Commits on Oct 26, 2011
  1. @bradrobertson
Commits on Oct 11, 2011
  1. @dolzenko
Commits on Apr 13, 2011
  1. @sikachu @dhh

    Remove `#among?` from Active Support

    sikachu authored dhh committed
    After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now.
    
    It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
Commits on Apr 11, 2011
  1. @dhh
Commits on Apr 10, 2011
  1. @sikachu @dhh

    Using Object#in? and Object#either? in various places

    sikachu authored dhh committed
    There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?.
Commits on Mar 12, 2011
  1. @mikegehard @spastorino

    Add additional text to NotImplementedErrors [#6328 state:resolved]

    mikegehard authored spastorino committed
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Mar 7, 2011
  1. @vijaydev

    formatting changes

    vijaydev authored
Commits on Mar 6, 2011
  1. @pacoguzman
Commits on Sep 16, 2010
  1. @squadette

    Tiny fixes to rdoc

    squadette authored
Something went wrong with that request. Please try again.