Skip to content
Commits on Feb 12, 2016
  1. @Gaurav2728

    use rails instead of rake

    Gaurav2728 committed
    since starting with Rails 5.x(beta) we prefer to use rails as the replacement of rake commands, may be change log will be the same
Commits on Feb 11, 2016
  1. @sgrif

    Merge pull request #18109 from k0kubun/unscoped-joins

    sgrif committed
    Allow `joins` to be unscoped
    
    Fixes #13775
  2. @sgrif

    Merge pull request #23581 from diego-silva/uniqueness-validator-pk-fix

    sgrif committed
    UniquenessValidator exclude itself when PK changed
  3. @sgrif

    Ensure prepared statement caching still occurs with Adequate Record

    sgrif committed
    In Rails 5, we're much more restrictive about when we do or don't cache
    a prepared statement. In particular, we never cache when we are sending
    an IN statement or a SQL string literal
    
    However, in the case of Adequate Record, we are *always* sending a raw
    SQL string, and we *always* want to cache the result.
    
    Fixes #23507
    
    /cc @tgxworld
  4. @kaspth

    Merge pull request #23605 from y-yagi/remove_warnings_in_finder_methods

    kaspth committed
    remove warnings from FinderMethods
Commits on Feb 10, 2016
  1. @y-yagi

    remove warnings from FinderMethods

    y-yagi committed
    This removes the following warnings.
    
    ```
    activerecord/lib/active_record/relation/finder_methods.rb:252: warning: ambiguous first argument; put parentheses or a space even after `-' operator
    activerecord/lib/active_record/relation/finder_methods.rb:258: warning: ambiguous first argument; put parentheses or a space even after `-' operator
    activerecord/lib/active_record/relation/finder_methods.rb:268: warning: ambiguous first argument; put parentheses or a space even after `-' operator
    activerecord/lib/active_record/relation/finder_methods.rb:274: warning: ambiguous first argument; put parentheses or a space even after `-' operator
    ```
  2. @spastorino

    Merge pull request #23395 from PareshGupta/remove-unused-constant

    spastorino committed
    Remove unused ReaderMethodCache and  WriterMethodCache  constants from ActiveRecord
  3. @tenderlove

    build scope chain functionally and remove caching

    tenderlove committed
    This commit walks the reflection tree and builds the scope chain
    functionally.  It also removes the chain cache since the cache doesn't
    seem to have any impact on performance (I'd prefer to only cache at
    proven bottlenecks)
  4. @brchristian
  5. @brchristian
  6. @brchristian
Commits on Feb 9, 2016
  1. @diego-silva

    UniquenessValidator exclude itself when PK changed

    diego-silva committed
    When changing the PK for a record which has a uniqueness validation on
    some other attribute, Active Record should exclude itself from the
    validation based on the PK value stored on the DB (id_was) instead of
    its new value (id).
Commits on Feb 8, 2016
  1. @kamipo

    Add numeric type in the doc [ci skip]

    kamipo committed
    Follow up to #23508.
Commits on Feb 7, 2016
  1. @sgrif

    Merge pull request #23547 from kamipo/schema_type_returns_symbol

    sgrif committed
    `schema_type` returns symbol rather than string
  2. @sgrif

    Merge pull request #23508 from meinac/add_numeric_type_into_migrations

    sgrif committed
    Added numeric helper into `SchemaStatements` for MySQL and PostgreSQL
  3. @kamipo

    `schema_type` returns symbol rather than string

    kamipo committed
    A return value of `schema_type` is used by:
    
    1. primary key type: using as `symbol.inspect`
    2. normal column type: using as `symbol.to_s`
    
    It is better to return symbol.
  4. @vijaydev
  5. @vijaydev

    fix indentation

    vijaydev committed
  6. @meinac

    Added numeric helper into migrations.

    meinac committed
    With this addition, you can add a column into the table like:
    
    ```
      create_table(:numeric_types) do |t|
        t.numeric :foo, precision: 10, scale: 2, default: 2.0
      end
    ```
    
    The result of the migration above is same with:
    
    ```
      create_table(:numeric_types) do |t|
        t.decimal :foo, precision: 10, scale: 2, default: 2.0
      end
    ```
Commits on Feb 6, 2016
  1. @sgrif

    Merge pull request #23519 from kamipo/mariadb_does_not_support_json_type

    sgrif committed
    MariaDB does not support JSON type
  2. @kamipo

    MariaDB does not support JSON type

    kamipo committed
    Fixes #22980.
  3. @kamipo

    Remove duplicated `require 'arel'`

    kamipo committed
    It appears first in `lib/active_record.rb`.
  4. @yui-knk

    [ci skip] Good bye SQLite2

    yui-knk committed
    Follow up of c9feea6
Commits on Feb 5, 2016
  1. @sgrif

    Revert "Dump indexes in `create_table` instead of `add_index`"

    sgrif committed
    This reverts commit 99801c6.
    
    Ultimately it doesn't matter whether `add_index` or `t.index` are used
    in the schema dumper in any meaningful way. There are gems out there
    which hook into the old behavior for things like indexing materialized
    views. Since the reverted commit doesn't seem to add much benefit,
    there's no reason for us to break these gems.
Commits on Feb 4, 2016
  1. @jhubert
  2. @jhubert
  3. @jhubert

    Remove the assumption of schema in DATABASE_URL

    jhubert committed
    If you set the DATABASE_URL environment variable to `mydatabase` by accident, you end up getting a series of errors that are hard to trace. For example: 
    
    ```
    warning: already initialized constant ActiveRecord::Base::OrmAdapter
    ```
    
    Turns out the cascade of errors is due to the error raised by `.tr` being called on `nil`.
    
    This commit makes sure that `scheme` is set before calling `.tr` on it. My previous iteration used `@uri.scheme.try(:tr, '-', '_')` but using the `&&` logical operator is a fair bit faster: http://stackoverflow.com/questions/26655032/try-vs-performance
    
    With this change, the error message becomes much more understandable:
    
    ```
    FATAL:  database "mydatabase" does not exist (ActiveRecord::NoDatabaseError)
    ```
  4. @amatsuda

    Typos in AR tests

    amatsuda committed
  5. @sgrif

    Merge pull request #23460 from kamipo/innodb_supports_fulltext_and_sp…

    sgrif committed
    …atial_indexes
    
    InnoDB supports FULLTEXT and Spatial Indexes [ci skip]
  6. @sgrif

    Merge pull request #23458 from kamipo/activerecord_supports_mysql_5.0…

    sgrif committed
    …_and_up
    
    Active Record supports MySQL >= 5.0
  7. @kamipo
Commits on Feb 3, 2016
  1. @matthewd

    Merge pull request #23457 from matthewd/arel-attribute

    matthewd committed
    Defer Arel attribute lookup to the model class
  2. @matthewd
  3. @kamipo
  4. @kamipo

    Active Record supports MySQL >= 5.0

    kamipo committed
    Currently some features uses `information_schema` (e.g. foreign key
    support). `information_schema` introduced since MySQL 5.0.
Something went wrong with that request. Please try again.