Skip to content
Commits on Apr 30, 2014
  1. @pftg

    Stringify variables names for mysql connections

    pftg committed
    For mysql2/mysql adapters, `sql_mode` variable name set in `database.yml`
    as string, was ignored and `sql_mode` was set to use strict mode.
    Fixes #14895
Commits on Dec 23, 2013
  1. @pftg
Commits on Dec 10, 2013
  1. @pftg

    Fix type cast on group sum with custom expression

    pftg committed
    For PG adapters with custom expression and grouped result
    of aggregate functions have not found correct column type
    for it. Extract column type from query result.
    Closes: #13230
Commits on Oct 27, 2013
  1. @pftg
Commits on Oct 20, 2013
  1. @pftg

    Process sub-query relation's binding values

    pftg committed
    Generated sub-query for Relation as array condition for `where` method
    did not take in account its bind values, in result generates invalid SQL query.
    Fixed by adding sub-query relation's binding values to base relation
    Closes: #12586
Commits on Oct 13, 2013
  1. @pftg

    Generate subquery for Relation passed as array condition for where

    pftg committed
    Instead of executing 2 queries for fetching records filtered by array condition with Relation,
    added generation of subquery to current query.
    This behaviour will be consistent when passes Relation as hash condition to where
    Closes: #12415
  2. @pftg

    Make missed association exception message more informative

    pftg committed
    Add target class name, which should have missed association on preload,
    into exception message to simplify detecting problem part.
Commits on Sep 28, 2013
  1. @pftg

    Removed where_values_hash from AR::NullRelation

    pftg committed
    In order to build associated records for owners which has not been saved
    need to get where values to use as default attributes.
    But for new record owner uses `ActiveRecord::NullRelation` which
    override `where_values_hash` to return empty hash stub.
    `where_values_hash` is not used to invoke any sql query, but good to
    build others chains (even will be never executed) like:
      post          =
      admin_comment =
      assert_equal 'Admin',
    Closes #11376, #11676, #11675
Commits on Sep 13, 2013
  1. @pftg

    Collapse where constraints to one where constraint

    pftg committed
    In order to remove duplication with joining arel where constraints with
    `AND`, all constraints on `build_arel` are collapsed into one head node: `Arel::Nodes::And`
    Closes: #11963
Commits on Sep 4, 2013
  1. @pftg
Commits on Aug 14, 2013
  1. @pftg

    Rescue invalid ip address exceptions on assign.

    pftg committed
    In order that set attribute should not be bang method
Commits on Aug 2, 2013
  1. @pftg
Commits on Jul 14, 2013
  1. @pftg

    #4566: Remove extra decrement of transaction level

    pftg committed
    `rollback_active_record_state!` tries to restore model state on `Exception`
    by invoking `restore_transaction_record_state` it decrement deep level by `1`.
    After restoring it ensure that states to be cleared
    and level decremented by invoking `clear_transaction_record_state`,
    which cause the bug: because state already reduced in `restore_transaction_record_state`.
    Removed double derement of transaction level
    and removed duplicated code which clear transaction state for top level.
Commits on Jul 5, 2013
  1. @pftg

    #11288: Removed duplicated touching

    pftg committed
    if belongs to model with touch option on touch
    Closes #11288
Something went wrong with that request. Please try again.