Skip to content
This repository

Apr 04, 2014

  1. Yves Senn

    PostgreSQL and SQLite, remove varchar limit. [Vladimir Sazhin & Toms …

    …Mikoss & Yves Senn]
    There is no reason for the PG adapter to have a default limit of 255 on :string
    columns. See this snippet from the PG docs:
        Tip: There is no performance difference among these three types, apart
        from increased storage space when using the blank-padded type, and a
        few extra CPU cycles to check the length when storing into a
        length-constrained column. While character(n) has performance
        advantages in some other database systems, there is no such advantage
        in PostgreSQL; in fact character(n) is usually the slowest of the
        three because of its additional storage costs. In most situations text
        or character varying should be used instead.

Dec 12, 2013

  1. Yves Senn

    Merge pull request #13291 from strzibny/new_unique_constraint

    Translate new unique constraint error message for sqlite >= 3.8.2

Nov 09, 2013

  1. Yves Senn

    log bind variables after they were type casted.

    The log output used to be confusing in situation where type casting has
    "unexpected" effects. For example when finding records with a `String`.
    irb(main):002:0> Event.find("im-no-integer")
    D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- :   Event Load (4.5ms)  SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1  [["id", "im-no-integer"]]
    irb(main):002:0> Event.find("im-no-integer")
    D, [2013-11-09T11:10:28.998857 #1706] DEBUG -- :   Event Load (4.5ms)  SELECT "events".* FROM "events" WHERE "events"."id" = $1 LIMIT 1  [["id", 0]]

Sep 30, 2013

  1. Yves Senn

    extract adapter savepoint implementations into `abstract/savepoints.rb`.

  2. Yves Senn

    change the savepoint interface to allow passing the name.


Feb 20, 2013

  1. Yves Senn

    also rename indexes when a table or column is renamed

    When a table or a column is renamed related indexes kept their name. This will lead to confusing names. This patch renames related indexes when a column or a table is renamed. Only indexes with names generated by rails will be renamed. Indexes with custom names will not be renamed.
  2. Yves Senn

    reserve less chars for internal sqlite3 operations

  3. Yves Senn

    reserve index name chars for internal rails operations

    Some adapter (SQLite3) need to perform renaming operations to support
    the rails DDL. These rename prefixes operate with prefixes. When an
    index name already uses up the full space provieded by
    `index_name_length` these internal operations will fail. This patch
    introduces `allowed_index_name_length` which respects the amount of
    characters used for internal operations. It will always be <=
    `index_name_length` and every adapter can define how many characters
    need to be reserved.

Dec 19, 2012

  1. Yves Senn

    Keep index names when using with sqlite3

    authored senny committed

Oct 28, 2012

  1. Yves Senn

    refactor `SQLite3Adapter#copy_table` to prevent primary key redefinit…

    …ions. #6378
Something went wrong with that request. Please try again.