Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 2, 2015
  1. @eileencodes

    Use `def before_setup` instead of `setup do`

    eileencodes authored
    `setup do` creates unnecessary allocations of proc objects in test
    callbacks. This prevents that from happening and results in faster code.
    
    Originally I had done this as `def setup` and all Railties tests passed.
    See 044f9ab. Later it was reported there was an issue with this that
    caused routes in tests to be nil because devs don't generally call
    `super` in their test setups. Because of that I reverted the commit
    until I could find a suitble replacement.
    
    `before_setup` esentially does the same thing but without the
    requirement that applications call `super` in their test setups.
  2. @prathamesh-sonpatki
Commits on Apr 29, 2015
  1. @senny

    Merge pull request #19949 from thiagoaugusto/create-thiago-punctuatio…

    senny authored
    …n-fix
    
    CHANGELOG punctuation fix
  2. @thiagoaugusto

    CHANGELOG punctuation fix

    thiagoaugusto authored
    Punctuation fix
Commits on Apr 28, 2015
  1. @rafaelfranca

    Merge pull request #19939 from artofhuman/remove-mocha-from-some-tests

    rafaelfranca authored
    Remove use of mocha in the named base tests
  2. @senny
  3. @senny

    mailer previews, make sure labels and values line up.

    senny authored
    While this was true before when every `dd` had a value,
    this patch makes sure that everything keeps lining up even
    when the `dd` node is blank.
  4. @artofhuman
Commits on Apr 27, 2015
  1. @senny

    Revert "Merge pull request #17920 from calebthompson/dont-rely-on-env…

    senny authored
    …ironment-task-for-schema-load"
    
    This reverts commit 08ff4cc, reversing
    changes made to 6c9ed6d.
    
    Caused by #17920.
    
    Closes #19545.
    
    This patch introduced regressions because initializers were no longer
    loaded. Specifically missing inflections result in broken restores of
    the database.
Commits on Apr 26, 2015
  1. @arthurnn

    Need to add config.assets.compile=true to access `.assets`

    arthurnn authored
    sprockets-rails will only add `Rails.application.assets` if compile is
    no false. See change on sprockets-rails
    rails/sprockets-rails@d7c7ee1
  2. @arthurnn

    assets:cache:clean wont clean cache anymore

    arthurnn authored
    See the behaviour change on sprockets-rails
    rails/sprockets-rails@56725e5
  3. @prathamesh-sonpatki

    Escape README in Plugin builder API documentation

    prathamesh-sonpatki authored
     - So that RDoc will not generate link for README.
     [ci skip]
Commits on Apr 25, 2015
  1. @arthurnn

    Revert "Fix multiple suggestion test"

    arthurnn authored
    This reverts commit 6a7cf51.
  2. @arthurnn

    Fix multiple suggestion test

    arthurnn authored
  3. @simi @arthurnn

    Add test for multiple suggested generator names.

    simi authored arthurnn committed
  4. @amatsuda
  5. @amatsuda

    Do not show --helper and --assets options in the controller generator…

    amatsuda authored
    … help
    
    These options are not actually available.
    Thanks @soutaro for letting me aware of this.
Commits on Apr 24, 2015
  1. @senny

    Merge pull request #19236 from sshaw/more_tagged_logging_docs

    senny authored
    More docs on tagged logging [ci skip]
  2. @sshaw
Commits on Apr 23, 2015
  1. @cllns
Commits on Apr 22, 2015
  1. @rafaelfranca @pixeltrix
  2. @pixeltrix

    Remove sqlite support from `rails dbconsole`

    pixeltrix authored
    Support for versions of SQLite less than 3 was removed in #6011 as part
    of the Rails 4.0 release. Therefore there is no need to have support for
    it in the `rails dbconsole` command anymore.
  3. @rafaelfranca

    Don't ask something that we don't want to

    rafaelfranca authored
    We only want to support adapters that we officially support through the
    entire framework so it is better to not ask patches for adapters that
    we may not support
  4. @rafaelfranca

    Merge pull request #19858 from cllns/fix-scaffolding-css-formatting

    rafaelfranca authored
    Fix formatting of scaffold css
  5. @cllns

    Fix formatting of scaffold css

    cllns authored
  6. @senny

    pass over CHANGELOGs. [ci skip]

    senny authored
Commits on Apr 20, 2015
  1. @cllns
  2. @chancancode

    Implicitly skip spring for `rails new --dev`

    chancancode authored
    Spring seems like an obvious foot gun for the `--dev` setup, presumably you are
    about to make lots of changes to the codebase, so it should always reload the
    framework.
Commits on Apr 16, 2015
  1. @thenickcox
Commits on Apr 15, 2015
  1. @jonatack

    Fix typos and improve the documentation

    jonatack authored
    This is a squash of the following commits, from first to last:
    
    -
    
    Fix minor, random things I’ve come across lately that individually
    did not seem worth making a PR for, so I saved them for one commit.
    
    One common error is using “it’s” (which is an abbreviation of “it is”)
    when the possessive “its” should be used for indicating possession.
    
    -
    
    Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
    
    -
    
    Line wrap the changes at 80 chars and add one more doc fix.
    
    -
    
    Add a missing line wrap in the Contributing to Ruby on Rails Guide.
    
    -
    
    Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
    
    Rendering the guide locally with `bundle exec rake guides:generate` did
    not show any change in on-screen formatting after adding the line wrap.
    
    The HTML generated is (extra line added to illustrate where the line
    wrap takes place):
    
        <div class="info"><p>Please squash your commits into a single commit
    when appropriate. This
    
        simplifies future cherry picks and also keeps the git log
    clean.</p></div>
    
    -
    
    Squash commits.
Commits on Apr 14, 2015
  1. @pixeltrix

    Merge pull request #19751 from y-yagi/fix_indent_of_controller

    pixeltrix authored
    fix indent in routes when using namespaced controllers
  2. @guilleiguaran

    Merge pull request #19753 from jonatack/use-ruby-2-2-2

    guilleiguaran authored
    Upgrade to Ruby 2.2.2
  3. @jonatack

    Upgrade to Ruby 2.2.2

    jonatack authored
    and fix the grammar in the ruby_version_check.rb user message.
  4. @y-yagi

    fix indent in routes when using namespaced controllers

    y-yagi authored
    Before:
    
      namespace :foo do
      namespace :bar do
        get 'baz/index'
        end
      end
    
    After:
    
      namespace :foo do
        namespace :bar do
          get 'baz/index'
        end
      end
Commits on Apr 12, 2015
  1. @zzak

    :scissors:

    zzak authored
Something went wrong with that request. Please try again.