Skip to content
Commits on Feb 5, 2016
  1. @y-yagi

    move CHANGELOG entry to the appropriate position [ci skip]

    y-yagi committed
    Dummy apple icon files has been added after the 5.0.0.beta2 release.
    ref: #23455
  2. @vipulnsward

    Merge pull request #23489 from y-yagi/add_missing_include_to_engine_t…

    vipulnsward committed
    …est_example
    
    add missing include to engine test example [ci skip]
  3. @y-yagi

    add missing include to engine test example [ci skip]

    y-yagi committed
    Using url helper method of engine in example code,
    include `Engine.routes.url_helpers` is required to use helper method of engine.
  4. @rafaelfranca

    Merge pull request #23472 from jhubert/patch-2

    rafaelfranca committed
    Remove the assumption of schema in DATABASE_URL
Commits on Feb 4, 2016
  1. @rafaelfranca

    Merge pull request #23473 from gsamokovarov/kernel-module-function

    rafaelfranca committed
    Don't publicize Kernel core extensions
  2. @jhubert
  3. @jhubert
  4. @sgrif

    Merge pull request #23481 from meinac/activemodel_errors_doc_for_beha…

    sgrif committed
    …viour
    
    Add documentation about `ActiveModel::Errors#[]` method to describe how it works [ci skip]
  5. @meinac
  6. @rafaelfranca

    Merge pull request #23484 from rubys/patch-1

    rafaelfranca committed
    hotlink to the source and results for AWDwR tests
  7. @rubys
  8. @rafaelfranca

    Test with Turbolinks 5

    rafaelfranca committed
  9. @rafaelfranca

    Merge pull request #23479 from vipulnsward/23431-remove-jquery-on-spr…

    rafaelfranca committed
    …ockets-skip
    
    Remove jquery-rails gem from generator if --skip-sprockets is true
  10. @vipulnsward

    - app generate option --skip-sprockets leaves jquery-rails gem, which…

    vipulnsward committed
    … relies on sprockets environment
    
    - Remove jquery-rails if --skip-sprockets is true
    
    Fixes #23431
  11. @dhh

    Merge pull request #23480 from sikachu/redis-commented-out

    dhh committed
    Update assertion on redis in generated Gemfile
  12. @sikachu

    Update assertion on redis in generated Gemfile

    sikachu committed
    Redis now included in Gemfile but commented out. This change was made in
    9186443 and is causing the test
    failure.
    
    See https://travis-ci.org/rails/rails/jobs/106994913#L1025
  13. @rafaelfranca

    Merge pull request #23478 from vipulnsward/23470-pass-api-in-update-g…

    rafaelfranca committed
    …enerator
    
    Pass api only option to rails rails:update task to update only based on api Apps
  14. @vipulnsward
  15. @dhh

    Turbolinks has moved out

    dhh committed
    All grown up and shit!
  16. @dhh

    Redis is now only needed if you want to use Action Cable in production

    dhh committed
    So no need to have it on by default in the Gemfile.
  17. @dhh
  18. @gsamokovarov

    Don't publicize Kernel core extensions

    gsamokovarov committed
    This is a reaction to a [bug] we hit in web-console. The cause of it was
    a `Kernel` extension called `#console` that was public and was fighting
    over Railties with console block to be run on `rails console`. We solved
    it by making the method private. We did that through `module_function`
    so `::Kernel.console` can be invoked even in `BasicObject`.
    
    I'm proposing to make most of the core Active Support `Kernel`
    extensions `module_function` as well. Those are currently public and we
    are polluting every `Object` public interface with them.
    
    ```ruby
    >> Object.new.respond_to? :silence_warnings
    => true
    
    >> Object.new.respond_to? :with_warnings
    => true
    
    >> Object.new.respond_to? :enable_warnings
    => true
    
    >> Object.new.respond_to? :suppress
    => true
    ``
    
    Some extensions like `Kernel#class_eval` should be public, but most of
    them don't really need to be.
    
    [bug]: rails/web-console#184
  19. @jhubert

    Remove the assumption of schema in DATABASE_URL

    jhubert committed
    If you set the DATABASE_URL environment variable to `mydatabase` by accident, you end up getting a series of errors that are hard to trace. For example: 
    
    ```
    warning: already initialized constant ActiveRecord::Base::OrmAdapter
    ```
    
    Turns out the cascade of errors is due to the error raised by `.tr` being called on `nil`.
    
    This commit makes sure that `scheme` is set before calling `.tr` on it. My previous iteration used `@uri.scheme.try(:tr, '-', '_')` but using the `&&` logical operator is a fair bit faster: http://stackoverflow.com/questions/26655032/try-vs-performance
    
    With this change, the error message becomes much more understandable:
    
    ```
    FATAL:  database "mydatabase" does not exist (ActiveRecord::NoDatabaseError)
    ```
  20. @amatsuda

    rake stats dynamically scales now

    amatsuda committed
    So it can properly show stats for an app with 1,000,000+ LOC
  21. @amatsuda

    Revert "Lines of code can be 100,000+ in a Rails app"

    amatsuda committed
    This reverts commit 293bd95.
    
    This broke the header :<
  22. @amatsuda

    Typos in AR tests

    amatsuda committed
  23. @sgrif

    Merge pull request #23464 from kamipo/remove_commented_out_code_in_tr…

    sgrif committed
    …avis_rb
    
    Remove commented out code in `ci/travis.rb` [ci skip]
  24. @sgrif

    Merge pull request #23460 from kamipo/innodb_supports_fulltext_and_sp…

    sgrif committed
    …atial_indexes
    
    InnoDB supports FULLTEXT and Spatial Indexes [ci skip]
  25. @sgrif

    Merge pull request #23458 from kamipo/activerecord_supports_mysql_5.0…

    sgrif committed
    …_and_up
    
    Active Record supports MySQL >= 5.0
  26. @maclover7

    Merge pull request #23452 from phusion/action_cable

    maclover7 committed
    Document the fact that Action Cable does not require a multi-threaded app server
  27. @sgrif

    Merge pull request #23465 from kamipo/sqlite2_support_has_been_dropped

    sgrif committed
    SQLite 2 support has been dropped [ci skip]
  28. @kamipo
  29. @kamipo
Commits on Feb 3, 2016
  1. @arthurnn

    Merge pull request #23459 from mperham/master

    arthurnn committed
    Remove unused dependency
  2. @matthewd

    Merge pull request #23457 from matthewd/arel-attribute

    matthewd committed
    Defer Arel attribute lookup to the model class
Something went wrong with that request. Please try again.