Permalink
Switch branches/tags
Commits on Jun 11, 2018
  1. Fix active_model/errors docs [ci skip]

    bogdanvlviv committed Jun 11, 2018
    - Fix indentation.
    - Add a missing dot to the end of the sentence.
    
    Related to #32956
  2. Merge pull request #33119 from utilum/project_names_are_not_code

    fxn committed Jun 11, 2018
    Remove backticks around proejct names
  3. Merge pull request #33118 from dan-jensen/fix-eager-load-lockup-bug-i…

    rafaelfranca committed Jun 11, 2018
    …n-development
    
    Fix bug with eager_load in development environment
  4. Remove backticks around proejct names

    utilum committed Jun 11, 2018
    [ci skip]
  5. Fix bug with eager_load in development environment

    dan-jensen committed Jun 11, 2018
    Modifies the routes simulator to allow for empty RouteSets, which are
    created when secondary Engines are loaded.
  6. Merge pull request #33106 from marcandre/datecalc

    rafaelfranca committed Jun 11, 2018
    Improve some DateAndTime calculations
  7. Merge pull request #33092 from utilum/warnings_in_contribute_guide

    rafaelfranca committed Jun 11, 2018
    Remove ineffective no-warnings flags from Contribute guide
  8. Merge pull request #32997 from utilum/dev_dep_guide_update_ast_requir…

    rafaelfranca committed Jun 11, 2018
    …ements
    
    Dev-Dep guide: mention AST third party requirements
  9. Don't use `target=`

    rafaelfranca committed Jun 11, 2018
    It mark the association as loaded and this can cause the object to be in
    an stale state.
  10. Merge pull request #33114 from utilum/redundant_accessors

    rafaelfranca committed Jun 11, 2018
    Remove redundant accessors in AC test stub
  11. Use `-=` to change the update the collection on the association

    rafaelfranca committed Jun 11, 2018
    This also mark the association as loaded given we changed it in memory
    and avoid the next access to the reader to make a query to the databse.
  12. Merge pull request #29939 from arthurchui/activerecord-delete-associa…

    rafaelfranca committed Jun 11, 2018
    …tions-loop
    
    Use hash lookup for deleting existing associations from `target`
  13. Remove redundant accessors

    utilum committed Jun 11, 2018
    introduced in a0ea528.
  14. Merge pull request #32956 from Shopify/i18n_activemodel_errors_full_m…

    rafaelfranca committed Jun 11, 2018
    …essage
    
    Allow to override the full_message error format
  15. Merge pull request #33093 from rails/use-rack-to-dump-query

    tenderlove committed Jun 11, 2018
    Use Rack to generate query information under test
Commits on Jun 10, 2018
  1. Fix alias confliction when joining same table on has many through wit…

    kamipo committed Jun 10, 2018
    …h left_joins
    
    This regression was caused by #30995 due to `Hash#fetch` won't invoke
    default proc. Just revert the change since #30995 is completely fixed by
    e9c1653.
    
    Fixes #33048.
  2. ✂️

    kamipo committed Jun 10, 2018
    [ci skip]
  3. Update `config.active_storage.variable_content_types` default value i…

    y-yagi committed Jun 10, 2018
    …n guides [ci skip]
    
    Follow up of 3915a47.
Commits on Jun 9, 2018
  1. Use fetch for better error handling

    marcandre committed Jun 9, 2018
  2. Use same weekday correspondance as Date#wday.

    marcandre committed Jun 9, 2018
    DeepCover revealed that most of these `wday != 0 ? wday - 1 : 6`
    were not entirely covered, i.e. the case of `wday == 0` was not tested:
    https://deep-cover.github.io/rails-cover/activesupport/activesupport/lib/active_support/core_ext/date_and_time/calculations.rb.html#L351
    
    There's actually no valid reason to consider Sunday a special case,
    so this commit simply reajusts the values used for calculations.
  3. Merge pull request #33078 from bogdanvlviv/add-remove-require

    kamipo committed Jun 9, 2018
    Add/Remove `require`
  4. Avoid Node.js v10.4.0 for now

    y-yagi committed Jun 9, 2018
    If use Node.js v10.4.0, ujs's build will result in an error, so
    temporarily fix the version to v10.3.0.
    
    Ref: https://travis-ci.org/rails/rails/jobs/389960856
Commits on Jun 8, 2018
  1. Merge pull request #33087 from bogdanvlviv/document-CompareWithRange

    rafaelfranca committed Jun 8, 2018
    Add `ActiveSupport::CompareWithRange` to API docs
  2. Merge pull request #33102 from bogdanvlviv/refactor-actioncable-tests

    rafaelfranca committed Jun 8, 2018
    Refactor actioncable's tests
  3. Merge pull request #33103 from bogdanvlviv/fix-using-of-method_call_a…

    rafaelfranca committed Jun 8, 2018
    …ssertions
    
    Remove extra `include ActiveSupport::Testing::MethodCallAssertions`
  4. Merge pull request #27577 from maclover7/jm-fix-27547

    rafaelfranca committed Jun 8, 2018
    Action Cable owns database connection, not Active Record
  5. Include `ActiveSupport::Testing::MethodCallAssertions` in `railties/t…

    bogdanvlviv committed Jun 8, 2018
    …est/isolation/abstract_unit.rb`
    
    Related to #33102
  6. Remove extra `include ActiveSupport::Testing::MethodCallAssertions`

    bogdanvlviv committed Jun 8, 2018
    It includes via `require "abstract_unit"`.
  7. Include `ActiveSupport::Testing::MethodCallAssertions` to `ActionCabl…

    bogdanvlviv committed Jun 8, 2018
    …e::TestCase`
    
    Remove all `include ActiveSupport::Testing::MethodCallAssertions`
    in actioncable's tests since we can do it only in `ActionCable::TestCase`
    in order to prevent code duplication.
    We use the same approach for other modules of Rails.
  8. Inherit all actioncable's test classes from `ActionCable::TestCase`

    bogdanvlviv committed Jun 8, 2018
    We have defined `ActionCable::TestCase` in `actioncable/test/test_helper.rb`
    that we can use in order to prevent code duplication and build common
    interface for actioncable's test.
  9. Update ffmpeg -> FFmpeg, mutools|mupdf -> muPDF

    utilum committed May 28, 2018
    [ci skip]
  10. Dev-Dep guide: mention AST third party requirements

    utilum committed May 27, 2018
    Avoid the likes of:
    
    ```
    Error:
    ActiveStorage::RepresentationTest#test_representing_an_MP4_video:
    Errno::ENOENT: No such file or directory - ffmpeg
        test/models/representation_test.rb:27:in `block in <class:RepresentationTest>'
    ```
    
    Also note additiona macOS requirements in ActiveStorage guide.
    
    [ci skip]
  11. Use Rack to generate query information under test

    tenderlove committed Jun 8, 2018
    `to_query` sorts parameters before encoding them.  This causes a round
    tripping issue as noted here:
    
      #23997 (comment)
      #10529 (comment)
      #30558
    
    Unfortunately, that method is being used to generate cache keys, so its
    results need to be stable:
    
      10dec0e
    
    However, the test harness is only using `to_query` to encode parameters
    before sending them to the controller so the "cache key" usecase doesn't
    apply here.
    
    This commit adds a test that demonstrates the round trip problems and
    changes the serialization strategy to use Rack for encoding the
    parameters rather than `to_query`.
  12. Remove ineffective no-warnings flags from Contribute guide

    utilum committed Jun 8, 2018
    This is not working. [ci skip]
Commits on Jun 7, 2018
  1. Merge pull request #33089 from bogdanvlviv/refactor-attached_test.rb

    georgeclaghorn committed Jun 7, 2018
    Refactor activestorage/test/models/attached_test.rb