It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
…fined by Active Support) Selecting which key extensions to include in active_support/rails made apparent the systematic usage of Object#in? in the code base. After some discussion in 5ea6b0d we decided to remove it and use plain Ruby, which seems enough for this particular idiom. In this commit the refactor has been made case by case. Sometimes include? is the natural alternative, others a simple || is the way you actually spell the condition in your head, others a case statement seems more appropriate. I have chosen the one I liked the most in each case.
This reverts commit 3803fcc. Conflicts: activerecord/CHANGELOG.md It will be deprecated only in 4.0, and removed properly in 4.1.
This apparently fix the warning related to @new_record variable not being initialized in AR's test suit, when an association is built and the object is marshalled/loaded. See these tests in AR's base_test.rb: test_marshalling_with_associations test_marshalling_new_record_round_trip_with_associations Closes #3720.
… with strict mass assignment sanitizer, fixed build_record to not merge creation_attributes, removed failing nested attributes tests (that feature was broken anyway) #4051
…r object. Fixes a regression from 3.0.x
…cause Module#delegate previously ignored method visibility.
…erformance gain for cases where the association is never used to load the target, for example with preloading. Related: #1873.
… before_initialize callback of the record runs. Fixes #1842.
…the owner has been saved. Fixes #1524.
… access the owner from the associated record
After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`.
There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using .include?.
…neric AssociationScope class which is capable of building a scope for any association.
…he identity map is turned off