Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Nov 21, 2012
  1. @tuzz

    Typo

    tuzz authored
  2. @rafaelfranca

    Merge pull request #6245 from bogdan/bc_timestamp

    rafaelfranca authored
    Postgresql adapter: fix handling of BC timestamps
  3. @semaperepelitsa
  4. @bogdan
Commits on Nov 20, 2012
  1. @pwnall
Commits on Nov 19, 2012
  1. @carlosantoniodasilva
  2. @CvX

    Add rename_index to change_table.

    CvX authored
Commits on Nov 18, 2012
  1. @carlosantoniodasilva
Commits on Nov 9, 2012
  1. @jonleighton

    Properly deprecate ConnectionHandler#connection_pools

    jonleighton authored
    Rather than just changing it and hoping for the best.
    
    Requested by @jeremy:
    
    ba1544d#commitcomment-2106059
Commits on Nov 3, 2012
  1. @rafaelfranca
Commits on Nov 2, 2012
  1. @rafaelfranca

    Remove old comment

    rafaelfranca authored
    This comment is not valid since that `if` is there to make possible to
    do:
    
        remove_index :users, :name
    
    Instead of:
    
        remove_index :users, column: :name
    
    What is a valid use case.
    
    [ci skip]
  2. @rafaelfranca

    Deprecate passing a string as third argument of `add_index`

    rafaelfranca authored
    This was there due historical reasons since
    7dc4581 to give the user the
    possibility to create unique indexes passing "UNIQUE" as the third
    argument
  3. @rafaelfranca
  4. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	actionpack/lib/action_controller/metal/mime_responds.rb
    	activerecord/lib/active_record/attribute_methods.rb
    	guides/source/working_with_javascript_in_rails.md
Commits on Oct 30, 2012
  1. @gazay
  2. @rafaelfranca

    Fix bug when Column is trying to type cast boolean values to integer.

    rafaelfranca authored
    This can occur if the user is using :integer columns to store boolean
    values. Now we are handling the boolean values but it still raises if
    the value can't type cast to integer and is not a boolean. See #7509.
    
    Fixes #8067.
    
    Conflicts:
    	activerecord/CHANGELOG.md
Commits on Oct 29, 2012
  1. @nikitug

    Provide a call stack for deprecation warnings where needed.

    nikitug authored
    It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
Commits on Oct 28, 2012
  1. @frodsan

    SQLite3Adapter#type_cast should not mutate arguments

    Stefan Rusterholz authored frodsan committed
  2. @senny
  3. @senny
Commits on Oct 27, 2012
  1. @pwnall
Commits on Oct 26, 2012
  1. @veader

    Decode attributes pulled from URI.parse

    veader authored
    The RFC indicates that username and passwords may be encoded.
    http://tools.ietf.org/html/rfc2396#section-3.2.2
    
    Found this trying to use the mysql://username:password@host:port/db and having special characters in the password which needed to be URI encoded.
  2. @jonleighton

    Remove ActiveRecord::Model

    jonleighton authored
    In the end I think the pain of implementing this seamlessly was not
    worth the gain provided.
    
    The intention was that it would allow plain ruby objects that might not
    live in your main application to be subclassed and have persistence
    mixed in. But I've decided that the benefit of doing that is not worth
    the amount of complexity that the implementation introduced.
Commits on Oct 23, 2012
  1. @AvnerCohen
Commits on Oct 19, 2012
  1. @jonleighton

    The default value of a text/blob in mysql strict mode should be nil

    jonleighton authored
    In non-strict mode it is '', but if someone is in strict mode then we
    should honour the strict semantics.
    
    Also, this removes the need for a completely horrible hack in dirty.rb.
    
    Closes #7780
Commits on Oct 14, 2012
  1. @IPGlider
  2. @arturopie

    #7914 Remove code for unsupported postgreSQL version.

    arturopie authored
    Remove parsing of character type default values for 8.1 formatting since
    Rails doesn't support postgreSQL 8.1 anymore.
    
    Remove misleading comment unrelated to code.
  3. @arturopie

    #7914 Using a better way to get the defaults from db.

    arturopie authored
    According to postgreSQL documentation:
    (http://www.postgresql.org/docs/8.2/static/catalog-pg-attrdef.html)
    we should not be using 'adsrc' field because this field is unaware of
    outside changes that could affect the way that default values are
    represented. Thus, I changed the queries to use
    "pg_get_expr(adbin, adrelid)" instead of the historical "adsrc" field.
Commits on Oct 13, 2012
  1. @arturopie

    #7914 get default value when type uses schema name

    arturopie authored arturopie committed
    PostgreSQL adapter properly parses default values when using multiple
    schemas and domains.
    
    When using domains across schemas, PostgresSQL prefixes the type of the
    default value with the name of the schema where that type (or domain) is.
    
    For example, this query:
    ```
    SELECT a.attname, d.adsrc
    FROM pg_attribute a LEFT JOIN pg_attrdef d
    ON a.attrelid = d.adrelid AND a.attnum = d.adnum
    WHERE a.attrelid = "defaults"'::regclass
    AND a.attnum > 0 AND NOT a.attisdropped
    ORDER BY a.attnum;
    ```
    
    could return something like "'<default_value>'::pg_catalog.text" or
    "(''<default_value>'::pg_catalog.text)::text" for the text columns with
    defaults.
    
    I modified the regexp used to parse this value so that it ignores
    anything between ':: and \b(?:character varying|bpchar|text), and it
    allows to have optional parens like in the above second example.
Commits on Oct 10, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	activerecord/lib/active_record/persistence.rb
    	railties/lib/rails/generators/rails/resource_route/resource_route_generator.rb
Commits on Oct 9, 2012
  1. @AvnerCohen

    Fixed unclosing tag

    AvnerCohen authored
Commits on Oct 5, 2012
  1. @senny
Commits on Sep 28, 2012
  1. @jonleighton

    Support for partial inserts.

    jonleighton authored
    When inserting new records, only the fields which have been changed
    from the defaults will actually be included in the INSERT statement.
    The other fields will be populated by the database.
    
    This is more efficient, and also means that it will be safe to
    remove database columns without getting subsequent errors in running
    app processes (so long as the code in those processes doesn't
    contain any references to the removed column).
Commits on Sep 21, 2012
  1. @jonleighton

    Support for specifying transaction isolation level

    jonleighton authored
    If your database supports setting the isolation level for a transaction,
    you can set it like so:
    
      Post.transaction(isolation: :serializable) do
        # ...
      end
    
    Valid isolation levels are:
    
    * `:read_uncommitted`
    * `:read_committed`
    * `:repeatable_read`
    * `:serializable`
    
    You should consult the documentation for your database to understand the
    semantics of these different levels:
    
    * http://www.postgresql.org/docs/9.1/static/transaction-iso.html
    * https://dev.mysql.com/doc/refman/5.0/en/set-transaction.html
    
    An `ActiveRecord::TransactionIsolationError` will be raised if:
    
    * The adapter does not support setting the isolation level
    * You are joining an existing open transaction
    * You are creating a nested (savepoint) transaction
    
    The mysql, mysql2 and postgresql adapters support setting the
    transaction isolation level. However, support is disabled for mysql
    versions below 5, because they are affected by a bug
    (http://bugs.mysql.com/bug.php?id=39170) which means the isolation level
    gets persisted outside the transaction.
Commits on Sep 20, 2012
  1. @frodsan
Something went wrong with that request. Please try again.