Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Dec 5, 2012
  1. @claudiob

    Replace comments' non-breaking spaces with spaces

    claudiob authored
    Sometimes, on Mac OS X, programmers accidentally press Option+Space
    rather than just Space and don’t see the difference. The problem is
    that Option+Space writes a non-breaking space (0XA0) rather than a
    normal space (0x20).
    
    This commit removes all the non-breaking spaces inadvertently
    introduced in the comments of the code.
Commits on Dec 1, 2012
  1. @rmascarenhas

    Reset attributes should not report changes.

    rmascarenhas authored
    When resetting an attribute, you expect it to return to the state it was
    before any changes. Namely, this fixes this unexpected behavior:
    
    ~~~ruby
    model.name = "Bob"
    model.reset_name!
    model.name_changed? #=> true
    ~~~
Commits on Nov 29, 2012
  1. @rafaelfranca

    Remove observers and sweepers

    rafaelfranca authored
    They was extracted from a plugin.
    
    See https://github.com/rails/rails-observers
    
    [Rafael Mendonça França + Steve Klabnik]
Commits on Nov 28, 2012
  1. @steveklabnik

    Specify type of singular association during serialization

    steveklabnik authored
    When serialising a class, specify the type of any singular associations, if
    necessary. Rails already correctly specifies the :type of any enumerable
    association (e.g. a has_many association), but made no attempt to do so for
    non-enumerables (e.g. a has_one association).
    We must specify the :type of any STI association. A has_one
    association to a class which uses single-table inheritance is an example of
    this type of association.
    
    Fixes #7471
Commits on Nov 26, 2012
  1. @rafaelfranca

    Merge pull request #7282 from xHire/validates_length_of_fix

    rafaelfranca authored
    Length validation handles correctly nil. Fix #7180
    
    Conflicts:
    	activemodel/CHANGELOG.md
  2. @xHire

    Length validation handles correctly nil. Fix #7180

    xHire authored
    When nil or empty string are not allowed, they are not valid.
Commits on Nov 25, 2012
  1. @senny
  2. @senny
Commits on Nov 18, 2012
  1. @saulius
Commits on Nov 17, 2012
  1. @carlosantoniodasilva
Commits on Nov 16, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	actionpack/lib/action_dispatch/routing/redirection.rb
Commits on Nov 14, 2012
  1. @trevorturk
Commits on Nov 13, 2012
  1. @danielvlopes
Commits on Nov 9, 2012
  1. @tenderlove

    rm dead code

    tenderlove authored
Commits on Nov 5, 2012
  1. @nashby

    use Array() instead flatten

    nashby authored
    * move ActiveModel::Errors tests to errors_test.rb
    * add spec coverage for add_on_empty and add_on_blank
Commits on Nov 4, 2012
  1. @carlosantoniodasilva

    Raise ArgumentError when no attribute is given to AMo::EachValidator

    carlosantoniodasilva authored
    ArgumentError is better suited than RuntimeError for this.
  2. @carlosantoniodasilva
Commits on Nov 2, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	actionpack/lib/action_controller/metal/mime_responds.rb
    	activerecord/lib/active_record/attribute_methods.rb
    	guides/source/working_with_javascript_in_rails.md
Commits on Oct 30, 2012
  1. @gazay
Commits on Oct 29, 2012
  1. @nikitug

    Provide a call stack for deprecation warnings where needed.

    nikitug authored
    It's sometimes hard to quickly find where deprecated call was performed, especially in case of migrating between Rails versions. So this is an attempt to improve the call stack part of the warning message by providing caller explicitly.
Commits on Oct 27, 2012
  1. fix AM::Serializers titles [ci skip]

    Francesco Rodriguez authored
  2. AM::Serializers::Xml depends on AM::Naming

    Francesco Rodriguez authored
Commits on Oct 26, 2012
Commits on Oct 22, 2012
  1. fix output messages - docs [ci skip]

    Francesco Rodriguez authored
  2. @AvnerCohen
Commits on Oct 21, 2012
  1. @vijaydev

    Merge branch 'master' of github.com:lifo/docrails

    vijaydev authored
    Conflicts:
    	activesupport/lib/active_support/core_ext/hash/slice.rb
    	guides/source/active_support_core_extensions.md
  2. minor edits in AM documentation [ci skip]

    Francesco Rodriguez authored
Commits on Oct 18, 2012
  1. remove non-breaking spaces [ci skip]

    Francesco Rodriguez authored
  2. @senny
  3. @senny
Commits on Oct 3, 2012
  1. @rafaelfranca

    Use the `flat_map` method.

    rafaelfranca authored
    Thanks to @jeremy to teach me this one.
  2. @rafaelfranca

    Revert "Merge pull request #7826 from sikachu/master-validators-kind"

    rafaelfranca authored
    This reverts commit 4e9f53f, reversing
    changes made to 6b802cd.
    
    Revert "Don't use tap in this case."
    
    This reverts commit 454d820.
    
    Reason: Is not a good idea to add options to this method since we can do
    the same thing using method composition.
    
        Person.validators_on(:name).select { |v| v.kind == :presence }
    
    Also it avoids to change the method again to add more options.
  3. @rafaelfranca

    Don't use tap in this case.

    rafaelfranca authored
    The use of tap in this case is very confusing since we are mutating the
    return value inside the block
  4. @sikachu

    Make `.validators_on` accept `:kind` option

    sikachu authored
    This will filter out the validators on a particular attribute based on
    its kind.
Something went wrong with that request. Please try again.