Skip to content
Commits on May 11, 2008
  1. @dhh

    Updated copyright years

    dhh committed
  2. @dhh

    Making ready for RC1 release

    dhh committed
  3. @mschuerig @NZKoz

    Added not to sanitize helper docs that it doesn't guarantee well-form…

    mschuerig committed with NZKoz
    …ed markup.
    Signed-off-by: Michael Koziarski <>
    [#166 state:resolved]
  4. @pjones @dhh

    Bug: Earlier Check for Session in Forgery Protection

    pjones committed with dhh
    The session is used by the form_authenticity_token method before it is
    tested to be valid.  This patch moves a few lines around so that the
    session is validated first.
    Without this patch, if you try to use forgery protection with sessions
    turned off, you get this exception message:
      undefined method `session_id' for {}:Hash
    The patch includes a test that can be used to see this behavior before
    the request_forgery_protection.rb file is patched to fix it.
  5. @dhh

    Added session(:on) to turn session management back on in a controller…

    dhh committed
    … subclass if the superclass turned it off (Peter Jones) [#136 state:resolved]
  6. @zargony @NZKoz

    Fixed not being accessible in tests. Flash sweeping is now …

    zargony committed with NZKoz
    …done before action processing instead after
    Signed-off-by: Michael Koziarski <>
    [#10 state:resolved]
Commits on May 10, 2008
  1. @ncr @lifo

    Make render shorthands work with namespaced controllers

    ncr committed with lifo
    Signed-off-by: Pratik Naik <>
  2. @NZKoz

    Escape globbed parameters in routes correctly.

    Chris Roos committed with NZKoz
    :controller => 'glob', :action=> 'show', :additional => ['foo/bar', 'baz']
    Should generate /glob/show/foo%2Fbar/baz not  /glob/show/foo/bar/baz
Commits on May 9, 2008
  1. @lifo

    Merge docrails:

    lifo committed
    commit e6afd8b
    Author: Xavier Noria <>
    Date:   Thu May 8 23:49:36 2008 +0200
        Overall documentation improvement and markup corrections. Zillion changes.
    commit 2fead68
    Author: Austin Putman <austin@emmanuel.local>
    Date:   Wed May 7 19:35:46 2008 -0700
        Documented class methods on ActionController::Routing.  These are dangerous, and mostly used for testing.
    commit f5b8418
    Author: Teflon Ted <>
    Date:   Wed May 7 16:08:49 2008 -0400
        Added explanation about errant inflections not being patched in the future in order to avoid breaking legacy applications.
    commit 370f4f5
    Author: Sunny Ripert <>
    Date:   Wed May 7 14:00:59 2008 +0200
        Applied list conventions in AR::Base
    commit 5bd1842
    Author: Sunny Ripert <>
    Date:   Wed May 7 13:53:35 2008 +0200
        Renamed Options list to Attributes list whenever they weren't option hashes in AR::Base
    commit d912bd5
    Author: Yaroslav Markin <>
    Date:   Wed May 7 13:50:28 2008 +0400
        Add a filter_parameter_logging usage hint to generated ApplicationController.
        This may help to remind the developer to filter sensitive information from application logs.
        Closes #11578
    commit b243de0
    Author: Jack Danger Canty <>
    Date:   Tue May 6 23:39:47 2008 -0700
        doc: disambiguating an example ActiveRecord class
    commit f81d771
    Author: Jack Danger Canty <>
    Date:   Tue May 6 23:35:05 2008 -0700
        doc: ActiveRecord::Reflection::AssociationReflection#through_reflection
        Added documentation demonstrating the use of #through_reflection for
        finding intervening reflection objects for HasManyThrough
        and HasOneThrough.
    commit ae6b46f
    Author: Cheah Chu Yeow <>
    Date:   Wed May 7 13:47:41 2008 +0800
        Document AttributeAssignmentError and MultiparameterAssignmentErrors.
    commit 8f46355
    Author: John Barnette <>
    Date:   Tue May 6 22:46:44 2008 -0700
        Killing/fixing a bunch of outdated language in the AR README.
    commit aca44bc
    Author: Cheah Chu Yeow <>
    Date:   Wed May 7 13:34:52 2008 +0800
        Make a note about ActiveResource::Timeouterror being raised when ARes calls timeout.
    commit 284a930
    Author: Jonathan Dance <>
    Date:   Tue May 6 14:58:26 2008 -0400
        improvements to the page caching docs
    commit 9482da6
    Author: Sunny Ripert <>
    Date:   Mon May 5 18:13:40 2008 +0200
        validates_numericality_of() "integer" option really is "only_integer"
    commit e9afd67
    Author: Sunny Ripert <>
    Date:   Mon May 5 12:11:59 2008 +0200
        Harmonized hash notation in AR::Base
    commit 67ebf14
    Author: Sunny Ripert <>
    Date:   Mon May 5 12:06:19 2008 +0200
        Turned options into rdoc-lists in AR::Base
    commit 0ec7c0a
    Author: Marshall Huss <mwhuss@Macbook.local>
    Date:   Sun May 4 23:21:33 2008 -0400
        Added information of how to set element_name in the case the user has a name confliction with an existing model
    Signed-off-by: Pratik Naik <>
  2. @gbuesing

    ActionView::InstanceTag#default_time_from_options with hash args uses…

    gbuesing committed
    … Time.current as default; respects hash settings when time falls in system local spring DST gap
  3. @gbuesing

    Adding Date.current, which returns if config.time_zon…

    gbuesing committed
    …e is set; otherwise returns ActionView date_helper uses Date.current to determine locale-appropriate default
Commits on May 6, 2008
  1. @lifo
  2. @NZKoz

    Refactored and fixed Resources.map_member_actions to make use of cust…

    Marcos Arias committed with NZKoz
    …om ActionController::Base.resources_path_names when the option :path_names is not directly specified. Added a specific test for this functionality and fixed assert_restful_routes_for test helper to make use of ActionController::Base.resources_path_names instead of just "new" or "edit".
    Signed-off-by: Michael Koziarski <>
    [#111 state:resolved]
  3. @avit
  4. @chuyeow

    Allow ActionController::Base#default_url_options to have a default op…

    chuyeow committed with rick
    …tions argument of nil.
    This fixes a bug introduced in [6a6b439] which was breaking routing in ActionController::UrlWriter.
Commits on May 4, 2008
  1. @chuyeow @NZKoz

    Ensure that default_url_options, if defined, are used in named routes.

    chuyeow committed with NZKoz
    Signed-off-by: Michael Koziarski <>
    [#22 state:resolved]
Commits on May 2, 2008
  1. @fxn @lifo

    Improve documentation coverage and markup

    fxn committed with lifo
    Signed-off-by: Pratik Naik <>
  2. @lifo

    Improve PartialTemplate tests

    lifo committed
  3. @nex3 @lifo

    Capture view errors in ActionView::Template.

    nex3 committed with lifo
    This means that errors raised by partials are caught by ActionView::PartialTemplate,
    which in turn means they have the proper filename and line number information.
    Signed-off-by: Pratik Naik <>
Commits on May 1, 2008
  1. @dhh

    Fixed that TextHelper#text_field would corrypt when raw HTML was used…

    dhh committed
    … as the value (mchenryc, Kevin Glowacz) [#80 state:resolved]
  2. @dhh
  3. @dhh

    Made the location of the routes file configurable with config.routes_…

    dhh committed
    …configuration_file (Scott Fleckenstein) [#88 state:resolved]
  4. @tobi
  5. @lifo
Commits on Apr 30, 2008
  1. @kjg @josh

    Fixed labels that have a bracketed name and an index [#68 state:resol…

    kjg committed with josh
    Signed-off-by: Joshua Peek <>
  2. @josh
  3. @dhh
  4. @dhh
Commits on Apr 29, 2008
  1. @jeremy
Commits on Apr 28, 2008
  1. @jeremy

    Ruby 1.9 compat: force assert_select text encoding to the encoding of…

    jeremy committed
    … the regexp it's matching against.
  2. Fixed that BenchmarkHelper should use controller.logger instead of @l…

    David Heinemeier Hansson committed
    …ogger (which now apparently is gone)
  3. Added ActionController::TestCase#rescue_action_in_public! to control …

    David Heinemeier Hansson committed
    …whether the action under test should use the regular rescue_action path instead of simply raising the exception inline (great for error testing) [DHH]
Commits on Apr 27, 2008
  1. Changing "and" to && whereever I catch it

    David Heinemeier Hansson committed
Commits on Apr 24, 2008
  1. @lifo
Commits on Apr 23, 2008
  1. @NZKoz

    Make sure member names aren't mistakenly set to nil when providing :p…

    Eugene Pimenov committed with NZKoz
    [#19 state:resolved]
    Signed-off-by: Michael Koziarski <>
Something went wrong with that request. Please try again.