Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on May 11, 2008
  1. Peter J. Jones David Heinemeier Hansson

    Bug: Earlier Check for Session in Forgery Protection

    pjones authored dhh committed
    The session is used by the form_authenticity_token method before it is
    tested to be valid.  This patch moves a few lines around so that the
    session is validated first.
    Without this patch, if you try to use forgery protection with sessions
    turned off, you get this exception message:
      undefined method `session_id' for {}:Hash
    The patch includes a test that can be used to see this behavior before
    the request_forgery_protection.rb file is patched to fix it.
  2. David Heinemeier Hansson

    Added session(:on) to turn session management back on in a controller…

    dhh authored
    … subclass if the superclass turned it off (Peter Jones) [#136 state:resolved]
  3. Andreas Neuhaus Michael Koziarski

    Fixed not being accessible in tests. Flash sweeping is now …

    zargony authored NZKoz committed
    …done before action processing instead after
    Signed-off-by: Michael Koziarski <>
    [#10 state:resolved]
Commits on May 10, 2008
  1. Jacek Becela Pratik

    Make render shorthands work with namespaced controllers

    ncr authored lifo committed
    Signed-off-by: Pratik Naik <>
  2. Michael Koziarski

    Escape globbed parameters in routes correctly.

    Chris Roos authored NZKoz committed
    :controller => 'glob', :action=> 'show', :additional => ['foo/bar', 'baz']
    Should generate /glob/show/foo%2Fbar/baz not  /glob/show/foo/bar/baz
Commits on May 9, 2008
  1. Pratik

    Merge docrails:

    lifo authored
    commit e6afd8b
    Author: Xavier Noria <>
    Date:   Thu May 8 23:49:36 2008 +0200
        Overall documentation improvement and markup corrections. Zillion changes.
    commit 2fead68
    Author: Austin Putman <austin@emmanuel.local>
    Date:   Wed May 7 19:35:46 2008 -0700
        Documented class methods on ActionController::Routing.  These are dangerous, and mostly used for testing.
    commit f5b8418
    Author: Teflon Ted <>
    Date:   Wed May 7 16:08:49 2008 -0400
        Added explanation about errant inflections not being patched in the future in order to avoid breaking legacy applications.
    commit 370f4f5
    Author: Sunny Ripert <>
    Date:   Wed May 7 14:00:59 2008 +0200
        Applied list conventions in AR::Base
    commit 5bd1842
    Author: Sunny Ripert <>
    Date:   Wed May 7 13:53:35 2008 +0200
        Renamed Options list to Attributes list whenever they weren't option hashes in AR::Base
    commit d912bd5
    Author: Yaroslav Markin <>
    Date:   Wed May 7 13:50:28 2008 +0400
        Add a filter_parameter_logging usage hint to generated ApplicationController.
        This may help to remind the developer to filter sensitive information from application logs.
        Closes #11578
    commit b243de0
    Author: Jack Danger Canty <>
    Date:   Tue May 6 23:39:47 2008 -0700
        doc: disambiguating an example ActiveRecord class
    commit f81d771
    Author: Jack Danger Canty <>
    Date:   Tue May 6 23:35:05 2008 -0700
        doc: ActiveRecord::Reflection::AssociationReflection#through_reflection
        Added documentation demonstrating the use of #through_reflection for
        finding intervening reflection objects for HasManyThrough
        and HasOneThrough.
    commit ae6b46f
    Author: Cheah Chu Yeow <>
    Date:   Wed May 7 13:47:41 2008 +0800
        Document AttributeAssignmentError and MultiparameterAssignmentErrors.
    commit 8f46355
    Author: John Barnette <>
    Date:   Tue May 6 22:46:44 2008 -0700
        Killing/fixing a bunch of outdated language in the AR README.
    commit aca44bc
    Author: Cheah Chu Yeow <>
    Date:   Wed May 7 13:34:52 2008 +0800
        Make a note about ActiveResource::Timeouterror being raised when ARes calls timeout.
    commit 284a930
    Author: Jonathan Dance <>
    Date:   Tue May 6 14:58:26 2008 -0400
        improvements to the page caching docs
    commit 9482da6
    Author: Sunny Ripert <>
    Date:   Mon May 5 18:13:40 2008 +0200
        validates_numericality_of() "integer" option really is "only_integer"
    commit e9afd67
    Author: Sunny Ripert <>
    Date:   Mon May 5 12:11:59 2008 +0200
        Harmonized hash notation in AR::Base
    commit 67ebf14
    Author: Sunny Ripert <>
    Date:   Mon May 5 12:06:19 2008 +0200
        Turned options into rdoc-lists in AR::Base
    commit 0ec7c0a
    Author: Marshall Huss <mwhuss@Macbook.local>
    Date:   Sun May 4 23:21:33 2008 -0400
        Added information of how to set element_name in the case the user has a name confliction with an existing model
    Signed-off-by: Pratik Naik <>
Commits on May 6, 2008
  1. Michael Koziarski

    Refactored and fixed Resources.map_member_actions to make use of cust…

    Marcos Arias authored NZKoz committed
    …om ActionController::Base.resources_path_names when the option :path_names is not directly specified. Added a specific test for this functionality and fixed assert_restful_routes_for test helper to make use of ActionController::Base.resources_path_names instead of just "new" or "edit".
    Signed-off-by: Michael Koziarski <>
    [#111 state:resolved]
  2. Cheah Chu Yeow

    Allow ActionController::Base#default_url_options to have a default op…

    chuyeow authored rick committed
    …tions argument of nil.
    This fixes a bug introduced in [6a6b439] which was breaking routing in ActionController::UrlWriter.
Commits on May 4, 2008
  1. Cheah Chu Yeow Michael Koziarski

    Ensure that default_url_options, if defined, are used in named routes.

    chuyeow authored NZKoz committed
    Signed-off-by: Michael Koziarski <>
    [#22 state:resolved]
Commits on May 2, 2008
  1. Xavier Noria Pratik

    Improve documentation coverage and markup

    fxn authored lifo committed
    Signed-off-by: Pratik Naik <>
Commits on May 1, 2008
  1. David Heinemeier Hansson
  2. David Heinemeier Hansson

    Made the location of the routes file configurable with config.routes_…

    dhh authored
    …configuration_file (Scott Fleckenstein) [#88 state:resolved]
  3. Tobias Lütke
Commits on Apr 29, 2008
  1. Jeremy Kemper
Commits on Apr 28, 2008
  1. Jeremy Kemper

    Ruby 1.9 compat: force assert_select text encoding to the encoding of…

    jeremy authored
    … the regexp it's matching against.
  2. Added ActionController::TestCase#rescue_action_in_public! to control …

    David Heinemeier Hansson authored
    …whether the action under test should use the regular rescue_action path instead of simply raising the exception inline (great for error testing) [DHH]
Commits on Apr 27, 2008
  1. Changing "and" to && whereever I catch it

    David Heinemeier Hansson authored
Commits on Apr 23, 2008
  1. Michael Koziarski

    Make sure member names aren't mistakenly set to nil when providing :p…

    Eugene Pimenov authored NZKoz committed
    [#19 state:resolved]
    Signed-off-by: Michael Koziarski <>
Commits on Apr 21, 2008
  1. Pratik

    Delegate ivars to controller instead of copying

    lifo authored
    Reduce number of instance variables being copied from controller to
    view. Instead, delegate them to controller instance.
  2. Pratik

    Remove ActionController::Base#view_controller_internals

    lifo authored
    Get rid of ActionController::Base#view_controller_internals flag and
    use @@protected_view_variables for storing the list of controller
    specific instance variables which should be inaccessible inside views.
  3. Pratik
Commits on Apr 19, 2008
  1. Paul Horsfall Joshua Peek

    Add conditional options to caches_page method [#25 state:resolved]

    phorsfall authored josh committed
    Signed-off-by: Joshua Peek <>
  2. Pratik
  3. Pratik
  4. Pratik
Commits on Apr 18, 2008
  1. Pratik

    Refactor Dispatcher callbacks to remove unnecessary Dependencies chec…

    lifo authored
    …ks in production environment.
  2. Joshua Peek
Commits on Apr 13, 2008
  1. David Heinemeier Hansson

    Added Rails.public_path to control where HTML and assets are expected…

    dhh authored
    … to be loaded from (defaults to Rails.root + "/public") #11581 [nicksieger]
Commits on Apr 12, 2008
  1. Michael Koziarski
  2. Michael Koziarski

    Allow alternative values for the 'new' and 'edit' actions in resource…

    NZKoz authored
    …ful routes.
    map.resource :schools, :as => 'escuelas', :path_names => { :new => 'nueva' }
    Closes #11181.  [ivanvr]
Commits on Apr 11, 2008
  1. Jeremy Kemper
  2. Fixed that formatted_polymorphic_route should be able to take the :fo…

    David Heinemeier Hansson authored
    …rmat as part of a single hash or as the option hash (references #8741)
Commits on Apr 8, 2008
  1. risk danger olson
Commits on Apr 6, 2008
  1. Joshua Peek

    Provide a helper proxy to access helper methods from outside views. C…

    josh authored
    …loses #10839 [Josh Peek]
    git-svn-id: 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Commits on Apr 5, 2008
  1. Pratik

    Improve documentation.

    lifo authored
    git-svn-id: 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
Something went wrong with that request. Please try again.