Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Tag: v2.3.3.1
Commits on Jun 10, 2009
  1. @jeremy
  2. @NZKoz

    Whitelist the methods which are called by multiparameter attribute as…

    NZKoz authored
    This prevents users from causing NoMethodErrors and the like by editing the parameter names, and closes a potential exploit of CVE-2009-1904.
Commits on Jun 9, 2009
  1. @al2o3cr @NZKoz

    Fix incorrect specification path in GemDependency#from_directory_name

    al2o3cr authored NZKoz committed
    Signed-off-by: Michael Koziarski <>
  2. @NZKoz

    Sanitized the id generated by text_area_tag helper method. text_area_…

    Stephen Anderson authored NZKoz committed
    …tag('item[description]') should return: <textarea id="item_description" name="item[description]"></textarea> instead of: <textarea id="item[description]" name="item[description]"></textarea> The old id was causing HTML validation failures.
    Signed-off-by: Michael Koziarski <>
  3. @dsboulder @NZKoz

    Made label target radio button tags with values. Radio button now res…

    dsboulder authored NZKoz committed
    …pects inherited :index options when generating id.
    Signed-off-by: Michael Koziarski <>
  4. @NZKoz

    1.9 compatibility - don't pass an array as the from address as this e…

    Friedrich Göpel authored NZKoz committed
    …nds up generating invalid SMTP commands.
  5. @steveluscher @NZKoz

    Fixes #2439. ActionController::Integration::Session no longer mangles…

    steveluscher authored NZKoz committed
    … multiparameter attribute params when processing multipart requests.
    Signed-off-by: Michael Koziarski <>
  6. @libc @NZKoz

    PostgreSQL adapter should call thread safe quote_string function

    libc authored NZKoz committed
    Signed-off-by: Michael Koziarski <>
  7. @tomafro @NZKoz

    Change autoload declaration in ActionView::Helpers from JavascriptHel…

    tomafro authored NZKoz committed
    …per to JavascriptHelper, matching the actual helper name. Also removed require from UrlHelper which was inadvertently preventing the autoload typo from causing a failure.
    Signed-off-by: Michael Koziarski <>
  8. @NZKoz

    Revert "Ensure HasManyThroughAssociation#destroy delete orphan records"

    NZKoz authored
    This reverts commit 7a85927.
    There's still some debate about the intended behaviour in the ticket, leaving in master but removing prior to shipping 2.3.3
  9. @al2o3cr @NZKoz

    Fix several issues with the 2.3.2 gem loader.

    al2o3cr authored NZKoz committed
    Incorporates the following:
    - migrates back small change to gems:build:force from bfc1609 to finish closing #2266.
    - unrolls to_proc calls in gems.rake, to match the change in master.
    - fixes #2722 by passing the options hash to dependencies during build. (includes a test)
    - fixes #2721 by loading the specification directly in from_directory_name. Adds an option to opt-out of specification loading when needed (in gems:refresh_specs, for instance). Includes tests.
    - fixes #2679 by refreshing specs for all frozen gems rather than just gems loaded from the environment.
    - fixes #2678 by passing the options hash to dependencies during unpack.
    Signed-off-by: Michael Koziarski <>
  10. @NZKoz

    A test to show that http_authentication needs to fail authentication …

    nate authored NZKoz committed
    …if the password procedure returns nil. Also includes a fix to validate_digest_response to fail validation if the password procedure returns nil.
    Signed-off-by: Michael Koziarski <>
  11. @lifo @jeremy
  12. @jeremy
  13. @jeremy

    Fix AR json encoding

    jeremy authored
  14. @jeremy
  15. @jeremy
  16. @jeremy
  17. @jeremy
  18. @jeremy
  19. @jeremy
  20. @jeremy
  21. @jeremy
  22. @jeremy
Commits on Jun 8, 2009
  1. @jeremy

    Ruby 1.9: fix json encoding

    jeremy authored
  2. @jeremy
  3. @jeremy
  4. @jeremy
  5. @jeremy

    Don't rely on Rails.logger

    jeremy authored
Commits on Jun 6, 2009
  1. @timocratic @jeremy

    Work around a gem dependency edge case that prevents Rails from booti…

    timocratic authored jeremy committed
    If you have a frozen gem with unfrozen dependencies (for instance if the
    dependency has native extensions so can't be frozen) you can have a
    nightmare upgrade problem, where you cannot rake gems:install, because
    rake is broken by a gem loading problem.
    If you bump up your frozen gem to a newer version that requires a newer
    dependency, everybody else on the team will have rake broken by that
    dependency mismatch, since you will have had to specify the dependency
    in your config.gems, otherwise nobody will have installed it, since the
    parent is frozen. And now the config.gems loading code will kill rake.
    [#2609 state:committed]
    Signed-off-by: Jeremy Kemper <>
Commits on Jun 1, 2009
  1. @NZKoz
  2. @han @NZKoz

    fix for IE incompatibility of :disable_with in submit_tag

    han authored NZKoz committed
    Signed-off-by: Michael Koziarski <>
  3. @ianterrell @NZKoz

    added a failing test case for counting has_many :through associations…

    ianterrell authored NZKoz committed
    … with scopes
    Signed-off-by: Michael Koziarski <>
  4. @NZKoz

    Revert "Ensure calculations respect scoped :select". Broke .count on …

    NZKoz authored
    …a has_many :through association.
    This reverts commit 6543426.
Commits on May 30, 2009
  1. @josh

    Revert "Only save the session if we're actually writing to it [#2703

    josh authored
    This reverts commit 14edaa1.
Something went wrong with that request. Please try again.