Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Nov 25, 2009
  1. @NZKoz

    Prepare for the 2.3.5 release

    NZKoz authored
Commits on Nov 18, 2009
  1. @gtd @jeremy

    Insert generated association members in the same order they are speci…

    gtd authored jeremy committed
    …fied when assigning to a has_many :through using the generated *_ids method
    
    [#3491 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Nov 17, 2009
  1. @jeremy

    Revert "Ensure Model#destroy respects optimistic locking"

    jeremy authored
    Unresolved issues with :dependent => :destroy and counter caching.
    
    [#1966 state:open]
    
    This reverts commit 0d92288.
Commits on Nov 14, 2009
  1. @jeremy

    Remove weird zombie test

    jeremy authored
Commits on Nov 13, 2009
  1. @jeremy
Commits on Nov 10, 2009
  1. @josevalim @josh

    [PATCH] Optimize Error I18n to avoid unecessary lookups and just retr…

    josevalim authored josh committed
    …ieve values when needed [#3477 status:resolved].
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
  2. @al2o3cr @NZKoz

    delete correct records for a has_many with :primary_key and :dependen…

    al2o3cr authored NZKoz committed
    …t => :delete_all
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
Commits on Nov 6, 2009
  1. @alloy

    Define autosave association callbacks when using accepts_nested_attri…

    alloy authored
    …butes_for.
    
    This way we don't define all the validation methods for all associations by
    default, but only when needed.
    
    [#3355 state:resolved]
Commits on Oct 28, 2009
  1. @josevalim @josh

    Fix nested attributes error messages which is broken in 2.3.4. It sti…

    josevalim authored josh committed
    …ll copies the message from child to parent, but does the lookup in the child, not in the parent, avoiding error messages duplication (as happened in 2.3.3). [#3147 state:resolved]
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Oct 9, 2009
  1. @lifo

    Add a :limit option to specify the maximum number of records that can…

    lifo authored
    … be processed by accepts_nested_attributes_for
    
    Conflicts:
    
    	activerecord/lib/active_record/nested_attributes.rb
  2. @lifo

    Store entire options hash in the class var rather than just the rejec…

    lifo authored
    …t_if proc for the nested attributes
    
    Conflicts:
    
    	activerecord/lib/active_record/nested_attributes.rb
    	activerecord/test/cases/nested_attributes_test.rb
Commits on Oct 7, 2009
  1. @lifo
  2. @lifo
Commits on Sep 29, 2009
  1. @thewoolleyman @wycats

    reduce max size of fixture IDs to fix sqlite2 tests, because sqlite2 …

    thewoolleyman authored wycats committed
    …was getting negative and changing values for ID field. See http://www.sqlite.org/datatypes.html
    
    Signed-off-by: Yehuda Katz <wycats@gmail.com>
Commits on Sep 28, 2009
  1. @NZKoz

    Make has_one with :conditions hash scope build or creation of the ass…

    Luciano G Panaro authored NZKoz committed
    …ociated object with those conditions
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
    [#3088 state:committed]
Commits on Sep 17, 2009
  1. @m4dc4p @jeremy

    Enable use of MySQL stored procedures by default.

    m4dc4p authored jeremy committed
    [#3204 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Sep 13, 2009
  1. @sdsykes @jeremy

    Ruby 1.9 compat: corrected instance_methods check

    sdsykes authored jeremy committed
    [#3156 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Sep 12, 2009
  1. @alloy

    Removed some superfluous conditionals from the autosave association v…

    alloy authored
    …alidation methods.
    
    Which are unneeded now that we only define them when needed.
  2. @kovyrin @alloy

    Define autosave association validation methods only when needed. [#3161

    kovyrin authored alloy committed
    … state:resolved]
    
    Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
  3. @alloy
  4. @alloy
  5. @gbp @alloy

    Fix has_one with foreign_key and primary_key association bug which ca…

    gbp authored alloy committed
    …used the associated object being lost when saving the owner. [#1756 state:resolved]
    
    Mixed in a bit from patch by ransom-briggs. [#2813 state:resolved]
    
    Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
  6. @josevalim @alloy

    Rename nested attributes _delete to _destroy to reflect its actual be…

    josevalim authored alloy committed
    …havior and DSL (:allow_destroy). Deprecation warning added. [#2889 state:resolved]
    
    Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
  7. @alloy

    Fix autosave association to skip validation if it is marked for destr…

    Dmitry Polushkin authored alloy committed
    …uction. [#2064 state:resolved]
    
    Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
  8. @alloy

    Explicitely setting `autosave => false' should override new_record au…

    alloy authored
    …tosaving. [#2214 state:resolved]
    
    Original author is Jacob.
  9. @cainlevy @alloy

    Don't cascade autosave validation to destroyed children. [#2761 state…

    cainlevy authored alloy committed
    …:resolved]
    
    Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
  10. @hardbap @alloy

    Raise an exception with friendlier error message when attempting to b…

    hardbap authored alloy committed
    …uild a polymorphic belongs_to with accepts_nested_attributes_for. [#2318 state:resolved]
    
    Signed-off-by: Eloy Duran <eloy.de.enige@gmail.com>
  11. @sdsykes @jeremy

    Fix habtm associations when using multiple databases

    sdsykes authored jeremy committed
    [#3128]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  12. @jeremy

    Deprecate "Allow frameworks to be required by their gem name"

    jeremy authored
    This has just been confusing. Better to educate than band-aid.
    
    This deprecates commit 18a2427.
    Originally from http://dev.rubyonrails.org/ticket/8845 [drnic]
  13. @amatsuda @jeremy

    Ensure validation errors to be ordered in declared order

    amatsuda authored jeremy committed
    [#2301 state:committed milestone:2.3.5]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  14. @amatsuda @jeremy

    Fix default_error_messages back to the original message

    amatsuda authored jeremy committed
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Sep 11, 2009
  1. @shugo @jeremy

    Removed the copyright notice not to show it in the result of 'ri Acti…

    shugo authored jeremy committed
    …veRecord'.
Commits on Sep 8, 2009
  1. @josevalim @josh

    Allow scope to be changed for ActiveRecord::Errors#generate_full_mess…

    josevalim authored josh committed
    …age and change deprecation message [#1687 state:resolved]
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Sep 3, 2009
  1. @NZKoz

    Prepare for 2.3.4 release

    NZKoz authored
Commits on Sep 2, 2009
  1. @jeremy

    Revert "Assert primary key does not exist in habtm when the associati…

    jeremy authored
    …on is defined, instead of doing that everytime a record is inserted."
    
    Test failures on PostgreSQL.
    
    [#3128]
    
    This reverts commit 594a281.
Something went wrong with that request. Please try again.