Skip to content
Commits on May 18, 2010
  1. @josevalim
Commits on May 17, 2010
  1. @fxn

    method rename to fix a broken test

    fxn committed
  2. @rizwanreza @fxn

    Deprecate Array#rand in favor of Array#random_element [#4555 stated:c…

    rizwanreza committed with fxn
    …ommitted]
    
    Signed-off-by: Xavier Noria <fxn@hashref.com>
  3. @josevalim
Commits on May 16, 2010
  1. @jeremy

    CI: bump rack to 1.1

    jeremy committed
  2. @rizwanreza @josevalim

    Rack dependency bumped to 1.1.0, tests passing. [#3558 state:resolved]

    rizwanreza committed with josevalim
    Signed-off-by: José Valim <jose.valim@gmail.com>
  3. @Wijnand @josevalim

    Postgresql doesn't allow to change a string type column to a binary t…

    Wijnand committed with josevalim
    …ype. Skip this test for postgresql for now.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  4. @jeffkreeftmeijer @josevalim

    Added assert_attribute_type to clean up GeneratedAttributeTest [#2377

    jeffkreeftmeijer committed with josevalim
    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  5. @matthewrudy @josevalim

    when we run rake rails:freeze:edge update the value of the "REVISION"…

    matthewrudy committed with josevalim
    … file rather than creating a new file "REVISION_ce706..." each time [#1694 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  6. @no6v @josevalim

    make fixture accessors private

    no6v committed with josevalim
    prevent to be run fixture accessor (e.g. test_foos for TestFoo model) as a test case
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  7. @neerajdotname @josevalim

    Fix broken integration test in 2.x [#4565 state:resolved]

    neerajdotname committed with josevalim
    Signed-off-by: José Valim <jose.valim@gmail.com>
  8. @jeffkreeftmeijer @josevalim

    using :time_select when the attribute type is :time in the scaffold g…

    jeffkreeftmeijer committed with josevalim
    …enerator. [#2377 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  9. @josevalim

    Don't carry default value when changing column for a binary type on M…

    Elomar França committed with josevalim
    …ySQL [#3234 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on May 15, 2010
  1. @lawrencepit @jeremy

    docs + test for each_error

    lawrencepit committed with jeremy
    [#3185 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. @jeffkreeftmeijer @jeremy

    make sure `as` is set before trying to build an #{as}_counter. [#2804

    jeffkreeftmeijer committed with jeremy
    …state:resolved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  3. @neerajdotname @jeremy

    db:drop:all throws error when database does not exist [#2997 state:re…

    neerajdotname committed with jeremy
    …solved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  4. @jeffkreeftmeijer @jeremy

    partial counters with :as [#2804 state:resolved]

    jeffkreeftmeijer committed with jeremy
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  5. @joshk @josevalim

    backported AR correction to find_each and find_in_batches to raise wh…

    joshk committed with josevalim
    …en the user uses select but does not specify the primary key
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on May 14, 2010
  1. @josevalim
Commits on May 12, 2010
  1. @spastorino @jeremy

    to_json and to_xml tests added to ActiveResource

    spastorino committed with jeremy
    [#4529 state:resolved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. @lifo
  3. @jeremy

    Drop require removed by 8e679f1

    jeremy committed
  4. @spastorino @jeremy

    type_cast_calculated_value refactor: value is never a Fixnum here. Fi…

    spastorino committed with jeremy
    …x test since SQLite returns Float.
    
    [#4514 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on May 11, 2010
  1. @josevalim
Commits on May 9, 2010
  1. @lifo
  2. @lifo

    Revert "Revert "Add index length support for MySQL [#1852 state:resol…

    lifo committed
    …ved]" (breaks the build)"
    
    This reverts commit eababa3.
Commits on May 8, 2010
  1. Revert "Add index length support for MySQL [#1852 state:resolved]" (b…

    Carl Lerche committed
    …reaks the build)
    
    This reverts commit 3616141.
  2. @spastorino
  3. @eparreno @lifo

    Add index length support for MySQL [#1852 state:resolved]

    eparreno committed with lifo
    Example:
    
      add_index(:accounts, :name, :name => 'by_name', :length => 10)
      => CREATE INDEX by_name ON accounts(name(10))
    
      add_index(:accounts, [:name, :surname], :name => 'by_name_surname', :length => {:name => 10, :surname => 15})
      => CREATE INDEX by_name_surname ON accounts(name(10), surname(15))
    
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Commits on May 7, 2010
  1. @spastorino @jeremy

    Make find_or_create and find_or_initialize work mixing explicit param…

    spastorino committed with jeremy
    …eters and a hash. ht: Marc-André Lafortune
    
    [#4457 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. @spastorino @jeremy

    simple_format should return html_safe but not escape text, that's for…

    spastorino committed with jeremy
    … rails_xss plugin [#3767 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on May 4, 2010
  1. @brianmario @jeremy

    add support for mysql2 adapter to dbconsole

    brianmario committed with jeremy
    [#4532 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. @lifo

    Use primary key in conditions, not 'id' [#4395 state:resolved]

    lifo committed
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
    
    Conflicts:
    
    	activerecord/test/cases/nested_attributes_test.rb
  3. @rubymerchant @jeremy

    AR JSON Serializer now supports custom root option.

    rubymerchant committed with jeremy
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  4. @brianmario @jeremy

    Allow pre-casted values (other than nil) to pass through from calcula…

    brianmario committed with jeremy
    …tions un-touched
    
    [#4514 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Something went wrong with that request. Please try again.