Permalink
Switch branches/tags
Commits on Jul 8, 2010
  1. fixes #2362, eager loading :through associations will join the :sour…

    Grant Ammons authored and josevalim committed Jun 28, 2010
    …ce model if there are :conditions
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  2. test that ActiveRecord `destroy` and `destroy_all` return destroyed r…

    mislav authored and jeremy committed Jul 8, 2010
    …ecords
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  3. add missing require to ActiveRecord "base_test.rb"

    mislav authored and jeremy committed Jul 8, 2010
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Jul 4, 2010
  1. Use bind instead of instance_exec cause it may be causing memory leak…

    josevalim committed Jul 4, 2010
    …s. Also, provide a simpler and sane implementation for scoped. [#5044 state:resolved]
Commits on Jul 1, 2010
  1. fisting Session::AbstractStore#clear to actually clear the session. [#…

    tenderlove authored and jeremy committed Jul 1, 2010
    …5030 state:resolved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Jun 30, 2010
  1. Don't remove scheduled destroys when loading an association.

    chewi authored and josevalim committed Jun 30, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  2. Backported patch from [#4762]

    jberkel authored and josevalim committed Jun 29, 2010
    URL fragments should not have safe characters escaped. Ref: Appendix A,
      http://tools.ietf.org/rfc/rfc3986.txt
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 29, 2010
  1. AssociationCollection#create_by_*, find_or_create_by_* work properly …

    tenderlove authored and jeremy committed Jun 29, 2010
    …now. [#1108 state:resolved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. Rewrite the clause to pluck the existing value from zones_map before …

    Leigh Caplan authored and josevalim committed Jun 28, 2010
    …performing a lookup. [#4942 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  3. Deprecate ActiveRecord::Base#class_name [#379 state:committed]

    dtrasbo authored and josevalim committed Jun 29, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  4. Only tell users that the Rails gem is missing if it's actually the ca…

    dtrasbo authored and josevalim committed Jun 29, 2010
    …se [#2901 state:committed]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  5. Fix [54a5088] where the i18n gem was wrongly updated to 0.4.1.

    sikachu authored and josevalim committed Jun 29, 2010
    I've tested and confirm that `2-3-stable` will use the vendored `i18n` gem if there's no `i18n` gem with version >= 0.4.1 installed
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 28, 2010
  1. test that unknown zones don't store mapping keys

    Leigh Caplan authored and josevalim committed Jun 28, 2010
    [#4942]
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
    Signed-off-by: José Valim <jose.valim@gmail.com>
  2. Don't store incorrect values in zones_map backport

    spastorino authored and josevalim committed Jun 28, 2010
    [#4942 state:committed]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 27, 2010
  1. Add module_eval missing file_name and line_number args

    dolzenko authored and josevalim committed May 27, 2010
    [#4712 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 26, 2010
  1. Tidy up tests in previous commit since they did not assure an Ordered…

    josevalim committed Jun 26, 2010
    …Hash is returned (the test would pass for an array and would pass by chance for hashes).
    
    [#4875 state:resolved]
  2. Add OrderedHash#invert to preserve order in ruby 1.8

    chaitanyav authored and josevalim committed Jun 26, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 25, 2010
  1. Alias ActiveSupport::OrderedHash#update to ActiveSupport::OrderedHash…

    mudge authored and jeremy committed Jun 25, 2010
    ….merge!
    
    This ensures that an OrderedHash's keys are set up appropriately when using update.
    
    [#4973 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
  2. Make sure that Rails doesn't resent session_id cookie over and over a…

    sikachu authored and josevalim committed Jun 24, 2010
    …gain if it's already there [#2485 state:resolved]
    
    This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 23, 2010
  1. deprecates load_(once_)paths in dependencies and app config in favor …

    fxn committed Jun 23, 2010
    …of autolaod_(once_)paths
  2. fixes to the tests for patch #4909

    Neeraj Singh authored and josevalim committed Jun 23, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  3. quote scoped columns in validates_uniqueness_of [#4909 state:resolved]

    kane authored and josevalim committed Jun 23, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  4. Fixes #2415 by creating a new instance of the Model when saving attr…

    harking authored and josevalim committed Jun 23, 2010
    …ibutes to that model and the associated attributes already exist. Tests included. [#2415 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  5. Fragment cache not generating the proper cache key in log

    Neeraj Singh authored and josevalim committed Jun 13, 2010
    [#4827 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  6. Fix eager loading of polymorphic has_one associations nested-included…

    maxim authored and josevalim committed Jun 1, 2010
    … under polymorphic belongs_to associations. [#3233 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  7. test for #1570

    Neeraj Singh authored and josevalim committed Jun 23, 2010
    Signed-off-by: José Valim <jose.valim@gmail.com>
  8. STI should identify itself inside named_scope

    Paweł Kondzior authored and josevalim committed Jun 23, 2010
    [#1570 state:resovled]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  9. Revert "make text_field and hidden_field omit the value attribute if …

    NZKoz committed Jun 23, 2010
    …the developer explicitly passes in :value => nil [#4839 state:reopened]"
    
    This reverts commit 52c922f
  10. make text_field and hidden_field omit the value attribute if the deve…

    NZKoz committed Jun 23, 2010
    …loper explicitly passes in :value => nil [#4839 state:resolved]
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
    
    Conflicts:
    
    	actionpack/lib/action_view/helpers/form_helper.rb
  11. remove_column should raise an ArgumentError when no columns are passed [

    zilkey authored and NZKoz committed Jun 9, 2010
    #4803 state:resolved]
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
Commits on Jun 22, 2010
  1. CI: add i18n gem

    jeremy committed Jun 22, 2010
  2. CookieStore should preserve the Set-Cookie header Array [#4743 state:…

    jstorimer authored and jeremy committed Jun 1, 2010
    …resolved]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Jun 20, 2010
  1. Change all i18n interpolations from {{...}} to %{...}

    sikachu authored and josevalim committed Jun 20, 2010
    This will silent all warning if there's a i18n version 0.4.x gem install on user's machine.
    
    [#4913 state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  2. Update bundled i18n gem to 0.4.1 to make sure every project will be w…

    sikachu authored and josevalim committed Jun 20, 2010
    …arn about using deprecated %{..} interpolation.
    
    This will also make sure that by changing {{..}} into %{..} won't break any Rails 2.3.x application, since it would load the vendored version if it's not satisfy the version requirement.
    
    Signed-off-by: José Valim <jose.valim@gmail.com>