Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Apr 13, 2010
  1. @craigw @wycats

    Fix a typo in the documentation. [#4318 state:resolved]

    craigw authored wycats committed
    Signed-off-by: wycats <wycats@gmail.com>
Commits on Apr 9, 2010
  1. @fxn

    image_path -> path_to_image in a couple of places, plus motivation fo…

    fxn authored
    …r path_to_image in rdoc
  2. @fxn

    adds #favicon_link_tag back, rdoc explains why it is useful, and how …

    fxn authored
    …to get a link for Mobile Safari with it
Commits on Apr 8, 2010
  1. @dhh

    Revert "adds #favicon_link_tag and #apple_touch_icon_link_tag" -- the…

    dhh authored
    …se tags are too specific.
    
    This reverts commit 6891f46, ec8610c, and  d18ff1b.
Commits on Apr 7, 2010
  1. @fxn
  2. @fxn
Commits on Mar 29, 2010
  1. @wycats
  2. @craigw @wycats

    Allow customisation of asset path generation using a proc.

    craigw authored wycats committed
    Set config.action_controller.asset_path_template to a proc that takes one
    argument - the direct, unchanged asset path - and returns a path to that asset
    using the scheme that your assets require.
    
    This is useful if you have a setup which scales by introducing new application
    servers where the mtime of the asset files may not be the same as those of the
    asset files on your previous servers, but it does require your web servers to
    have knowledge of the asset template paths that you rewrite to so it's not
    suitable for out-of-the-box use. An example of configuring asset path
    generation and rewriting these paths using Apache is included in
    actionpack/lib/action_view/helpers/asset_tag_helper.rb.
    
    Signed-off-by: wycats <wycats@gmail.com>
Commits on Mar 26, 2010
  1. @wycats
Commits on Mar 25, 2010
  1. @retr0h @rizwanreza

    Updated ActionController::Base.asset_host example

    retr0h authored rizwanreza committed
    The example provided contrived.  It is not useful when wanting to use
    1-based asset hosts (since it would generate a random asset host for
    the same asset).
    
    Signed-off-by: Rizwan Reza <rizwanreza@gmail.com>
Commits on Mar 19, 2010
  1. @fxn @jeremy

    cleans a bit #compute_public_path

    fxn authored jeremy committed
    [#4232 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Mar 12, 2010
  1. @odorcicd @josevalim

    Made asset_tag_helper use config.perform_caching instead of ActionCon…

    odorcicd authored josevalim committed
    …troller::Base.perform_caching
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
  2. @eadz @jeremy

    simplify alt tag generation for images

    eadz authored jeremy committed
    [#2837 state:committed]
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Mar 4, 2010
  1. Fix a bunch of failing AP / AM specs created from the previous Abstra…

    Carl Lerche authored
    …ctController configuration refactor.
  2. Start refactoring the method of configuring ActionView

    Carlhuda authored Carl Lerche committed
Commits on Mar 3, 2010
Commits on Feb 1, 2010
  1. For performance reasons, you can no longer call html_safe! on Strings…

    Yehuda Katz authored
    …. Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will SafeBuffer.new(self).
    
      * Additionally, instead of doing concat("</form>".html_safe), you can do
        safe_concat("</form>"), which will skip both the flag set, and the flag
        check.
      * For the first pass, I converted virtually all #html_safe!s to #html_safe,
        and the tests pass. A further optimization would be to try to use
        #safe_concat as much as possible, reducing the performance impact if
        we know up front that a String is safe.
Commits on Jan 31, 2010
  1. @josh
Commits on Jan 30, 2010
  1. @josh

    Revert "Add rails.js driver to default source list"

    josh authored
    This reverts commit 8a46e11.
Commits on Jan 29, 2010
  1. @josh
Commits on Jan 22, 2010
  1. @josh
Commits on Oct 14, 2009
  1. @wycats

    Start adding configuration to ActionView instead of using constants.

    wycats authored
      By using config rather than hardcoded constants, we can evolve the
      configuration system over time (we'd just need to update the config
      method with more robust capabilities and all consumers would get
      the capabilities with no code changes)
Commits on Oct 7, 2009
  1. @NZKoz

    Switch to on-by-default XSS escaping for rails.

    NZKoz authored
      This consists of:
    
      * String#html_safe! a method to mark a string as 'safe'
      * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it
      * Calls to String#html_safe! throughout the rails helpers
      * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB)
      * New ERB implementation based on erubis which uses a SafeBuffer instead of a String
    
    Hat tip to Django for the inspiration.
Commits on Sep 13, 2009
  1. @josh
Commits on Sep 3, 2009
  1. @spohlenz @josh

    Don't raise exceptions for missing javascript_include_tag or styleshe…

    spohlenz authored josh committed
    …et_link_tag sources unless the :cache or :concat options are given. [#2738 state:resolved]
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Aug 5, 2009
  1. @matthewrudy @lifo

    Make sure javascript_include_tag/stylesheet_link_tag does not append …

    matthewrudy authored lifo committed
    …".js" or ".css" onto external urls [#1664 state:resolved]
    
    Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
Commits on Jul 30, 2009
  1. @marclove @wycats

    Fix tag helpers so that all HTML element boolean attributes render ac…

    marclove authored wycats committed
    …cording to the specs. Added all boolean attributes listed in the XHTML 1.0 specs (http://www.w3.org/TR/xhtml1/guidelines.html) and HTML 5 specs (http://www.whatwg.org/specs/web-apps/current-work). HTML 5 boolean attribute rendering was broken in commit 1e2d722 / [#2864 state:resolved].
    
    Signed-off-by: Yehuda Katz <wycats@gmail.com>
Commits on Jul 7, 2009
  1. @miloops

    Adds a audio_tag helper for the HTML5 audio tag. Fixed video_path doc…

    miloops authored Yehuda Katz committed
    …s. HTML attributes values should be true or false not attribute's name. [#2864 state:resolved]
    
    Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local>
Commits on Jul 2, 2009
  1. Removed unnecessary calls to image_path and hash lookups [#2827 state…

    Yehuda Katz + Carl Lerche authored
    …:resolved]
  2. @tiegz

    Adds a video_tag helper for the HTML5 video tag (similar to how the i…

    tiegz authored Yehuda Katz + Carl Lerche committed
    …mage_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes
    
    Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com>
Commits on Jun 26, 2009
  1. @NZKoz

    Handle missing javascript/stylesheets assets by raising an exception

    Christos Zisopoulos authored NZKoz committed
    An exception will be raised if a local javascript/stylesheet file included
    by the stylesheet_link_tag or javascript_include_tag can not be found.
    
    When caching is enabled, we use atomic_write to ensure that the cache file
    is not created with zero length.
    
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
    
    [#2738 state:committed]
Commits on Jun 15, 2009
  1. @josh

    Add :concat option to asset tag helpers to force concatenation.

    josh authored
    This is useful for working around IE's stylesheet limit.
    
      stylesheet_link_tag :all, :concat => true
Commits on Jun 11, 2009
  1. @akaspick @NZKoz

    allow absolute paths for the asset caches

    akaspick authored NZKoz committed
    Signed-off-by: Michael Koziarski <michael@koziarski.com>
Commits on Feb 5, 2009
  1. @pixeltrix @josh

    Eliminate unnecessary File.exist? when correct file extension given [#…

    pixeltrix authored josh committed
    …1879 state:resolved]
    
    Signed-off-by: Joshua Peek <josh@joshpeek.com>
Commits on Jan 18, 2009
  1. @lifo

    Merge docrails

    lifo authored
Something went wrong with that request. Please try again.