Skip to content
This repository

Mar 29, 2010

  1. Yehuda Katz

    Updated asset_template_path to asset_path and have it also support a …

    …String [#4247 state:resolved]
    wycats authored
  2. Craig R Webster

    Allow customisation of asset path generation using a proc.

    Set config.action_controller.asset_path_template to a proc that takes one
    argument - the direct, unchanged asset path - and returns a path to that asset
    using the scheme that your assets require.
    This is useful if you have a setup which scales by introducing new application
    servers where the mtime of the asset files may not be the same as those of the
    asset files on your previous servers, but it does require your web servers to
    have knowledge of the asset template paths that you rewrite to so it's not
    suitable for out-of-the-box use. An example of configuring asset path
    generation and rewriting these paths using Apache is included in
    Signed-off-by: wycats <>
    craigw authored wycats committed

Mar 26, 2010

  1. Yehuda Katz

    Merge branch 'master' into docrails

    wycats authored

Mar 25, 2010

  1. John Dewey

    Updated ActionController::Base.asset_host example

    The example provided contrived.  It is not useful when wanting to use
    1-based asset hosts (since it would generate a random asset host for
    the same asset).
    Signed-off-by: Rizwan Reza <>
    retr0h authored rizwanreza committed

Mar 19, 2010

  1. Xavier Noria

    cleans a bit #compute_public_path

    [#4232 state:committed]
    Signed-off-by: Jeremy Kemper <>
    fxn authored jeremy committed

Mar 12, 2010

  1. Denis Odorcic

    Made asset_tag_helper use config.perform_caching instead of ActionCon…

    Signed-off-by: José Valim <>
    odorcicd authored josevalim committed
  2. Eaden

    simplify alt tag generation for images

    [#2837 state:committed]
    Signed-off-by: Jeremy Kemper <>
    eadz authored jeremy committed

Mar 04, 2010

  1. Fix a bunch of failing AP / AM specs created from the previous Abstra…

    …ctController configuration refactor.
    Carl Lerche authored
  2. Start refactoring the method of configuring ActionView

    Carlhuda authored Carl Lerche committed

Mar 03, 2010

  1. Work on deprecating ActionController::Base.relative_url_root

    Carlhuda authored

Feb 01, 2010

  1. For performance reasons, you can no longer call html_safe! on Strings…

    …. Instead, all Strings are always not html_safe?. Instead, you can get a SafeBuffer from a String by calling #html_safe, which will
      * Additionally, instead of doing concat("</form>".html_safe), you can do
        safe_concat("</form>"), which will skip both the flag set, and the flag
      * For the first pass, I converted virtually all #html_safe!s to #html_safe,
        and the tests pass. A further optimization would be to try to use
        #safe_concat as much as possible, reducing the performance impact if
        we know up front that a String is safe.
    Yehuda Katz authored

Jan 31, 2010

  1. Joshua Peek

    Include prototype ujs adapter with new apps

    josh authored

Jan 30, 2010

  1. Joshua Peek

    Revert "Add rails.js driver to default source list"

    This reverts commit 8a46e11.
    josh authored

Jan 29, 2010

  1. Joshua Peek

    Add rails.js driver to default source list

    josh authored

Jan 22, 2010

  1. Joshua Peek

    Make @controller an internal ivar in the view

    josh authored

Oct 14, 2009

  1. Yehuda Katz

    Start adding configuration to ActionView instead of using constants.

      By using config rather than hardcoded constants, we can evolve the
      configuration system over time (we'd just need to update the config
      method with more robust capabilities and all consumers would get
      the capabilities with no code changes)
    wycats authored

Oct 07, 2009

  1. Michael Koziarski

    Switch to on-by-default XSS escaping for rails.

      This consists of:
      * String#html_safe! a method to mark a string as 'safe'
      * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it
      * Calls to String#html_safe! throughout the rails helpers
      * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB)
      * New ERB implementation based on erubis which uses a SafeBuffer instead of a String
    Hat tip to Django for the inspiration.
    NZKoz authored

Sep 13, 2009

  1. Joshua Peek

    Don't force test suite to use bundler

    josh authored

Sep 03, 2009

  1. Sam Pohlenz

    Don't raise exceptions for missing javascript_include_tag or styleshe…

    …et_link_tag sources unless the :cache or :concat options are given. [#2738 state:resolved]
    Signed-off-by: Joshua Peek <>
    spohlenz authored josh committed

Aug 05, 2009

  1. Matthew Rudy Jacobs

    Make sure javascript_include_tag/stylesheet_link_tag does not append …

    …".js" or ".css" onto external urls [#1664 state:resolved]
    Signed-off-by: Pratik Naik <>
    matthewrudy authored lifo committed

Jul 30, 2009

  1. Marc Love

    Fix tag helpers so that all HTML element boolean attributes render ac…

    …cording to the specs. Added all boolean attributes listed in the XHTML 1.0 specs ( and HTML 5 specs ( HTML 5 boolean attribute rendering was broken in commit 1e2d722 / [#2864 state:resolved].
    Signed-off-by: Yehuda Katz <>
    marclove authored wycats committed

Jul 07, 2009

  1. Emilio Tagua

    Adds a audio_tag helper for the HTML5 audio tag. Fixed video_path doc…

    …s. HTML attributes values should be true or false not attribute's name. [#2864 state:resolved]
    Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local>
    miloops authored Yehuda Katz committed

Jul 02, 2009

  1. Removed unnecessary calls to image_path and hash lookups [#2827 state…

    Yehuda Katz + Carl Lerche authored
  2. Tieg Zaharia

    Adds a video_tag helper for the HTML5 video tag (similar to how the i…

    …mage_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes
    Signed-off-by: Yehuda Katz + Carl Lerche <>
    tiegz authored Yehuda Katz + Carl Lerche committed

Jun 26, 2009

  1. Christos Zisopoulos

    Handle missing javascript/stylesheets assets by raising an exception

    An exception will be raised if a local javascript/stylesheet file included
    by the stylesheet_link_tag or javascript_include_tag can not be found.
    When caching is enabled, we use atomic_write to ensure that the cache file
    is not created with zero length.
    Signed-off-by: Michael Koziarski <>
    [#2738 state:committed]
    christos authored NZKoz committed

Jun 15, 2009

  1. Joshua Peek

    Add :concat option to asset tag helpers to force concatenation.

    This is useful for working around IE's stylesheet limit.
      stylesheet_link_tag :all, :concat => true
    josh authored

Jun 11, 2009

  1. Andrew Kaspick

    allow absolute paths for the asset caches

    Signed-off-by: Michael Koziarski <>
    akaspick authored NZKoz committed

Feb 05, 2009

  1. Andrew White

    Eliminate unnecessary File.exist? when correct file extension given [#…

    …1879 state:resolved]
    Signed-off-by: Joshua Peek <>
    pixeltrix authored josh committed

Jan 18, 2009

  1. Pratik

    Merge docrails

    lifo authored

Jan 04, 2009

  1. Joshua Peek

    Cache AssetTag timestamps

    josh authored

Jan 02, 2009

  1. Joshua Peek

    Revert to the good old days when AssetTag didn't cause anyone problems

    josh authored

Jan 01, 2009

  1. David Heinemeier Hansson

    Fixed the AssetTagHelper cache to use the computed asset host as part…

    … of the cache key instead of just assuming the its a string [#1299 state:committed]
    dhh authored

Dec 01, 2008

  1. Tekin Suleyman

    Ensure ActionMailer doesn't blow up when a two argument proc is set f…

    …or the asset host
    Signed-off-by: Michael Koziarski <>
    [#1394 state:committed]
    tekin authored NZKoz committed

Nov 29, 2008

  1. Sven Fuchs

    Make sure #compute_public_path caching allows to return different res…

    …ults for different given sources [#1471 state:resolved]
    Signed-off-by: Joshua Peek <>
    svenfuchs authored josh committed

Nov 27, 2008

  1. David Heinemeier Hansson

    Added the option to declare an asset_host as an object that responds …

    …to call (see for an example) [DHH]
    dhh authored
Something went wrong with that request. Please try again.