Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 4, 2012
  1. @pixeltrix

    Backport of fix from #5173 - fixes #7252

    pixeltrix authored
    Rather than use the MySQL specific TINYTEXT, MEDIUMTEXT and LONGTEXT
    datatypes, Active Record migrations use TEXT(n) where n is the limit
    specified by the developer. Unfortunately how MySQL interprets n
    depends on the column's encoding so any limit above 5592405 will be
    interpreted as a LONGTEXT when the encoding is UTF-8.
    
    This commit fixes this by interpreting the limit within the adapter
    and using the specific MySQL datatype as appropriate.
Commits on Jun 13, 2012
  1. @tenderlove
Commits on Jun 11, 2012
  1. @kennyj @tenderlove

    Fix GH #3163. Should quote database on mysql/mysql2.

    kennyj authored tenderlove committed
    Conflicts:
    
    	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
    
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb
    	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
    
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/mysql2_adapter.rb
    	activerecord/lib/active_record/connection_adapters/mysql_adapter.rb
    	activerecord/test/cases/adapters/mysql/mysql_adapter_test.rb
    	activerecord/test/cases/adapters/mysql2/schema_test.rb
Commits on Sep 9, 2011
  1. @tenderlove
Commits on Aug 16, 2011
  1. @tenderlove
Commits on Jun 9, 2011
  1. @bradrobertson
Commits on May 13, 2011
  1. @tenderlove
Commits on May 10, 2011
  1. @tenderlove
Commits on Apr 29, 2011
  1. @josevalim
Commits on Mar 21, 2011
  1. @tenderlove
  2. @tenderlove
Commits on Feb 9, 2011
  1. @metaskills @tenderlove

    Allow limit values to accept an ARel SQL literal.

    metaskills authored tenderlove committed
Commits on Jan 31, 2011
  1. @tenderlove @NZKoz

    limit() should sanitize limit values

    tenderlove authored NZKoz committed
    This fixes CVE-2011-0448
Commits on Dec 29, 2010
  1. @lifo

    Make serialized fixtures work again

    lifo authored
    Conflicts:
    
    	activerecord/lib/active_record/connection_adapters/abstract/quoting.rb
    	activerecord/test/cases/base_test.rb
    	activerecord/test/cases/quoting_test.rb
Commits on Dec 9, 2010
  1. @matthewrudy @tenderlove

    Cleaner way to extract the Postgres version

    matthewrudy authored tenderlove committed
  2. @matthewrudy @tenderlove
Commits on Nov 24, 2010
  1. @raggi @tenderlove

    Don't depend on rubygems loading thread (for Mutex)

    raggi authored tenderlove committed
Commits on Nov 18, 2010
  1. @alexrothenberg @tenderlove

    Adapters can specify maximum number of ids they support in a list of …

    alexrothenberg authored tenderlove committed
    …expressions
    
    (default is nil meaning unlimited but Oracle imposes a limit of 1000)
    Limit is used to make multiple queries when preloading associated has_many or habtm records
Commits on Oct 6, 2010
  1. @tenderlove

    fix ruby 1.9 deadlock problem, fixes #5736 add connection pool tests

    Hemant Kumar authored tenderlove committed
Commits on Sep 29, 2010
  1. @tenderlove

    each works well too

    tenderlove authored
  2. @tenderlove
Commits on Sep 28, 2010
  1. @etiennebarrie @tenderlove
Commits on Sep 27, 2010
  1. @josevalim

    Fix issue with remove_index and add unit test [#5645 state:resolved]

    Tim Connor authored josevalim committed
    Signed-off-by: José Valim <jose.valim@gmail.com>
  2. @josevalim

    Raise errors when index creation fails

    Tim Connor authored josevalim committed
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Sep 26, 2010
  1. @spastorino

    Fix remove_index issue when provided :name is a symbol

    Tim Connor authored spastorino committed
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Sep 24, 2010
  1. @miloops @spastorino

    No need to use inject here.

    miloops authored spastorino committed
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Sep 22, 2010
  1. @spastorino

    Missing the mysql2 gem here

    spastorino authored
  2. @neerajdotname @spastorino

    Error message should advice to use 'mysql2' gem.

    neerajdotname authored spastorino committed
    If I create a new app using command
    rails new demo -d mysql
    then Gemfile contains 'mysql2' gem by default.
    
    However if mysql gem is missing then error message says
    raise "!!! Missing the mysql gem. Add it to your Gemfile: gem 'mysql', '2.8.1'"
    
    [#5569 state:committed]
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Sep 19, 2010
  1. @tchandy @spastorino

    Exception handling more readable

    tchandy authored spastorino committed
    [#5601 state:committed]
    
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Aug 23, 2010
  1. @brianmario @spastorino

    mysql2 adapter is being maintained in the mysql2 gem itself

    brianmario authored spastorino committed
    Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
Commits on Aug 20, 2010
  1. @tenderlove
  2. @tenderlove
Commits on Aug 19, 2010
  1. @tenderlove

    removing useless ternary

    tenderlove authored
  2. @tenderlove

    refactor if / else to ||=

    tenderlove authored
Commits on Aug 17, 2010
  1. @Jeff-Lawson @tenderlove
Something went wrong with that request. Please try again.