Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Tag: v3.1.0.rc6
Commits on Aug 15, 2011
  1. @jonleighton

    Support updates with joins. Fixes #522.

    jonleighton authored
  2. @jonleighton

    Merge pull request #2538 from arunagw/notifications_test_fix

    jonleighton authored
    Notifications test fix
  3. @arunagw

    Notification Test Fix

    arunagw authored
  4. @spastorino

    rake assets:precompile executes in production environment as default …

    spastorino authored
    …if RAILS_ENV was not provided
  5. @jonleighton
  6. @jonleighton
  7. @jonleighton

    Merge pull request #2535 from arunagw/delegation_fix

    jonleighton authored
    Delegation fix
  8. @arunagw

    Including delegation

    arunagw authored
  9. @jonleighton
  10. @jonleighton
  11. @jonleighton
  12. @jonleighton
Commits on Aug 14, 2011
  1. @josevalim
  2. @spastorino

    Merge pull request #2522 from arunagw/railties_test_fix

    spastorino authored
    Railties test fix
  3. @arunagw
  4. @arunagw
Commits on Aug 13, 2011
  1. @spastorino

    Merge pull request #2518 from myronmarston/fix_active_record_observer…

    spastorino authored
    Fix active record observer disabling for 3-1-stable
  2. @myronmarston

    Allow ActiveRecord observers to be disabled.

    myronmarston authored
    We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
  3. @jonleighton
  4. @jonleighton
  5. @jonleighton

    Work around for lolruby bug. (Read on for explanation.)

    jonleighton authored
    We were experiencing CI test failures, for example:
    * 3-1-stable:!/rails/rails/builds/79473/L407
    * master:!/rails/rails/builds/79507/L80
    These failures only happened on 1.8.7-p352, and we were only able to
    reproduce on the Travis CI VM worker. We even tried creating a new 32
    bit Ubuntu VM and running the tests on that, and it all worked fine.
    After some epic trial and error, we discovered that replacing the
      fuu = Marshal.load(Marshal.dump(fuu))
      marshalled = Marshal.dump(fuu)
      fuu = Marshal.load(marshalled)
    seemed to prevent the failure.
    We have NO IDEA why this is. If anyone has some great insight to
    contribute then that is welcome. Otherwise, hopefully this will just
    help us get the CI green again.
    Many thanks to @joshk for help with sorting this out.
  6. @spastorino

    Merge pull request #2512 from arunagw/cant_dup_on_nil_3-1-stable

    spastorino authored
    Cant dup on nil 3 1 stable
  7. @arunagw
Commits on Aug 11, 2011
  1. @spastorino

    Merge pull request #2497 from akaspick/url_for_fix

    spastorino authored
    When calling url_for with a hash, additional (likely unwanted) values (such as :host) would be returned in the hash
  2. @spastorino

    Merge pull request #2489 from grzuy/master

    spastorino authored
    Remove parameters_for_url from form_tag method header
Commits on Aug 10, 2011
  1. @tenderlove

    Revert "Ensure original exception message is present in both Template…

    tenderlove authored
    …::Error#message and Template::Error#inspect."
    This reverts commit 403b06e.
    The call to `message` calls `inspect` on our exception.  The exception
    holds a reference to the environment, and the controller.  This string
    becomes very large, and the call to `super` dups the string (in tern
    doubling the memory used).  I'm reverting this for 3.1 but leaving the
    commit on master.  We should stop holding references to so many objects
    and reduce the size of our inspect.
  2. @tenderlove
Commits on Aug 9, 2011
  1. @spastorino
  2. @jonleighton
  3. @tenderlove
Commits on Aug 8, 2011
  1. @jonleighton
  2. @jonleighton

    Bump arel version

    jonleighton authored
  3. @jonleighton
  4. @jonleighton

    Make it the responsibility of the connection to hold onto an ARel vis…

    jonleighton authored
    …itor for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
  5. @spastorino
Something went wrong with that request. Please try again.