Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Aug 13, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Aug 8, 2011
  1. @jonleighton
  2. @jonleighton

    Make it the responsibility of the connection to hold onto an ARel vis…

    jonleighton authored
    …itor for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
    
    Conflicts:
    
    	activerecord/lib/active_record/relation/finder_methods.rb
    	activerecord/test/cases/adapter_test.rb
Commits on Aug 4, 2011
  1. @fxn

    Revert "Explicitly included hashes in sentence regarding SQL-injectio…

    fxn authored
    …n-safe forms"
    
    Reason: The hash form is secure, and preferred over the array form if possible.
    
    This reverts commit 6dc7495.
  2. @campbell @fxn
Commits on Aug 3, 2011
  1. @tenderlove
Commits on Jul 23, 2011
  1. @spastorino

    Revert "Merge pull request #2194 from cldwalker/after_initialize"

    spastorino authored
    This reverts commit 1983007, reversing
    changes made to ae65c0b.
  2. @spastorino

    Merge pull request #2194 from cldwalker/after_initialize

    spastorino authored
    Fix after_initialize and Base.create edge case
  3. @vijaydev @fxn

    use simpler words in docs

    vijaydev authored fxn committed
  4. @hmcfletch @cldwalker

    fix after_initialize edge case (close #2074 and close #2175)

    hmcfletch authored cldwalker committed
    fix behavior when after_initialize is defined and a block is passed to Base.create
Commits on Jul 17, 2011
  1. @sikachu

    Show a deprecation warning if user passing less number of argument in…

    sikachu authored
    … the dynamic finder
    
    The previous behavior was unintentional, and some people was relying on it. In the next version of Rails, the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) It will raise the ArgumentError otherwise.
Commits on Jul 16, 2011
  1. @elight

    Closes #2065

    elight authored
    Cache key was incorrectly using timezone-dependent record#updated_at when it should be using a timezone-independent value to generate the cache key
Commits on Jul 4, 2011
  1. @pixeltrix
Commits on Jun 30, 2011
  1. @tenderlove
  2. @tenderlove
Commits on Jun 29, 2011
  1. @jonleighton

    Define to_ary on ActiveRecord::Base to return nil. Improve performanc…

    jonleighton authored
    …e of Array#flatten under 1.9, see comment for details.
Commits on Jun 28, 2011
  1. @dmathieu @tenderlove

    comparing different classes returns nil

    dmathieu authored tenderlove committed
  2. @dmathieu @tenderlove

    allow comparison on model objects - Closes #1858

    dmathieu authored tenderlove committed
  3. @tenderlove

    remove useless assignment

    tenderlove authored
  4. @tenderlove
  5. @tenderlove

    remove the check for needs_type_condition? because ensure_proper_type…

    tenderlove authored
    … will pick up the type column
  6. @tenderlove
  7. @tenderlove
  8. @tenderlove
  9. @tenderlove
Commits on Jun 27, 2011
  1. @tenderlove
  2. @tenderlove
Commits on Jun 16, 2011
  1. @jonleighton
Commits on Jun 13, 2011
  1. @pixeltrix
Commits on Jun 9, 2011
  1. @dmathieu @tenderlove
Commits on Jun 1, 2011
  1. @pixeltrix

    Raise NameError instead of ArgumentError in ActiveSupport::Dependencies

    pixeltrix authored
    ActiveSupport::Dependencies now raises NameError if it finds an existing
    constant in load_missing_constant. This better reflects the nature of
    the error which is usually caused by calling constantize on a nested constant.
    
    Closes #1423
Commits on May 25, 2011
  1. @joshk
Commits on May 24, 2011
  1. @jonleighton
Commits on May 21, 2011
  1. @fxn

    Merge pull request #1180 from Karunakar/documentation_change

    fxn authored
    Documentation Error Fixed for ticket #839
Something went wrong with that request. Please try again.