Skip to content
This repository

Aug 13, 2011

  1. Myron Marston

    Allow ActiveRecord observers to be disabled.

    We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
    myronmarston authored

May 21, 2011

  1. Ganesh Kumar

    ActionMailer deliver method Documentation corrected Ticket #761

May 19, 2011

  1. Guillermo Iguaran

    Prefer each instead of for in

May 06, 2011

  1. Myron Marston

    Add documentation for new observer enable/disable feature.

Apr 30, 2011

  1. Sebastian Martinez

    Improved ActiveModel Observing docs.

    smartinez87 authored

Apr 28, 2011

  1. Myron Marston

    Fix bug with AM::Observer disablement.

    Now that we propagate the enabling/disabling to descendants, we no longer have to check the disabled_observer Set on each superclass of the model class.  This was causing a bug when disabling all observers at a superclass level and then enabling an individual observer at a subclass level.
    
    Plus the logic is simpler now :).
    myronmarston authored
  2. Myron Marston

    Fix dev env memory leaks by using AS::DescendantsTracker rather than …

    …keeping track of subclasses manually.
    
    There's also no need to keep track of all ObserverArray instances in a hash, as this is likely to leak memory, too.
    myronmarston authored
  3. Myron Marston

    Revert "Revert "Handle enabling/disabling observers at different leve…

    …ls of the class hierarchy.""
    
    This reverts commit 2a25c58.
    
    I'm going to add another commit that keeps the same behavior of fixes
    the problems of leaking memory in development.
    myronmarston authored
  4. José Valim

    Revert "Handle enabling/disabling observers at different levels of th…

    …e class hierarchy."
    
    This reverts commit ad62f19 because the current
    subclasses implementation leaks memory in development.
    
    Instead of keeping an array of subclasses, the better solution is to
    ask the parent if an observer is being disabled or not.
    josevalim authored
  5. Myron Marston

    Handle enabling/disabling observers at different levels of the class …

    …hierarchy.
    
    Last call wins.
    myronmarston authored dhh committed
  6. Myron Marston

    Allow observers to be enabled and disabled.

    This is useful in situations like model unit tests and the occasional rake task to backfill old data.
    myronmarston authored dhh committed
  7. Myron Marston

    Wrap line that is over 200 characters long. Now it's much easier to r…

    …ead.
    myronmarston authored dhh committed

Apr 22, 2011

  1. Josh Kalderimis

    minor correction to the Active Model instantiate_observers doc

    joshk authored

Mar 06, 2011

  1. Paco Guzmán

    remove unused assigned variable

    pacoguzman authored

Feb 21, 2011

  1. Xavier Noria

    copy-edits 6d7a826

    fxn authored
  2. Nick Rowe

    Documentation: Added small comments to Observering module

    nixterrimus authored

Feb 16, 2011

  1. Jimmy Cuadra

    add note about observer config for rails apps

    ActiveModel::Observer and ActiveRecord::Observer have similar
    documentation, but a Rails user looking at the ActiveModel version
    might not realize that a change to config/application.rb is
    required to activate the observer. This change adds a note to
    that effect, pointing to the AR version from the AM version.
    jimmycuadra authored

Jan 15, 2011

  1. Ravil Bayramgalin

    Remove reference to ActiveRecord from ActiveModel comments

    brainopia authored

Sep 01, 2010

  1. Subba Rao Pasupuleti

    reader method eliminates defined? checks

    Signed-off-by: José Valim <jose.valim@gmail.com>
    subbarao authored josevalim committed

Aug 26, 2010

  1. Jaime Iniesta

    lifecycle should be two words, life cycle

    jaimeiniesta authored fxn committed

Aug 14, 2010

  1. Santiago Pastorino

    Deletes trailing whitespaces (over text files only find * -type f -ex…

    …ec sed 's/[ \t]*$//' -i {} \;)
    spastorino authored

Jul 08, 2010

  1. José Valim

    Improve a bit the code in latest commits.

    josevalim authored
  2. Łukasz Strzałkowski

    Removing method before redefining it. It was causing warnings. [#5072

    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    strzalek authored josevalim committed

Jun 26, 2010

  1. Santiago Pastorino

    Move constantize from conversions to inflections.

    This removes ActiveModel dependency on TZInfo.
    
    [#4979 state:committed]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
    spastorino authored josevalim committed

Jun 14, 2010

  1. Rizwan Reza

    Revised and added headings.

    rizwanreza authored

Jun 07, 2010

  1. Santiago Pastorino

    Observing module is using constantize

    spastorino authored Carl Lerche committed

Apr 16, 2010

  1. Jeremy Kemper

    Fix Active Model observer tests

    jeremy authored
  2. Mislav Marohnić

    ActiveModel::Observing: stop using Observable Ruby module, re-impleme…

    …nt `notify_observers`
    
    `Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
    callback chains) and has extra features (like `changed`) that were never used.
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
    mislav authored jeremy committed

Jan 18, 2010

  1. Fixing documentation on ActiveModel::Observer#observed_classes

    Gavin Stark authored mwhuss committed

Jan 17, 2010

  1. Mikel Lindsaar

    Fixing documentation for ActiveModel::Observer

    mikel authored

Sep 02, 2009

  1. Joshua Peek

    Kill AMo observing wrap_with_notifications since ARes was only using it

    josh authored

Jul 21, 2009

  1. Joshua Peek

    Improve AMo observing docs

    josh authored
  2. Joshua Peek

    Add wrap_with_notifications helper to AMo observing

    josh authored

Jun 11, 2009

  1. Joshua Peek

    Move observing notify helper into AMo

    josh authored
  2. Joshua Peek

    Fix observing AS dependencies

    josh authored
Something went wrong with that request. Please try again.