Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Aug 13, 2011
  1. Myron Marston

    Allow ActiveRecord observers to be disabled.

    myronmarston authored
    We have to use Observer#update rather than Observer#send since the enabled state is checked in #update before forwarding the method call on.
Commits on May 21, 2011
  1. Ganesh Kumar
Commits on May 19, 2011
  1. Guillermo Iguaran
Commits on May 6, 2011
  1. Myron Marston
Commits on Apr 30, 2011
  1. Sebastian Martinez
Commits on Apr 28, 2011
  1. Myron Marston

    Fix bug with AM::Observer disablement.

    myronmarston authored
    Now that we propagate the enabling/disabling to descendants, we no longer have to check the disabled_observer Set on each superclass of the model class.  This was causing a bug when disabling all observers at a superclass level and then enabling an individual observer at a subclass level.
    
    Plus the logic is simpler now :).
  2. Myron Marston

    Fix dev env memory leaks by using AS::DescendantsTracker rather than …

    myronmarston authored
    …keeping track of subclasses manually.
    
    There's also no need to keep track of all ObserverArray instances in a hash, as this is likely to leak memory, too.
  3. Myron Marston

    Revert "Revert "Handle enabling/disabling observers at different leve…

    myronmarston authored
    …ls of the class hierarchy.""
    
    This reverts commit 2a25c58.
    
    I'm going to add another commit that keeps the same behavior of fixes
    the problems of leaking memory in development.
  4. José Valim

    Revert "Handle enabling/disabling observers at different levels of th…

    josevalim authored
    …e class hierarchy."
    
    This reverts commit ad62f19 because the current
    subclasses implementation leaks memory in development.
    
    Instead of keeping an array of subclasses, the better solution is to
    ask the parent if an observer is being disabled or not.
  5. Myron Marston David Heinemeier Hansson

    Handle enabling/disabling observers at different levels of the class …

    myronmarston authored dhh committed
    …hierarchy.
    
    Last call wins.
  6. Myron Marston David Heinemeier Hansson

    Allow observers to be enabled and disabled.

    myronmarston authored dhh committed
    This is useful in situations like model unit tests and the occasional rake task to backfill old data.
  7. Myron Marston David Heinemeier Hansson
Commits on Apr 22, 2011
  1. Josh Kalderimis
Commits on Mar 6, 2011
  1. Paco Guzmán
Commits on Feb 21, 2011
  1. Xavier Noria

    copy-edits 6d7a826

    fxn authored
  2. Nick Rowe
Commits on Feb 16, 2011
  1. Jimmy Cuadra

    add note about observer config for rails apps

    jimmycuadra authored
    ActiveModel::Observer and ActiveRecord::Observer have similar
    documentation, but a Rails user looking at the ActiveModel version
    might not realize that a change to config/application.rb is
    required to activate the observer. This change adds a note to
    that effect, pointing to the AR version from the AM version.
Commits on Jan 15, 2011
  1. Ravil Bayramgalin
Commits on Sep 1, 2010
  1. Subba Rao Pasupuleti José Valim

    reader method eliminates defined? checks

    subbarao authored josevalim committed
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Aug 26, 2010
  1. Jaime Iniesta Xavier Noria

    lifecycle should be two words, life cycle

    jaimeiniesta authored fxn committed
Commits on Aug 14, 2010
  1. Santiago Pastorino

    Deletes trailing whitespaces (over text files only find * -type f -ex…

    spastorino authored
    …ec sed 's/[ \t]*$//' -i {} \;)
Commits on Jul 8, 2010
  1. José Valim
  2. Łukasz Strzałkowski José Valim

    Removing method before redefining it. It was causing warnings. [#5072

    strzalek authored josevalim committed
    …state:resolved]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 26, 2010
  1. Santiago Pastorino José Valim

    Move constantize from conversions to inflections.

    spastorino authored josevalim committed
    This removes ActiveModel dependency on TZInfo.
    
    [#4979 state:committed]
    
    Signed-off-by: José Valim <jose.valim@gmail.com>
Commits on Jun 14, 2010
  1. Rizwan Reza

    Revised and added headings.

    rizwanreza authored
Commits on Jun 7, 2010
  1. Santiago Pastorino

    Observing module is using constantize

    spastorino authored Carl Lerche committed
Commits on Apr 16, 2010
  1. Jeremy Kemper

    Fix Active Model observer tests

    jeremy authored
  2. Mislav Marohnić Jeremy Kemper

    ActiveModel::Observing: stop using Observable Ruby module, re-impleme…

    mislav authored jeremy committed
    …nt `notify_observers`
    
    `Observable#notify_observers` from Ruby always returns false (which halts ActiveRecord
    callback chains) and has extra features (like `changed`) that were never used.
    
    Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
Commits on Jan 18, 2010
  1. Marshall Huss

    Fixing documentation on ActiveModel::Observer#observed_classes

    Gavin Stark authored mwhuss committed
Commits on Jan 17, 2010
  1. Mikel Lindsaar
Commits on Sep 2, 2009
  1. Joshua Peek
Commits on Jul 21, 2009
  1. Joshua Peek

    Improve AMo observing docs

    josh authored
  2. Joshua Peek
Commits on Jun 11, 2009
  1. Joshua Peek
  2. Joshua Peek

    Fix observing AS dependencies

    josh authored
Something went wrong with that request. Please try again.