Skip to content
Commits on Dec 23, 2012
  1. @tenderlove
Commits on May 1, 2012
  1. @vijaydev
Commits on Mar 29, 2012
  1. @arturopie

    refactor instantiate method in base, so we remove nesting if's which …

    arturopie committed
    …make the code harder to read. Minor changes to contain_all_columns in IdentityMap.
Commits on Jan 12, 2012
  1. @tomstuart
Commits on Dec 8, 2011
  1. @josevalim

    Remove NilClass whiners feature.

    josevalim committed
    Removing this feature causes boost in performance when using Ruby 1.9.
    Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str`
    in some STDLIB methods (like Array#join). To do such implicit conversions,
    Ruby 1.9 always dispatches the method and rescues the NoMethodError exception
    in case one is raised.
    Therefore, since the whiners feature defined NilClass#method_missing, such
    implicit conversions for nil became much, much slower. In fact, just defining
    NilClass#method_missing (even without the whiners feature) already causes a
    massive slow down. Here is a snippet that shows such slow down:
        require "benchmark"
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
        class NilClass
          def method_missing(*args)
            raise NoMethodError
        Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
Commits on Nov 8, 2011
  1. @amatsuda @vijaydev

    self.up, self.down => up, down

    amatsuda committed with vijaydev
Commits on Oct 14, 2011
  1. @vijaydev

    change activerecord query conditions example to avoid 'type' as colum…

    Steve Bourne committed with vijaydev
    …n name
    'Type' is a reserved column for STI.  Changed conditions example to
    avoid using that column name as an example.  The example isn't
    STI-related (and mentioning STI here is needless clutter), so changing
    to avoid accidentally encouraging users to use 'type' as a column name
    for other purposes.
Commits on Sep 26, 2011
  1. @jonleighton
Commits on Aug 25, 2011
  1. @amatsuda @tenderlove
Commits on Aug 13, 2011
  1. @jonleighton
  2. @jonleighton
Commits on Aug 8, 2011
  1. @jonleighton
  2. @jonleighton

    Make it the responsibility of the connection to hold onto an ARel vis…

    jonleighton committed
    …itor for generating SQL. This improves the code architecture generally, and solves some problems with marshalling. Adapter authors please take note: you now need to define an Adapter.visitor_for method, but it degrades gracefully with a deprecation warning for now.
Commits on Aug 4, 2011
  1. @fxn

    Revert "Explicitly included hashes in sentence regarding SQL-injectio…

    fxn committed
    …n-safe forms"
    Reason: The hash form is secure, and preferred over the array form if possible.
    This reverts commit 6dc7495.
  2. @campbell @fxn
Commits on Aug 3, 2011
  1. @tenderlove
Commits on Jul 23, 2011
  1. @spastorino

    Revert "Merge pull request #2194 from cldwalker/after_initialize"

    spastorino committed
    This reverts commit 1983007, reversing
    changes made to ae65c0b.
  2. @spastorino

    Merge pull request #2194 from cldwalker/after_initialize

    spastorino committed
    Fix after_initialize and Base.create edge case
  3. @vijaydev @fxn

    use simpler words in docs

    vijaydev committed with fxn
  4. @hmcfletch @cldwalker

    fix after_initialize edge case (close #2074 and close #2175)

    hmcfletch committed with cldwalker
    fix behavior when after_initialize is defined and a block is passed to Base.create
Commits on Jul 17, 2011
  1. @sikachu

    Show a deprecation warning if user passing less number of argument in…

    sikachu committed
    … the dynamic finder
    The previous behavior was unintentional, and some people was relying on it. In the next version of Rails, the dynamic finder will always expecting the number of arguments to be equal or greater (so you can still pass the options to it.) It will raise the ArgumentError otherwise.
Commits on Jul 16, 2011
  1. @elight

    Closes #2065

    elight committed
    Cache key was incorrectly using timezone-dependent record#updated_at when it should be using a timezone-independent value to generate the cache key
Commits on Jul 4, 2011
  1. @pixeltrix
Commits on Jun 30, 2011
  1. @tenderlove
  2. @tenderlove
Commits on Jun 29, 2011
  1. @jonleighton

    Define to_ary on ActiveRecord::Base to return nil. Improve performanc…

    jonleighton committed
    …e of Array#flatten under 1.9, see comment for details.
Commits on Jun 28, 2011
  1. @dmathieu @tenderlove
  2. @dmathieu @tenderlove
  3. @tenderlove

    remove useless assignment

    tenderlove committed
  4. @tenderlove
  5. @tenderlove

    remove the check for needs_type_condition? because ensure_proper_type…

    tenderlove committed
    … will pick up the type column
  6. @tenderlove
  7. @tenderlove
  8. @tenderlove
  9. @tenderlove
Something went wrong with that request. Please try again.